From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A3CC04AAF for ; Tue, 21 May 2019 11:19:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E13E20863 for ; Tue, 21 May 2019 11:19:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726525AbfEULTF (ORCPT ); Tue, 21 May 2019 07:19:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57602 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbfEULTF (ORCPT ); Tue, 21 May 2019 07:19:05 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31A013082E6B; Tue, 21 May 2019 11:19:00 +0000 (UTC) Received: from [10.10.66.2] (ovpn-66-2.rdu2.redhat.com [10.10.66.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3773665F4; Tue, 21 May 2019 11:18:57 +0000 (UTC) From: "Benjamin Coddington" To: "J. Bruce Fields" Cc: "Xuewei Zhang" , jlayton@kernel.org, "Grigor Avagyan" , "Trevor Bourget" , "Nauman Rafique" , trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH] lockd: Show pid of lockd for remote locks Date: Tue, 21 May 2019 07:18:57 -0400 Message-ID: In-Reply-To: <20190520205106.GA29025@fieldses.org> References: <3A924C3F-A161-4EE2-A74E-2EE1B6D2CA14@redhat.com> <20190520205106.GA29025@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 21 May 2019 11:19:05 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 20 May 2019, at 16:51, J. Bruce Fields wrote: > On Mon, May 20, 2019 at 10:22:00AM -0400, Benjamin Coddington wrote: >> Ok, I just noticed that we set fl_owner to the nlm_host in >> nlm4svc_retrieve_args, so things are not as dire as I thought. What >> would be nice is a sane set of tests for NLM.. > > What would we have needed to catch this? Sounds like it turns > multi-client testing wouldn't have been required? (Not that that > would > be a bad idea.) Two NLM clients would be ideal to exercise the full range of expected lock behavior. I suspect that's something I can do with what's in pynfs today, but I haven't looked yet. I suppose if there's a test for NLM I should make one for v4 too.. Ben