From: "Benjamin Coddington" <bcodding@redhat.com>
To: "Trond Myklebust" <trondmy@hammerspace.com>
Cc: anna.schumaker@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] NFS: Don't skip lookup when holding a delegation
Date: Thu, 16 Jan 2020 11:32:01 -0500 [thread overview]
Message-ID: <C5892E37-4731-4AD5-97FE-D8151C289CE9@redhat.com> (raw)
In-Reply-To: <d8639ad40df3b0a814e7396e1e824220c4d21a55.camel@hammerspace.com>
On 16 Jan 2020, at 11:02, Trond Myklebust wrote:
> We should need to perform this revalidation once, and only once for
> that directory, and only if we opened the file using a CLAIM_FH open,
> or if we opened it through a different hard linked name (and did not
> create this hard link after we got the delegation).
>
> Perhaps we could define a magic value for dentry->d_time that causes us
> to skip revalidation if and only if we hold a delegation?
Can we put the delegation's change_attr in d_time for dentries that have
been revalided while holding a delegation?
Ben
next prev parent reply other threads:[~2020-01-16 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 14:49 [PATCH v2] NFS: Don't skip lookup when holding a delegation Benjamin Coddington
2020-01-16 15:19 ` Benjamin Coddington
2020-01-16 16:02 ` Trond Myklebust
2020-01-16 16:32 ` Benjamin Coddington [this message]
2020-01-16 16:44 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5892E37-4731-4AD5-97FE-D8151C289CE9@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).