From: Linus Torvalds <torvalds@linux-foundation.org>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: "Anna.Schumaker@netapp.com" <Anna.Schumaker@netapp.com>,
"neilb@suse.com" <neilb@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [GIT PULL] Please pull NFS client updates for 4.21
Date: Thu, 3 Jan 2019 12:53:00 -0800 [thread overview]
Message-ID: <CAHk-=whVxZ54i9uhXkWoaP+K1y4wu0J5z7d_mZ=-Zcpi5UhZww@mail.gmail.com> (raw)
In-Reply-To: <55e9d0eb47662f2d6c308eba8b9a84fbba978ac8.camel@hammerspace.com>
On Wed, Jan 2, 2019 at 10:10 PM Trond Myklebust <trondmy@hammerspace.com> wrote:
>
> The values being compared are in cred_fscmp() are all of type kuid_t or
> kgid_t so that means they have already been mapped from the user
> namespace into the kernel uid/gid space.
Ok, "everything happens in init_ns" is I guess a very valid argument.
It might be good to perhaps show that in the name (and maybe even a
comment), but as long as it's only really used for nfs I guess it
isn't a big deal.
Thanks,
Linus
next prev parent reply other threads:[~2019-01-03 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 22:42 [GIT PULL] Please pull NFS client updates for 4.21 Schumaker, Anna
2019-01-03 0:48 ` Linus Torvalds
2019-01-03 4:53 ` NeilBrown
2019-01-03 6:09 ` Trond Myklebust
2019-01-03 20:47 ` Eric W. Biederman
2019-01-03 20:53 ` Linus Torvalds [this message]
2019-01-03 2:40 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whVxZ54i9uhXkWoaP+K1y4wu0J5z7d_mZ=-Zcpi5UhZww@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).