linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rosen Penev <rosenp@gmail.com>
To: Steve Dickson <steved@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] libtirpc: add missing extern
Date: Mon, 24 Oct 2022 12:39:37 -0700	[thread overview]
Message-ID: <CAKxU2N_oWP2joevtFdkbME3AEcKfQ-HMrnOEB+poZj-wPm5cRQ@mail.gmail.com> (raw)
In-Reply-To: <CAKxU2N8azu-nfzocWZDCGVj3Yawqnc6HjzvzeFktAn-57PHzPA@mail.gmail.com>

On Tue, Sep 20, 2022 at 1:31 PM Rosen Penev <rosenp@gmail.com> wrote:
>
> On Tue, Sep 20, 2022 at 12:28 PM Steve Dickson <steved@redhat.com> wrote:
> >
> >
> >
> > On 9/19/22 7:59 PM, Rosen Penev wrote:
> > > Fixes compilation warning.
> > What was the warning? Plus AUTH_DES is no longer supported.
> Implicit function declaration as it's not in a header file or anything.
>
> I found the issue from doing a meson conversion for libtirpc:
> https://github.com/mesonbuild/wrapdb/pull/644
>
> I have no idea about AUTH_DES or what it's used for.
ping.
> >
> > steved.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > > ---
> > >   src/svc_auth.c | 3 +++
> > >   1 file changed, 3 insertions(+)
> > >
> > > diff --git a/src/svc_auth.c b/src/svc_auth.c
> > > index ce8bbd8..789d6af 100644
> > > --- a/src/svc_auth.c
> > > +++ b/src/svc_auth.c
> > > @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
> > >
> > >   extern SVCAUTH svc_auth_none;
> > >
> > > +#ifdef AUTHDES_SUPPORT
> > > +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> > > +#endif
> > >   /*
> > >    * The call rpc message, msg has been obtained from the wire.  The msg contains
> > >    * the raw form of credentials and verifiers.  authenticate returns AUTH_OK
> >

  reply	other threads:[~2022-10-24 21:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 23:59 [PATCH] libtirpc: add missing extern Rosen Penev
2022-09-20 19:28 ` Steve Dickson
2022-09-20 20:31   ` Rosen Penev
2022-10-24 19:39     ` Rosen Penev [this message]
2022-10-25 16:36 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKxU2N_oWP2joevtFdkbME3AEcKfQ-HMrnOEB+poZj-wPm5cRQ@mail.gmail.com \
    --to=rosenp@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).