linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Wysochanski <dwysocha@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH RFC 00/21] NFSD callback and lease management observability
Date: Mon, 10 May 2021 13:24:08 -0400	[thread overview]
Message-ID: <CALF+zOkyPOr+mXu+N-GKvusremTDZ53zTF_YiqFXgTRc2JC58g@mail.gmail.com> (raw)
In-Reply-To: <162066179690.94415.203187037032448300.stgit@klimt.1015granger.net>

On Mon, May 10, 2021 at 11:51 AM Chuck Lever <chuck.lever@oracle.com> wrote:
>
> Happy Monday.
>
> I've hacked together some improvements to the tracepoints that record
> server callback and lease management activity. I'm interested in
> review comments and testing. I'm sure I've missed your favorite edge
> case, so please let me know what it is!
>

I will take a look at these, especially with an eye towards some of
the recent discussions about duplicate client ids.
Building now (against 5.13-rc1).

Thanks Chuck!

> ---
>
> Chuck Lever (21):
>       NFSD: Constify @fh argument of knfsd_fh_hash()
>       NFSD: Capture every CB state transition
>       NFSD: Drop TRACE_DEFINE_ENUM for NFSD4_CB_<state> macros
>       NFSD: Add cb_lost tracepoint
>       NFSD: Adjust cb_shutdown tracepoint
>       NFSD: Remove spurious cb_setup_err tracepoint
>       NFSD: Enhance the nfsd_cb_setup tracepoint
>       NFSD: Add an nfsd_cb_lm_notify tracepoint
>       NFSD: Add an nfsd_cb_offload tracepoint
>       NFSD: Replace the nfsd_deleg_break tracepoint
>       NFSD: Add an nfsd_cb_probe tracepoint
>       NFSD: Remove the nfsd_cb_work and nfsd_cb_done tracepoints
>       NFSD: Update nfsd_cb_args tracepoint
>       NFSD: Add nfsd_clid_cred_mismatch tracepoint
>       NFSD: Add nfsd_clid_verf_mismatch tracepoint
>       NFSD: Remove nfsd_clid_inuse_err
>       NFSD: Add nfsd_clid_confirmed tracepoint
>       NFSD: Add nfsd_clid_destroyed tracepoint
>       NFSD: Add a couple more nfsd_clid_expired call sites
>       NFSD: Rename nfsd_clid_class
>       NFSD: Add tracepoints to observe clientID activity
>
>
>  fs/nfsd/nfs4callback.c |  45 ++++----
>  fs/nfsd/nfs4proc.c     |   1 +
>  fs/nfsd/nfs4state.c    |  56 +++++++---
>  fs/nfsd/nfsfh.h        |   7 +-
>  fs/nfsd/trace.h        | 227 ++++++++++++++++++++++++++++++++++-------
>  5 files changed, 254 insertions(+), 82 deletions(-)
>
> --
> Chuck Lever
>


      parent reply	other threads:[~2021-05-10 17:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 15:51 Chuck Lever
2021-05-10 15:51 ` [PATCH RFC 01/21] NFSD: Constify @fh argument of knfsd_fh_hash() Chuck Lever
2021-05-10 15:51 ` [PATCH RFC 02/21] NFSD: Capture every CB state transition Chuck Lever
2021-05-10 15:51 ` [PATCH RFC 03/21] NFSD: Drop TRACE_DEFINE_ENUM for NFSD4_CB_<state> macros Chuck Lever
2021-05-10 15:52 ` [PATCH RFC 04/21] NFSD: Add cb_lost tracepoint Chuck Lever
2021-05-10 15:52 ` [PATCH RFC 05/21] NFSD: Adjust cb_shutdown tracepoint Chuck Lever
2021-05-10 15:52 ` [PATCH RFC 06/21] NFSD: Remove spurious cb_setup_err tracepoint Chuck Lever
2021-05-10 20:27   ` J. Bruce Fields
2021-05-10 20:29     ` Chuck Lever III
2021-05-11 17:44       ` Bruce Fields
2021-05-10 15:52 ` [PATCH RFC 07/21] NFSD: Enhance the nfsd_cb_setup tracepoint Chuck Lever
2021-05-10 15:52 ` [PATCH RFC 08/21] NFSD: Add an nfsd_cb_lm_notify tracepoint Chuck Lever
2021-05-10 15:52 ` [PATCH RFC 09/21] NFSD: Add an nfsd_cb_offload tracepoint Chuck Lever
2021-05-14 18:22   ` Olga Kornievskaia
2021-05-14 19:11     ` Chuck Lever III
2021-05-10 15:52 ` [PATCH RFC 10/21] NFSD: Replace the nfsd_deleg_break tracepoint Chuck Lever
2021-05-10 15:52 ` [PATCH RFC 11/21] NFSD: Add an nfsd_cb_probe tracepoint Chuck Lever
2021-05-10 15:52 ` [PATCH RFC 12/21] NFSD: Remove the nfsd_cb_work and nfsd_cb_done tracepoints Chuck Lever
2021-05-10 15:52 ` [PATCH RFC 13/21] NFSD: Update nfsd_cb_args tracepoint Chuck Lever
2021-05-10 15:53 ` [PATCH RFC 14/21] NFSD: Add nfsd_clid_cred_mismatch tracepoint Chuck Lever
2021-05-10 15:53 ` [PATCH RFC 15/21] NFSD: Add nfsd_clid_verf_mismatch tracepoint Chuck Lever
2021-05-11 15:49   ` J. Bruce Fields
2021-05-10 15:53 ` [PATCH RFC 16/21] NFSD: Remove nfsd_clid_inuse_err Chuck Lever
2021-05-10 15:53 ` [PATCH RFC 17/21] NFSD: Add nfsd_clid_confirmed tracepoint Chuck Lever
2021-05-10 15:53 ` [PATCH RFC 18/21] NFSD: Add nfsd_clid_destroyed tracepoint Chuck Lever
2021-05-10 15:53 ` [PATCH RFC 19/21] NFSD: Add a couple more nfsd_clid_expired call sites Chuck Lever
2021-05-10 15:53 ` [PATCH RFC 20/21] NFSD: Rename nfsd_clid_class Chuck Lever
2021-05-10 15:53 ` [PATCH RFC 21/21] NFSD: Add tracepoints to observe clientID activity Chuck Lever
2021-05-10 19:56   ` David Wysochanski
2021-05-10 20:00     ` Chuck Lever III
2021-05-11 15:59   ` Chuck Lever III
2021-05-11 17:38     ` Bruce Fields
2021-05-11 17:40       ` Chuck Lever III
2021-05-11 17:43         ` Bruce Fields
2021-05-10 17:24 ` David Wysochanski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALF+zOkyPOr+mXu+N-GKvusremTDZ53zTF_YiqFXgTRc2JC58g@mail.gmail.com \
    --to=dwysocha@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --subject='Re: [PATCH RFC 00/21] NFSD callback and lease management observability' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox