Linux-NFS Archive on lore.kernel.org
 help / Atom feed
* [GIT PULL] Please pull NFS client  bugfixes
@ 2018-12-19 16:49 Trond Myklebust
  2018-12-20  2:50 ` pr-tracker-bot
  2018-12-20 15:23 ` Geert Uytterhoeven
  0 siblings, 2 replies; 47+ messages in thread
From: Trond Myklebust @ 2018-12-19 16:49 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, linux-nfs

Hi Linus,

The following 3 patches fix a regression in the NFS/RPC TPC re-
connection code which can cause the RPC transmission to hang. The issue
was discovered by Dave Wysochanski last week.

With this pull, we still have one more regression to fix. MIPS is
seeing data corruption due to the fact that the iovec_iter code does
not appear to call flush_dcache_page() after copying data into the bvec
pages. We need guidance from Al as to how he wants this fixed.

Cheers
  Trond

The following changes since commit 7566ec393f4161572ba6f11ad5171fd5d59b0fbd:

  Linux 4.20-rc7 (2018-12-16 15:46:55 -0800)

are available in the Git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-6

for you to fetch changes up to abc13275771fac77e2d7b129c289522dacb644b6:

  SUNRPC: Remove xprt_connect_status() (2018-12-18 11:04:10 -0500)

----------------------------------------------------------------
NFS client bugfixes for Linux 4.20

Bugfixes:
- Fix TCP socket disconnection races by ensuring we always call
  xprt_disconnect_done() after releasing the socket.
- Fix a race when clearing both XPRT_CONNECTING and XPRT_LOCKED
- Remove xprt_connect_status() so it does not mask errors that should
  be handled by call_connect_status()

----------------------------------------------------------------
Trond Myklebust (3):
      SUNRPC: Fix disconnection races
      SUNRPC: Fix a race with XPRT_CONNECTING
      SUNRPC: Remove xprt_connect_status()

 net/sunrpc/clnt.c     |  1 +
 net/sunrpc/xprt.c     | 35 ++++-------------------------------
 net/sunrpc/xprtsock.c | 10 ++++------
 3 files changed, 9 insertions(+), 37 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com



^ permalink raw reply	[flat|nested] 47+ messages in thread

* Re: [GIT PULL] Please pull NFS client  bugfixes
  2018-12-19 16:49 [GIT PULL] Please pull NFS client bugfixes Trond Myklebust
@ 2018-12-20  2:50 ` pr-tracker-bot
  2018-12-20 15:23 ` Geert Uytterhoeven
  1 sibling, 0 replies; 47+ messages in thread
From: pr-tracker-bot @ 2018-12-20  2:50 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: torvalds, linux-kernel, linux-nfs

The pull request you sent on Wed, 19 Dec 2018 16:49:11 +0000:

> git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-6

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8c9dff1ebd721a3b19a002d1a901d4dc31b18ebb

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 47+ messages in thread

* Re: [GIT PULL] Please pull NFS client bugfixes
  2018-12-19 16:49 [GIT PULL] Please pull NFS client bugfixes Trond Myklebust
  2018-12-20  2:50 ` pr-tracker-bot
@ 2018-12-20 15:23 ` Geert Uytterhoeven
  1 sibling, 0 replies; 47+ messages in thread
From: Geert Uytterhoeven @ 2018-12-20 15:23 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: torvalds, linux-kernel, linux-nfs

On Wed, Dec 19, 2018 at 9:28 PM Trond Myklebust <trondmy@hammerspace.com> wrote:
> The following 3 patches fix a regression in the NFS/RPC TPC re-
> connection code which can cause the RPC transmission to hang. The issue
> was discovered by Dave Wysochanski last week.
>
> With this pull, we still have one more regression to fix. MIPS is
> seeing data corruption due to the fact that the iovec_iter code does
> not appear to call flush_dcache_page() after copying data into the bvec
> pages. We need guidance from Al as to how he wants this fixed.

FTR, the report for that issue is
https://lore.kernel.org/lkml/CAMuHMdVJr0PwvJg3FeTCy7vxuyY1=S1tPLHO7hPsoZX4wZ+-cQ@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2018-03-12 17:29 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2018-03-12 17:29 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, linux-nfs

SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgMWI4OGFjY2Y2
YTY1OWM0NmQ1YzhlNjg5MTI4OTZmMTEyYmY4ODJiYjoNCg0KICBNZXJnZSB0YWcgJ2Zvcl9saW51
cycgb2YgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L21zdC92
aG9zdCAoMjAxOC0wMy0wNyAxNzo0OTozMyAtMDgwMCkNCg0KYXJlIGF2YWlsYWJsZSBpbiB0aGUg
R2l0IHJlcG9zaXRvcnkgYXQ6DQoNCiAgZ2l0Oi8vZ2l0LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMv
dHJvbmRteS9saW51eC1uZnMuZ2l0IHRhZ3MvbmZzLWZvci00LjE2LTQNCg0KZm9yIHlvdSB0byBm
ZXRjaCBjaGFuZ2VzIHVwIHRvIGM0ZjI0ZGY5NDJhMTgxNjk5YzViYWIwMWI4ZTVlODJiOTI1Zjc3
ZjM6DQoNCiAgTkZTOiBGaXggdW5zdGFibGUgd3JpdGUgY29tcGxldGlvbiAoMjAxOC0wMy0wOCAx
Mjo1NjozMiAtMDUwMCkNCg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KTkZTIGNsaWVudCBidWdmaXhlcyBmb3IgTGludXgg
NC4xNg0KDQpIaWdodGxpZ2h0cyBpbmNsdWRlIHRoZSBmb2xsb3dpbmcgc3RhYmxlIGZpeGVzOg0K
DQotIE5GUzogRml4IGFuIGluY29ycmVjdCB0eXBlIGluIHN0cnVjdCBuZnNfZGlyZWN0X3JlcQ0K
LSBwTkZTOiBQcmV2ZW50IHRoZSBsYXlvdXQgaGVhZGVyIHJlZmNvdW50IGdvaW5nIHRvIHplcm8g
aW4gcG5mc19yb2MoKQ0KLSBORlM6IEZpeCB1bnN0YWJsZSB3cml0ZSBjb21wbGV0aW9uDQoNCi0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0NClRyb25kIE15a2xlYnVzdCAoMyk6DQogICAgICBORlM6IEZpeCBhbiBpbmNvcnJlY3Qg
dHlwZSBpbiBzdHJ1Y3QgbmZzX2RpcmVjdF9yZXENCiAgICAgIHBORlM6IFByZXZlbnQgdGhlIGxh
eW91dCBoZWFkZXIgcmVmY291bnQgZ29pbmcgdG8gemVybyBpbiBwbmZzX3JvYygpDQogICAgICBO
RlM6IEZpeCB1bnN0YWJsZSB3cml0ZSBjb21wbGV0aW9uDQoNCiBmcy9uZnMvZGlyZWN0LmMgfCAg
MiArLQ0KIGZzL25mcy9wbmZzLmMgICB8IDEzICsrKysrKy0tLQ0KIGZzL25mcy93cml0ZS5jICB8
IDgzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLQ0KIDMgZmlsZXMgY2hhbmdlZCwgNTQgaW5zZXJ0aW9ucygrKSwgNDQgZGVsZXRpb25zKC0p
DQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFBy
aW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo=


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2018-02-25 17:02 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2018-02-25 17:02 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, linux-nfs

SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgYWYzZTc5ZDI5
NTU1Yjk3ZGQwOTZlMmY4ZTM2YTBmNTAyMTM4MDhhODoNCg0KICBNZXJnZSB0YWcgJ2xlZHNfZm9y
LTQuMTYtcmMzJyBvZiBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9n
aXQvai5hbmFzemV3c2tpL2xpbnV4LWxlZHMgKDIwMTgtMDItMjAgMTA6MDU6MDIgLTA4MDApDQoN
CmFyZSBhdmFpbGFibGUgaW4gdGhlIEdpdCByZXBvc2l0b3J5IGF0Og0KDQogIGdpdDovL2dpdC5s
aW51eC1uZnMub3JnL3Byb2plY3RzL3Ryb25kbXkvbGludXgtbmZzLmdpdCB0YWdzL25mcy1mb3It
NC4xNi0zDQoNCmZvciB5b3UgdG8gZmV0Y2ggY2hhbmdlcyB1cCB0byAxYjcyMDQwNjQ1ODI3OTJi
NzdjNmJlNzk2ZTc4YmQ4MjFjOWY3MWIxOg0KDQogIE5GUzogbWFrZSBzdHJ1Y3QgbmxtY2xudF9m
bF9jbG9zZV9sb2NrX29wcyBzdGF0aWMgKDIwMTgtMDItMjIgMTI6MjM6MDEgLTA1MDApDQoNCi0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0NCk5GUyBjbGllbnQgYnVnZml4ZXMgZm9yIExpbnV4IDQuMTYNCg0KSGlnaHRsaWdodHMg
aW5jbHVkZToNCi0gRml4IGEgYnJva2VuIGNhc3QgaW4gbmZzNF9jYWxsYmFja19yZWNhbGxhbnko
KQ0KLSBGaXggYW4gT29wcyBkdXJpbmcgTkZTdjQgbWlncmF0aW9uIGV2ZW50cw0KLSBtYWtlIHN0
cnVjdCBubG1jbG50X2ZsX2Nsb3NlX2xvY2tfb3BzIHN0YXRpYw0KDQotLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpCaWxsLkJh
a2VyQG9yYWNsZS5jb20gKDEpOg0KICAgICAgbmZzOiBzeXN0ZW0gY3Jhc2hlcyBhZnRlciBORlM0
RVJSX01PVkVEIHJlY292ZXJ5DQoNCkNvbGluIElhbiBLaW5nICgxKToNCiAgICAgIE5GUzogbWFr
ZSBzdHJ1Y3QgbmxtY2xudF9mbF9jbG9zZV9sb2NrX29wcyBzdGF0aWMNCg0KVHJvbmQgTXlrbGVi
dXN0ICgxKToNCiAgICAgIE5GU3Y0OiBGaXggYnJva2VuIGNhc3QgaW4gbmZzNF9jYWxsYmFja19y
ZWNhbGxhbnkoKQ0KDQogZnMvbmZzL2NhbGxiYWNrX3Byb2MuYyB8IDE0ICsrKysrKy0tLS0tLS0t
DQogZnMvbmZzL25mczNwcm9jLmMgICAgICB8ICAyICstDQogZnMvbmZzL25mczRjbGllbnQuYyAg
ICB8ICA2ICsrKystLQ0KIDMgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMTEgZGVs
ZXRpb25zKC0pDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFp
bmVyLCBQcmltYXJ5RGF0YQ0KdHJvbmQubXlrbGVidXN0QHByaW1hcnlkYXRhLmNvbQ0K


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2017-01-28 17:04 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2017-01-28 17:04 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, linux-nfs

SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgN2EzMDhiYjMw
MTZmNTdlNWJlMTFhNjc3ZDE1YjgyMTUzNjQxOWQzNjoNCg0KICBMaW51eCA0LjEwLXJjNSAoMjAx
Ny0wMS0yMiAxMjo1NDoxNSAtMDgwMCkNCg0KYXJlIGF2YWlsYWJsZSBpbiB0aGUgZ2l0IHJlcG9z
aXRvcnkgYXQ6DQoNCiAgZ2l0Oi8vZ2l0LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9s
aW51eC1uZnMuZ2l0IHRhZ3MvbmZzLWZvci00LjEwLTQNCg0KZm9yIHlvdSB0byBmZXRjaCBjaGFu
Z2VzIHVwIHRvIGVlNjYyNWE5NDhkMmU0NzI2N2VjOGZkOTczMDdmZGQ2N2QwZjhhNWI6DQoNCiAg
cE5GUzogRml4IGEgcmVmZXJlbmNlIGxlYWsgaW4gX3BuZnNfcmV0dXJuX2xheW91dCAoMjAxNy0w
MS0yNiAxNTo1MDo0MSAtMDUwMCkNCg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KTkZTIGNsaWVudCBidWdmaXhlcyBmb3Ig
TGludXggNC4xMA0KDQpTdGFibGUgcGF0Y2hlczoNCi0gTkZTdjQuMTogRml4IGEgZGVhZGxvY2sg
aW4gbGF5b3V0Z2V0DQotIE5GU3Y0IG11c3Qgbm90IGJ1bXAgc2VxdWVuY2UgaWRzIG9uIE5GUzRF
UlJfTU9WRUQgZXJyb3JzDQotIE5GU3Y0IEZpeCBhIHJlZ3Jlc3Npb24gd2l0aCBPUEVOIEVYQ0xV
U0lWRTQgbW9kZQ0KLSBGaXggYSBtZW1vcnkgbGVhayB3aGVuIHJlbW92aW5nIHRoZSBTVU5SUEMg
bW9kdWxlDQoNCkJ1Z2ZpeGVzOg0KLSBGaXggYSByZWZlcmVuY2UgbGVhayBpbiBfcG5mc19yZXR1
cm5fbGF5b3V0DQoNCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0NCkJlbmphbWluIENvZGRpbmd0b24gKDEpOg0KICAgICAgTkZT
djQuMDogYWx3YXlzIHNlbmQgbW9kZSBpbiBTRVRBVFRSIGFmdGVyIEVYQ0xVU0lWRTQNCg0KQ2h1
Y2sgTGV2ZXIgKDIpOg0KICAgICAgbmZzOiBEb24ndCBpbmNyZW1lbnQgbG9jayBzZXF1ZW5jZSBJ
RCBhZnRlciBORlM0RVJSX01PVkVEDQogICAgICBuZnM6IEZpeCAiRG9uJ3QgaW5jcmVtZW50IGxv
Y2sgc2VxdWVuY2UgSUQgYWZ0ZXIgTkZTNEVSUl9NT1ZFRCINCg0KS2luZ2xvbmcgTWVlICgxKToN
CiAgICAgIFNVTlJQQzogY2xlYW51cCBpZGEgaW5mb3JtYXRpb24gd2hlbiByZW1vdmluZyBzdW5y
cGMgbW9kdWxlDQoNClRyb25kIE15a2xlYnVzdCAoMik6DQogICAgICBORlN2NC4xOiBGaXggYSBk
ZWFkbG9jayBpbiBsYXlvdXRnZXQNCiAgICAgIHBORlM6IEZpeCBhIHJlZmVyZW5jZSBsZWFrIGlu
IF9wbmZzX3JldHVybl9sYXlvdXQNCg0KIGZzL25mcy9uZnM0cHJvYy5jICAgICAgICAgICB8IDQg
KysrLQ0KIGZzL25mcy9uZnM0c3RhdGUuYyAgICAgICAgICB8IDEgKw0KIGZzL25mcy9wbmZzLmMg
ICAgICAgICAgICAgICB8IDIgKy0NCiBpbmNsdWRlL2xpbnV4L25mczQuaCAgICAgICAgfCAzICsr
LQ0KIGluY2x1ZGUvbGludXgvc3VucnBjL2NsbnQuaCB8IDEgKw0KIG5ldC9zdW5ycGMvY2xudC5j
ICAgICAgICAgICB8IDUgKysrKysNCiBuZXQvc3VucnBjL3N1bnJwY19zeW1zLmMgICAgfCAxICsN
CiA3IGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQotLSAN
ClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyLCBQcmltYXJ5RGF0
YQ0KdHJvbmQubXlrbGVidXN0QHByaW1hcnlkYXRhLmNvbQ0K


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2017-01-16 20:14 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2017-01-16 20:14 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, linux-nfs

SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgYTEyMTEwM2M5
MjI4NDdiYTUwMTA4MTlhM2YyNTBmMWY3ZmM4NGFiODoNCg0KICBMaW51eCA0LjEwLXJjMyAoMjAx
Ny0wMS0wOCAxNDoxODoxNyAtMDgwMCkNCg0KYXJlIGF2YWlsYWJsZSBpbiB0aGUgZ2l0IHJlcG9z
aXRvcnkgYXQ6DQoNCiAgZ2l0Oi8vZ2l0LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9s
aW51eC1uZnMuZ2l0IHRhZ3MvbmZzLWZvci00LjEwLTMNCg0KZm9yIHlvdSB0byBmZXRjaCBjaGFu
Z2VzIHVwIHRvIGM2MTgwYTYyMzcxNzRmNDgxZGM4NTZlZDZlODkwZDgxOTZiNmYwZmI6DQoNCiAg
TkZTdjQ6IEZpeCBjbGllbnQgcmVjb3Zlcnkgd2hlbiBzZXJ2ZXIgcmVib290cyBtdWx0aXBsZSB0
aW1lcyAoMjAxNy0wMS0xMyAxMzozMTozMiAtMDUwMCkNCg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KTkZTIGNsaWVudCBi
dWdmaXhlcyBmb3IgTGludXggNC4xMA0KDQpCdWdmaXhlczoNCi0gRml4IGludmFsaWQgZmdldCgp
L2ZwdXQoKSBjYWxscyB3aGVuIGRvaW5nIGZpbGUgbG9ja2luZw0KLSBGaXggbXVsdGlwbGUgZGly
ZWN0b3J5IGNhY2hlIGludmFsaWRhdGlvbiBpc3N1ZXMgZHVlIHRvIHRoZSBjbGllbnQgZmFpbGlu
Zw0KICB0byByZWNvZ25pc2UgdGhhdCB0aGUgZGlyZWN0b3J5IHdhc24ndCBjaGFuZ2VkLg0KLSBG
aXggY2xpZW50IHJlY292ZXJ5IHdoZW4gc2VydmVyIHJlYm9vdHMgbXVsdGlwbGUgdGltZXMNCg0K
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLQ0KQmVuamFtaW4gQ29kZGluZ3RvbiAoMSk6DQogICAgICBuZnM6IERvbid0IHRha2Ug
YSByZWZlcmVuY2Ugb24gZmwtPmZsX2ZpbGUgZm9yIExPQ0sgb3BlcmF0aW9uDQoNClRyb25kIE15
a2xlYnVzdCAoNSk6DQogICAgICBORlN2NDogQ2FsbCB1cGRhdGVfY2hhbmdlYXR0cigpIGZyb20g
X25mczRfcHJvY19vcGVuIG9ubHkgaWYgYSBmaWxlIHdhcyBjcmVhdGVkDQogICAgICBORlN2NDog
RG9uJ3QgYXBwbHkgY2hhbmdlX2luZm80IHR3aWNlIG9uIHJlbmFtZSB3aXRoaW4gYSBkaXJlY3Rv
cnkNCiAgICAgIE5GU3Y0OiBEb24ndCBjYWxsIHVwZGF0ZV9jaGFuZ2VhdHRyKCkgdW5sZXNzIHRo
ZSB1bmxpbmsgaXMgc3VjY2Vzc2Z1bA0KICAgICAgTkZTdjQ6IHVwZGF0ZV9jaGFuZ2VhdHRyIHNo
b3VsZCB1cGRhdGUgdGhlIGF0dHJpYnV0ZSB0aW1lc3RhbXANCiAgICAgIE5GU3Y0OiBGaXggY2xp
ZW50IHJlY292ZXJ5IHdoZW4gc2VydmVyIHJlYm9vdHMgbXVsdGlwbGUgdGltZXMNCg0KIGZzL25m
cy9uZnM0cHJvYy5jICB8IDI5ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tDQogZnMvbmZz
L25mczRzdGF0ZS5jIHwgIDEgLQ0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwg
MTIgZGVsZXRpb25zKC0pDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50
IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29t
DQo=


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2016-10-21 20:30 Anna Schumaker
  0 siblings, 0 replies; 47+ messages in thread
From: Anna Schumaker @ 2016-10-21 20:30 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Trond Myklebust, linux-nfs, linux-kernel

Hi Linus,

The following changes since commit 3f807e5ae5597bd65a6fff684083e8eaa21f3fa7:

  NFSv4.2: Fix a reference leak in nfs42_proc_layoutstats_generic (2016-10-04 16:30:54 -0400)

are available in the git repository at:

  git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.9-2

for you to fetch changes up to 83aa3e0f791d458a28f91d7a50f92926f971ef7c:

  nfs4: fix missing-braces warning (2016-10-19 14:39:15 -0400)

----------------------------------------------------------------
Just two bugfixes this time:

Stable bugfix:
- Fix last_write_offset incorrectly set to page boundary

Other bugfix:
- Fix missing-braces warning

Thanks,
Anna
----------------------------------------------------------------
Arnd Bergmann (1):
      nfs4: fix missing-braces warning

Benjamin Coddington (1):
      pnfs/blocklayout: fix last_write_offset incorrectly set to page boundary

 fs/nfs/blocklayout/blocklayout.c | 3 ++-
 fs/nfs/nfs4proc.c                | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2015-10-07  2:52 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2015-10-07  2:52 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, linux-nfs

Hi Linus,

The following changes since commit 5634347dee31373a8faf084f4cdbf6d5ea0b03a4:

  Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux (2015-10-02 14:54:16 -0400)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.3-3

for you to fetch changes up to 39d0d3bdf7bab3021a31e501172ac0f18947f9b3:

  NFS: Fix a tracepoint NULL-pointer dereference (2015-10-06 18:56:25 -0400)

Cheers
  Trond

----------------------------------------------------------------
NFS client bugfixes for Linux 4.3

Highlights include:

Bugfixes:
- Fix a use-after-free bug in the RPC/RDMA client
- Fix a write performance regression
- Fix up page writeback accounting
- Don't try to reclaim unused state owners
- Fix a NFSv4 nograce recovery hang
- reset states to use open_stateid when returning delegation voluntarily
- Fix a tracepoint NULL-pointer dereference

----------------------------------------------------------------
Anna Schumaker (1):
      NFS: Fix a tracepoint NULL-pointer dereference

Benjamin Coddington (1):
      NFSv4: Fix a nograce recovery hang

Jeff Layton (1):
      nfs4: reset states to use open_stateid when returning delegation voluntarily

Steve Wise (1):
      xprtrdma: disconnect and flush cqs before freeing buffers

Trond Myklebust (5):
      NFS: Fix up page writeback accounting
      NFS: Fix a write performance regression
      NFSv4: Don't try to reclaim unused state owners
      NFSv4.1: nfs4_opendata_check_deleg needs to handle NFS4_OPEN_CLAIM_DELEG_CUR_FH
      Merge tag 'nfs-rdma-for-4.3-2' of git://git.linux-nfs.org/projects/anna/nfs-rdma

 fs/nfs/nfs4proc.c               | 15 +++++++++++++--
 fs/nfs/nfs4state.c              |  3 ++-
 fs/nfs/nfs4trace.h              |  2 +-
 fs/nfs/write.c                  | 14 +++++++-------
 net/sunrpc/xprtrdma/transport.c |  2 +-
 net/sunrpc/xprtrdma/verbs.c     |  9 ++++++---
 6 files changed, 30 insertions(+), 15 deletions(-)
-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com




^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2015-09-25 15:14 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2015-09-25 15:14 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS Mailing List, Linux Kernel Mailing List

Hi Linus,

The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

  Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.3-2

for you to fetch changes up to 500d701f336b2771d34e46da7875a4782515a652:

  NFS41: make close wait for layoutreturn (2015-09-23 08:55:32 -0400)

Cheers
  Trond

----------------------------------------------------------------
NFS client bugfixes for Linux 4.3

Highlights include:

Stable patches:
- fix v4.2 SEEK on files over 2 gigs
- Fix a layout segment reference leak when pNFS I/O falls back to inband I/O.
- Fix recovery of recalled read delegations

Bugfixes:
- Fix a case where NFSv4 fails to send CLOSE after a server reboot
- Fix sunrpc to wait for connections to complete before retrying
- Fix sunrpc races between transport connect/disconnect and shutdown
- Fix an infinite loop when layoutget fail with BAD_STATEID
- nfs/filelayout: Fix NULL reference caused by double freeing of fh_array
- Fix a bogus WARN_ON_ONCE() in O_DIRECT when layout commit_through_mds is set
- Fix layoutreturn/close ordering issues.

----------------------------------------------------------------
J. Bruce Fields (1):
      nfs: fix v4.2 SEEK on files over 2 gigs

Julia Lawall (1):
      SUNRPC: drop null test before destroy functions

Kinglong Mee (4):
      nfs/filelayout: Fix NULL reference caused by double freeing of fh_array
      NFS: Do cleanup before resetting pageio read/write to mds
      NFS: Fix an infinite loop when layoutget fail with BAD_STATEID
      NFS: Skip checking ds_cinfo.buckets when lseg's commit_through_mds is set

Olga Kornievskaia (1):
      Failing to send a CLOSE if file is opened WRONLY and server reboots on a 4.x mount

Peng Tao (2):
      nfs: fix pg_test page count calculation
      NFS41: make close wait for layoutreturn

Trond Myklebust (6):
      SUNRPC: Fix races between socket connection and destroy code
      SUNRPC: Ensure that we wait for connections to complete before retrying
      SUNRPC: Lock the transport layer on shutdown
      SUNRPC: xs_sock_mark_closed() does not need to trigger socket autoclose
      NFSv4: Recovery of recalled read delegations is broken
      NFSv4.x/pnfs: Don't try to recover stateids twice in layoutget

 fs/nfs/delegation.c             |   8 ++-
 fs/nfs/delegation.h             |   2 +-
 fs/nfs/direct.c                 |   7 ++-
 fs/nfs/filelayout/filelayout.c  |  31 ++++------
 fs/nfs/nfs42proc.c              |   4 +-
 fs/nfs/nfs4proc.c               | 127 ++++++++++++++++++++++++++--------------
 fs/nfs/nfs4state.c              |   2 +-
 fs/nfs/pagelist.c               |   2 +-
 fs/nfs/pnfs.c                   |  35 +++++++----
 fs/nfs/pnfs.h                   |   7 +++
 fs/nfs/read.c                   |   3 +
 fs/nfs/write.c                  |   3 +
 include/linux/sunrpc/xprtsock.h |   3 +
 net/sunrpc/sched.c              |  12 ++--
 net/sunrpc/xprt.c               |   6 ++
 net/sunrpc/xprtsock.c           |  15 +++--
 16 files changed, 172 insertions(+), 95 deletions(-)
-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com




^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2015-07-28 16:03 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2015-07-28 16:03 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, linux-nfs

Hi Linus,

The following changes since commit b4839ebe21fc5d543b933d83644981ea73e9ba36:

  nfs: Remove invalid tk_pid from debug message (2015-07-01 11:31:25 -0400)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.2-2

for you to fetch changes up to a49c269111a5b3c1fd2a98f36fa27423b94549f8:

  nfs: Fix an oops caused by using other thread's stack space in ASYNC mode (2015-07-28 09:07:03 -0400)

----------------------------------------------------------------
NFS client bugfixes for Linux 4.2

Highlights include:

Stable patches:
- Fix a situation where the client uses the wrong (zero) stateid.
- Fix a memory leak in nfs_do_recoalesce

Bugfixes:
- Plug a memory leak when ->prepare_layoutcommit fails
- Fix an Oops in the NFSv4 open code
- Fix a backchannel deadlock
- Fix a livelock in sunrpc when sendmsg fails due to low memory availability
- Don't revalidate the mapping if both size and change attr are up to date
- Ensure we don't miss a file extension when doing pNFS
- Several fixes to handle NFSv4.1 sequence operation status bits correctly
- Several pNFS layout return bugfixes

----------------------------------------------------------------
J. Bruce Fields (1):
      NFSv4.2: handle NFS-specific llseek errors

Jeff Layton (1):
      nfs: plug memory leak when ->prepare_layoutcommit fails

Kinglong Mee (1):
      nfs: Fix an oops caused by using other thread's stack space in ASYNC mode

NeilBrown (1):
      sunrpc: translate -EAGAIN to -ENOBUFS when socket is writable.

Trond Myklebust (24):
      SUNRPC: Don't reencode message if transmission failed with ENOBUFS
      SUNRPC: Don't confuse ENOBUFS with a write_space issue
      NFSv4.1: Handle SEQ4_STATUS_EXPIRED_SOME_STATE_REVOKED status bit correctly.
      NFSv4.1: Handle SEQ4_STATUS_RECALLABLE_STATE_REVOKED status bit correctly
      NFSv4.1: Handle SEQ4_STATUS_BACKCHANNEL_FAULT correctly
      NFSv4.1: nfs41_sequence_done should handle sequence flag errors
      NFSv4: Leases are renewed in sequence_done when we have sessions
      NFSv4.2/flexfiles: Fix a typo in the flexfiles layoutstats code
      pNFS: Layoutreturn must invalidate all existing layout segments.
      pNFS: pnfs_roc_drain should return 'true' when sleeping
      pNFS: Fix races between return-on-close and layoutreturn.
      pNFS: pnfs_roc_drain() fix a race with open
      pNFS: Don't throw out valid layout segments
      SUNRPC: Fix a backchannel deadlock
      SUNRPC: xprt_complete_bc_request must also decrement the free slot count
      NFSv4: We must set NFS_OPEN_STATE flag in nfs_resync_open_stateid_locked
      NFSv4/pnfs: Ensure we don't miss a file extension
      NFS: Don't revalidate the mapping if both size and change attr are up to date
      NFS: Set NFS_INO_REVAL_PAGECACHE if the change attribute is uninitialised
      NFS: Remove the "NFS_CAP_CHANGE_ATTR" capability
      NFS: nfs_mark_for_revalidate should always set NFS_INO_REVAL_PAGECACHE
      NFS: Fix a memory leak in nfs_do_recoalesce
      NFS: Don't clear desc->pg_moreio in nfs_do_recoalesce()
      SUNRPC: Report TCP errors to the caller

 fs/nfs/client.c                        |   2 +-
 fs/nfs/flexfilelayout/flexfilelayout.c |   2 +-
 fs/nfs/inode.c                         |  15 ++---
 fs/nfs/internal.h                      |  21 +++++++
 fs/nfs/nfs42proc.c                     |  19 ++++++-
 fs/nfs/nfs4proc.c                      |  36 +++++++-----
 fs/nfs/nfs4state.c                     |  29 +++++++---
 fs/nfs/pagelist.c                      |   7 ++-
 fs/nfs/pnfs.c                          | 101 +++++++++++++++++++--------------
 fs/nfs/write.c                         |  15 +++--
 include/linux/nfs_fs.h                 |   7 ++-
 include/linux/nfs_fs_sb.h              |   2 +-
 net/sunrpc/backchannel_rqst.c          |   6 +-
 net/sunrpc/clnt.c                      |   5 +-
 net/sunrpc/xprtsock.c                  |  25 +++++---
 15 files changed, 189 insertions(+), 103 deletions(-)
-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com



^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2015-03-06  3:46 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2015-03-06  3:46 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS Mailing List, Linux Kernel Mailing List

Hi Linus,

The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539:

  Linux 4.0-rc1 (2015-02-22 18:21:14 -0800)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.0-3

for you to fetch changes up to e11259f920d8cb3550e0f311c064bdabe1bc3aaf:

  NFSv4.1: Clear the old state by our client id before establishing a new lease (2015-03-03 21:52:30 -0500)

----------------------------------------------------------------
NFS client bugfixes for Linux 4.0

Highlights include:

- Fix a regression in the NFSv4 open state recovery code
- Fix a regression in the NFSv4 close code
- Fix regressions and side-effects of the loop-back mounted NFS fixes
  in 3.18, that cause the NFS read() syscall to return EBUSY.
- Fix regressions around the readdirplus code and how it interacts with
  the VFS lazy unmount changes that went into v3.18.
- Fix issues with out-of-order RPC call replies replacing updated
  attributes with stale ones (particularly after a truncate()).
- Fix an underflow checking issue with RPC/RDMA credits
- Fix a number of issues with the NFSv4 delegation return/free code.
- Fix issues around stale NFSv4.1 leases when doing a mount

----------------------------------------------------------------
Anna Schumaker (1):
      NFS: Fix stateid used for NFS v4 closes

Chuck Lever (1):
      xprtrdma: Store RDMA credits in unsigned variables

Trond Myklebust (23):
      Merge tag 'nfs-rdma-for-4.0-3' of git://git.linux-nfs.org/projects/anna/nfs-rdma
      NFSv4: nfs4_open_recover_helper() must set share access
      NFS: Ensure that buffered writes wait for O_DIRECT writes to complete
      NFS: Add a helper to set attribute barriers
      NFS: Add attribute update barriers to nfs_setattr_update_inode()
      NFS: Set an attribute barrier on all updates
      NFS: Add attribute update barriers to NFS writebacks
      NFSv4: Add attribute update barriers to delegreturn and pNFS layoutcommit
      NFS: Remove size hack in nfs_inode_attrs_need_update()
      NFS: Fix nfs_post_op_update_inode() to set an attribute barrier
      NFSv4: Set a barrier in the update_changeattr() helper
      NFS: Don't invalidate a submounted dentry in nfs_prime_dcache()
      NFSv3: Use the readdir fileid as the mounted-on-fileid
      NFS: Don't require a filehandle to refresh the inode in nfs_prime_dcache()
      NFSv4: Don't call put_rpccred() under the rcu_read_lock()
      NFSv4: Ensure that we don't reap a delegation that is being returned
      NFSv4: Ensure we honour NFS_DELEGATION_RETURNING in nfs_inode_set_delegation()
      NFSv4: Pin the superblock while we're returning the delegation
      NFSv4: Ensure we skip delegations that are already being returned
      NFS: Fix a regression in the read() syscall
      NFS: Don't write enable new pages while an invalidation is proceeding
      NFSv4: Fix a race in NFSv4.1 server trunking discovery
      NFSv4.1: Clear the old state by our client id before establishing a new lease

 fs/nfs/client.c                 |   2 +-
 fs/nfs/delegation.c             |  45 ++++++++++++----
 fs/nfs/dir.c                    |  22 ++++++--
 fs/nfs/file.c                   |  11 +++-
 fs/nfs/inode.c                  | 111 +++++++++++++++++++++++++++++++++-------
 fs/nfs/internal.h               |   1 +
 fs/nfs/nfs3proc.c               |   4 +-
 fs/nfs/nfs3xdr.c                |   5 ++
 fs/nfs/nfs4client.c             |   9 ++--
 fs/nfs/nfs4proc.c               |  31 +++++++----
 fs/nfs/nfs4session.h            |   1 +
 fs/nfs/nfs4state.c              |  18 ++++++-
 fs/nfs/proc.c                   |   6 +--
 fs/nfs/write.c                  |  30 +++++++++++
 include/linux/nfs_fs.h          |   5 +-
 net/sunrpc/xprtrdma/rpc_rdma.c  |   3 +-
 net/sunrpc/xprtrdma/xprt_rdma.h |   2 +-
 17 files changed, 244 insertions(+), 62 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com





^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2015-01-29 21:37 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2015-01-29 21:37 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS Mailing List, Linux Kernel Mailing List

Hi Linus,

The following changes since commit ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc:

  Linux 3.19-rc5 (2015-01-18 18:02:20 +1200)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.19-3

for you to fetch changes up to 2ef47eb1aee171ecf1d83311b9f7fae80f330181:

  NFS: Fix use of nfs_attr_use_mounted_on_fileid() (2015-01-21 17:15:41 -0500)

----------------------------------------------------------------
NFS client bugfixes for Linux 3.19

Highlights include:
- Stable fix for a NFSv4.1 Oops on mount
- Stable fix for an O_DIRECT deadlock condition
- Fix an issue with submounted volumes and fake duplicate inode numbers

----------------------------------------------------------------
Anna Schumaker (1):
      NFS: Fix use of nfs_attr_use_mounted_on_fileid()

Peng Tao (1):
      nfs: fix dio deadlock when O_DIRECT flag is flipped

Trond Myklebust (1):
      NFSv4.1: Fix an Oops in nfs41_walk_client_list

 fs/nfs/direct.c     | 6 ++++++
 fs/nfs/inode.c      | 5 +++--
 fs/nfs/internal.h   | 2 --
 fs/nfs/nfs4client.c | 2 +-
 4 files changed, 10 insertions(+), 5 deletions(-)



^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2015-01-16 14:35 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2015-01-16 14:35 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS Mailing List, Linux Kernel mailing list

Hi Linus,

The following changes since commit b1940cd21c0f4abdce101253e860feff547291b0:

  Linux 3.19-rc3 (2015-01-05 17:05:20 -0800)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.19-2

for you to fetch changes up to 4e379d36c050b0117b5d10048be63a44f5036115:

  NFSv4: Remove incorrect check in can_open_delegated() (2015-01-05 19:40:54 -0800)

----------------------------------------------------------------
NFS client bugfixes for Linux 3.19

Highlights include:

- Stable fix for a NFSv3/lockd race
- Fixes for several NFSv4.1 client id trunking bugs
- Remove an incorrect test when checking for delegated opens

----------------------------------------------------------------
Chuck Lever (1):
      NFS: Ignore transport protocol when detecting server trunking

Trond Myklebust (5):
      LOCKD: Fix a race when initialising nlmsvc_timeout
      NFSv4.1: Fix client id trunking on Linux
      NFSv4: Cache the NFSv4/v4.1 client owner_id in the struct nfs_client
      NFSv4/v4.1: Verify the client owner id during trunking detection
      NFSv4: Remove incorrect check in can_open_delegated()

 fs/lockd/svc.c            |  8 ++++----
 fs/nfs/nfs4client.c       | 42 +++++++++++++++++++++++++++---------------
 fs/nfs/nfs4proc.c         | 21 +++++++++++++++------
 include/linux/nfs_fs_sb.h |  3 +++
 4 files changed, 49 insertions(+), 25 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com





^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2014-11-14 23:04 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2014-11-14 23:04 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-nfs, linux-kernel

Hi Linus,

The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4:

  Linux 3.18-rc3 (2014-11-02 15:01:51 -0800)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.18-3

for you to fetch changes up to b3ecba096729f521312d1863ad22530695527aed:

  sunrpc: fix sleeping under rcu_read_lock in gss_stringify_acceptor (2014-11-13 13:15:49 -0500)

----------------------------------------------------------------
NFS client bugfixes for Linux 3.18

Highlights include:

- Stable patches to fix NFSv4.x delegation reclaim error paths
- Fix a bug whereby we were advertising NFSv4.1 but using NFSv4.2 features
- Fix a use-after-free problem with pNFS block layouts
- Fix a memory leak in the pNFS files O_DIRECT code
- Replace an intrusive and Oops-prone performance fix in the NFSv4 atomic
  open code with a safer one-line version and revert the two original patches.

----------------------------------------------------------------
Anna Schumaker (1):
      NFS: SEEK is an NFS v4.2 feature

Christoph Hellwig (1):
      pnfs/blocklayout: serialize GETDEVICEINFO calls

Jan Kara (2):
      nfs: Remove bogus assignment
      nfs: Fix use of uninitialized variable in nfs_getattr()

Jeff Layton (1):
      sunrpc: fix sleeping under rcu_read_lock in gss_stringify_acceptor

Peng Tao (1):
      nfs: fix pnfs direct write memory leak

Trond Myklebust (8):
      NFSv4: Ensure nfs_atomic_open set the dentry verifier on ENOENT
      Revert "NFS: remove BUG possibility in nfs4_open_and_get_state"
      Revert "NFS: nfs4_do_open should add negative results to the dcache."
      NFSv4: Ensure that we remove NFSv4.0 delegations when state has expired
      NFSv4.1: nfs41_clear_delegation_stateid shouldn't trust NFS_DELEGATED_STATE
      NFSv4: Fix races between nfs_remove_bad_delegation() and delegation return
      NFSv4: Ensure that we call FREE_STATEID when NFSv4.x stateids are revoked
      NFS: Don't try to reclaim delegation open state if recovery failed

Weston Andros Adamson (1):
      nfs: remove spurious WARN_ON_ONCE in write path

 fs/nfs/blocklayout/blocklayout.c |  2 +-
 fs/nfs/blocklayout/rpc_pipefs.c  | 14 +++---
 fs/nfs/delegation.c              | 25 ++++++++++-
 fs/nfs/delegation.h              |  1 +
 fs/nfs/dir.c                     |  1 +
 fs/nfs/direct.c                  |  1 +
 fs/nfs/filelayout/filelayout.c   |  3 --
 fs/nfs/inode.c                   |  2 +-
 fs/nfs/netns.h                   |  1 +
 fs/nfs/nfs4proc.c                | 95 +++++++++++++++++++---------------------
 fs/nfs/write.c                   |  2 -
 include/linux/nfs_xdr.h          | 11 +++++
 net/sunrpc/auth_gss/auth_gss.c   | 35 ++++++++++++---
 13 files changed, 124 insertions(+), 69 deletions(-)



^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2014-09-19 19:32 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2014-09-19 19:32 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS Mailing List, Linux Kernel mailing list

Hi Linus,

The following changes since commit 224ecbf5a674ec7da3a3b3ea21ca62e2853653fa:

  pnfs: fix filelayout_retry_commit when idx > 0 (2014-09-10 12:43:45 -0700)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.17-5

for you to fetch changes up to cd9288ffaea4359d5cfe2b8d264911506aed26a4:

  NFSv4: Fix another bug in the close/open_downgrade code (2014-09-18 13:04:22 -0400)

----------------------------------------------------------------
NFS client fixes for 3.17

Highligts:
- Fix an Oops in nfs4_open_and_get_state
- Fix an Oops in the nfs4_state_manager
- Fix another bug in the close/open_downgrade code

----------------------------------------------------------------
NeilBrown (1):
      NFS: remove BUG possibility in nfs4_open_and_get_state

Steve Dickson (1):
      NFSv4: nfs4_state_manager() vs. nfs_server_remove_lists()

Trond Myklebust (1):
      NFSv4: Fix another bug in the close/open_downgrade code

 fs/nfs/nfs4client.c | 38 ++++++++++++++++++++------------------
 fs/nfs/nfs4proc.c   | 40 ++++++++++++++++++++++------------------
 2 files changed, 42 insertions(+), 36 deletions(-)



^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2014-01-31 21:41 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2014-01-31 21:41 UTC (permalink / raw)
  To: Torvalds Linus; +Cc: Linux NFS Mailing List, Linux Kernel mailing list

[-- Attachment #1: Type: text/plain, Size: 2360 bytes --]

Hi Linus,

The following changes since commit ed7e5423014ad89720fcf315c0b73f2c5d0c7bd2:

  pnfs: Proper delay for NFS4ERR_RECALLCONFLICT in layout_get_done (2014-01-22 18:10:49 -0700)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.14-2

for you to fetch changes up to a1800acaf7d1c2bf6d68b9a8f4ab8560cc66555a:

  nfs: initialize the ACL support bits to zero. (2014-01-31 08:28:16 -0500)

Please note that this pull excludes the fixes for the NFSv3 posix acl
regressions, since at least one of those patches will need an ack from
Al and/or Christoph.

Cheers
  Trond

----------------------------------------------------------------
NFS client bugfixes for Linux 3.14

Highlights:

- Fix several races in nfs_revalidate_mapping
- NFSv4.1 slot leakage in the pNFS files driver
- Stable fix for a slot leak in nfs40_sequence_done
- Don't reject NFSv4 servers that support ACLs with only ALLOW aces

----------------------------------------------------------------
Andy Adamson (1):
      NFSv4.1 free slot before resending I/O to MDS

Jeff Layton (3):
      NFS: fix the handling of NFS_INO_INVALID_DATA flag in nfs_revalidate_mapping
      sunrpc: turn warn_gssd() log message into a dprintk()
      nfs: add memory barriers around NFS_INO_INVALID_DATA and NFS_INO_INVALIDATING

Malahal Naineni (2):
      nfs: handle servers that support only ALLOW ACE type.
      nfs: initialize the ACL support bits to zero.

Trond Myklebust (4):
      NFS: Fix races in nfs_revalidate_mapping
      NFSv4: Fix a slot leak in nfs40_sequence_done
      NFSv4.1: Clean up nfs41_sequence_done
      NFSv4.1: Cleanup

 fs/nfs/dir.c                   | 13 +++++++++--
 fs/nfs/inode.c                 | 51 +++++++++++++++++++++++++++++++++++-------
 fs/nfs/nfs4_fs.h               |  1 +
 fs/nfs/nfs4client.c            |  5 +----
 fs/nfs/nfs4filelayout.c        |  8 +++++--
 fs/nfs/nfs4proc.c              | 31 ++++++++++++-------------
 fs/nfs/nfs4xdr.c               |  2 +-
 fs/nfs/nfstrace.h              |  1 +
 fs/nfs/write.c                 |  7 +++++-
 include/linux/nfs_fs.h         |  1 +
 net/sunrpc/auth_gss/auth_gss.c |  8 +------
 11 files changed, 86 insertions(+), 42 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2013-12-05 17:20 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2013-12-05 17:20 UTC (permalink / raw)
  To: Torvalds Linus; +Cc: Linux NFS Mailing List, Linux Kernel mailing list

[-- Attachment #1: Type: text/plain, Size: 2279 bytes --]

Hi Linus,

The following changes since commit 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13:

  nfs: fix pnfs Kconfig defaults (2013-11-15 13:41:43 -0500)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.13-3

for you to fetch changes up to 3873d064b8538686bbbd4b858dc8a07db1f7f43a:

  nfs: fix do_div() warning by instead using sector_div() (2013-12-04 12:57:37 -0500)

----------------------------------------------------------------
NFS client bugfixes

- Stable fix for a NFSv4.1 delegation and state recovery deadlock
- Stable fix for a loop on irrecoverable errors when returning delegations
- Fix a 3-way deadlock between layoutreturn, open, and state recovery
- Update the MAINTAINERS file with contact information for Trond Myklebust
- Close needs to handle NFS4ERR_ADMIN_REVOKED
- Enabling v4.2 should not recompile nfsd and lockd
- Fix a couple of compile warnings

----------------------------------------------------------------
Andy Adamson (2):
      NFSv4 wait on recovery for async session errors
      SUNRPC: do not fail gss proc NULL calls with EACCES

Anna Schumaker (1):
      NFS: Enabling v4.2 should not recompile nfsd and lockd

Helge Deller (1):
      nfs: fix do_div() warning by instead using sector_div()

Trond Myklebust (5):
      NFS: Fix a warning in nfs_setsecurity
      NFSv4: Update list of irrecoverable errors on DELEGRETURN
      NFSv4: close needs to handle NFS4ERR_ADMIN_REVOKED
      NFSv4.1: Prevent a 3-way deadlock between layoutreturn, open and state recovery
      MAINTAINERS: Update contact information for Trond Myklebust

 MAINTAINERS                      |  4 ++--
 fs/nfs/blocklayout/blocklayout.h |  1 +
 fs/nfs/blocklayout/extents.c     |  2 +-
 fs/nfs/dns_resolve.c             |  2 ++
 fs/nfs/inode.c                   |  2 +-
 fs/nfs/internal.h                | 15 +++++++++++++++
 fs/nfs/nfs4_fs.h                 |  8 ++++++++
 fs/nfs/nfs4proc.c                | 30 +++++++++++++++++++++++-------
 include/linux/nfs4.h             | 10 ----------
 include/linux/nfs_fs.h           | 18 ------------------
 net/sunrpc/auth_gss/auth_gss.c   |  2 +-
 11 files changed, 54 insertions(+), 40 deletions(-)


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2013-11-16 21:09 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2013-11-16 21:09 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1851 bytes --]

Hi Linus

The following changes since commit fab99ebe39fe7d11fbd9b5fb84f07432af9ba36f:

  NFSv4.2: Remove redundant checks in nfs+AF8-setsecurity+-nfs4+AF8-label+AF8-init+AF8-security (2013-11-04 16:42:52 -0500)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.13-2

for you to fetch changes up to 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13:

  nfs: fix pnfs Kconfig defaults (2013-11-15 13:41:43 -0500)

----------------------------------------------------------------
NFS client bugfixes:

- Stable fix for data corruption when retransmitting O+AF8-DIRECT writes
- Stable fix for a deep recursion/stack overflow bug in rpc+AF8-release+AF8-client
- Stable fix for infinite looping when mounting a NFSv4.x volume
- Fix a typo in the nfs mount option parser
- Allow pNFS layouts to be compiled into the kernel when NFSv4.1 is

----------------------------------------------------------------
Christoph Hellwig (1):
      nfs: fix pnfs Kconfig defaults

Jeff Layton (1):
      nfs: don't retry detect+AF8-trunking with RPC+AF8-AUTH+AF8-UNIX more than once

NeilBrown (1):
      NFS: correctly report misuse of +ACI-migration+ACI mount option.

Trond Myklebust (2):
      SUNRPC: Fix a data corruption issue when retransmitting RPC calls
      SUNRPC: Avoid deep recursion in rpc+AF8-release+AF8-client

 fs/nfs/Kconfig        +AHw  6 +-+-+----
 fs/nfs/nfs4state.c    +AHw  7 +-+-+-+-+-+--
 fs/nfs/super.c        +AHw  2 +--
 net/sunrpc/clnt.c     +AHw 29 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-------------
 net/sunrpc/xprtsock.c +AHw 28 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+--------
 5 files changed, 48 insertions(+-), 24 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust+AEA-netapp.com
www.netapp.com

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2013-09-30 22:02 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2013-09-30 22:02 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list

DQpIaSBMaW51cywNCg0KVGhlIGZvbGxvd2luZyBjaGFuZ2VzIHNpbmNlIGNvbW1pdCA0YTEwYzJh
YzJmMzY4NTgzMTM4Yjc3NGNhNDFmYWM0MjA3OTExOTgzOg0KDQogIExpbnV4IDMuMTItcmMyICgy
MDEzLTA5LTIzIDE1OjQxOjA5IC0wNzAwKQ0KDQphcmUgYXZhaWxhYmxlIGluIHRoZSBnaXQgcmVw
b3NpdG9yeSBhdDoNCg0KICBnaXQ6Ly9naXQubGludXgtbmZzLm9yZy9wcm9qZWN0cy90cm9uZG15
L2xpbnV4LW5mcy5naXQgdGFncy9uZnMtZm9yLTMuMTItNA0KDQpmb3IgeW91IHRvIGZldGNoIGNo
YW5nZXMgdXAgdG8gMzY3MTU2ZDlhODdiMjFiNTIzMmRkOTMxMDdjNWZjNjFiMDliYTJlZjoNCg0K
ICBORlM6IEdpdmUgImZsYXZvciIgYW4gaW5pdGlhbCB2YWx1ZSB0byBmaXggYSBjb21waWxlIHdh
cm5pbmcgKDIwMTMtMDktMjkgMTY6MDM6MzQgLTA0MDApDQoNCi0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCk5GUyBjbGllbnQg
YnVnZml4ZXMgZm9yIDMuMTINCg0KLSBTdGFibGUgZml4IGZvciBPb3BzZXMgaW4gdGhlIHBORlMg
ZmlsZXMgbGF5b3V0IGRyaXZlcg0KLSBGaXggYSByZWdyZXNzaW9uIHdoZW4gZG9pbmcgYSBub24t
ZXhjbHVzaXZlIGZpbGUgY3JlYXRlIG9uIE5GU3Y0LngNCi0gTkZTdjQuMSBzZWN1cml0eSBuZWdv
dGlhdGlvbiBmaXhlcyB3aGVuIGxvb2tpbmcgdXAgdGhlIHJvb3QgZmlsZXN5c3RlbQ0KLSBGaXgg
YSBtZW1vcnkgb3JkZXJpbmcgaXNzdWUgaW4gdGhlIHBORlMgZmlsZXMgbGF5b3V0IGRyaXZlcg0K
DQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tDQpBbm5hIFNjaHVtYWtlciAoMSk6DQogICAgICBORlM6IEdpdmUgImZsYXZvciIg
YW4gaW5pdGlhbCB2YWx1ZSB0byBmaXggYSBjb21waWxlIHdhcm5pbmcNCg0KVHJvbmQgTXlrbGVi
dXN0ICgzKToNCiAgICAgIE5GU3Y0OiBIb25vdXIgdGhlICdvcGVuZWQnIHBhcmFtZXRlciBpbiB0
aGUgYXRvbWljX29wZW4oKSBmaWxlc3lzdGVtIG1ldGhvZA0KICAgICAgTkZTdjQuMTogbmZzNF9m
bF9wcmVwYXJlX2RzIC0gZml4IGJ1Z3Mgd2hlbiB0aGUgY29ubmVjdCBhdHRlbXB0IGZhaWxzDQog
ICAgICBORlN2NC4xOiBFbnN1cmUgbWVtb3J5IG9yZGVyaW5nIGJldHdlZW4gbmZzNF9kc19jb25u
ZWN0IGFuZCBuZnM0X2ZsX3ByZXBhcmVfZHMNCg0KV2VzdG9uIEFuZHJvcyBBZGFtc29uICgxKToN
CiAgICAgIE5GU3Y0LjE6IHRyeSBTRUNJTkZPX05PX05BTUUgZmxhdnMgdW50aWwgb25lIHdvcmtz
DQoNCiBmcy9uZnMvZGlyLmMgICAgICAgICAgICAgICB8ICAyICstDQogZnMvbmZzL25mczRmaWxl
LmMgICAgICAgICAgfCAgMyArKy0NCiBmcy9uZnMvbmZzNGZpbGVsYXlvdXRkZXYuYyB8IDIwICsr
KysrKysrKy0tLS0tLS0NCiBmcy9uZnMvbmZzNHByb2MuYyAgICAgICAgICB8IDU4ICsrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0NCiBpbmNsdWRlL2xpbnV4L25m
c194ZHIuaCAgICB8ICAzICsrLQ0KIDUgZmlsZXMgY2hhbmdlZCwgNjMgaW5zZXJ0aW9ucygrKSwg
MjMgZGVsZXRpb25zKC0pDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50
IG1haW50YWluZXINCg0KTmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5l
dGFwcC5jb20NCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh
aW5lcg0KDQpOZXRBcHANClRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQp3d3cubmV0YXBwLmNv
bQ0K

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2013-05-26 19:29 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2013-05-26 19:29 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list

Hi Linus,

The following changes since commit f722406faae2d073cc1d01063d1123c35425939e:

  Linux 3.10-rc1 (2013-05-11 17:14:08 -0700)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.10-3

for you to fetch changes up to 83c168bf8017212a9d502536f9dcd0b54d24e330:

  NFS: Fix SETCLIENTID fallback if GSS is not available (2013-05-23 18:50:40 -0400)

----------------------------------------------------------------
NFS client bugfixes for 3.10

- Stable fix to prevent an rpc_task wakeup race
- Fix a NFSv4.1 session drain deadlock
- Fix a NFSv4/v4.1 mount regression when not running rpc.gssd
- Ensure auth_gss pipe detection works in namespaces
- Fix SETCLIENTID fallback if rpcsec_gss is not available

----------------------------------------------------------------
Andy Adamson (1):
      NFSv4.1 Fix a pNFS session draining deadlock

Chuck Lever (1):
      NFS: Fix SETCLIENTID fallback if GSS is not available

Trond Myklebust (4):
      SUNRPC: Fix a bug in gss_create_upcall
      SUNRPC: Faster detection if gssd is actually running
      SUNRPC: Convert auth_gss pipe detection to work in namespaces
      SUNRPC: Prevent an rpc_task wakeup race

 fs/nfs/callback_proc.c         |  2 +-
 fs/nfs/callback_xdr.c          |  2 +-
 fs/nfs/nfs4client.c            |  2 +-
 fs/nfs/nfs4proc.c              |  2 +-
 fs/nfs/nfs4session.c           |  4 +--
 fs/nfs/nfs4session.h           | 13 +++++----
 fs/nfs/nfs4state.c             | 15 +++++-----
 net/sunrpc/auth_gss/auth_gss.c | 62 ++++++++++++++++++++++++++++--------------
 net/sunrpc/netns.h             |  4 +++
 net/sunrpc/rpc_pipe.c          |  5 ++++
 net/sunrpc/sched.c             |  8 +++++-
 11 files changed, 78 insertions(+), 41 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2013-03-26 18:26 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2013-03-26 18:26 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, linux-kernel

Hi Linus,

The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8:

  Linux 3.9-rc1 (2013-03-03 15:11:05 -0800)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.9-3

for you to fetch changes up to 1166fde6a923c30f4351515b6a9a1efc513e7d00:

  SUNRPC: Add barriers to ensure read ordering in rpc_wake_up_task_queue_locked (2013-03-25 11:23:40 -0400)

----------------------------------------------------------------
NFS client bugfixes for Linux 3.9

- Fix an NFSv4 idmapper regression
- Fix an Oops in the pNFS blocks client
- Fix up various issues with pNFS layoutcommit
- Ensure correct read ordering of variables in rpc_wake_up_task_queue_locked

----------------------------------------------------------------
Trond Myklebust (5):
      NFSv4: Fix the string length returned by the idmapper
      NFSv4.1: Fix a race in pNFS layoutcommit
      NFSv4.1: Always clear the NFS_INO_LAYOUTCOMMIT in layoutreturn
      NFSv4.1: Add a helper pnfs_commit_and_return_layout
      SUNRPC: Add barriers to ensure read ordering in rpc_wake_up_task_queue_locked

fanchaoting (1):
      pnfs-block: removing DM device maybe cause oops when call dev_remove

 fs/nfs/blocklayout/blocklayoutdm.c |  4 +-
 fs/nfs/idmap.c                     | 13 +++---
 fs/nfs/nfs4filelayout.c            |  1 -
 fs/nfs/nfs4proc.c                  | 16 +-------
 fs/nfs/pnfs.c                      | 81 +++++++++++++++++++++++++++++++++-----
 fs/nfs/pnfs.h                      |  6 +++
 net/sunrpc/sched.c                 |  9 ++++-
 7 files changed, 96 insertions(+), 34 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2013-03-03  0:08 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2013-03-03  0:08 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, linux-kernel

Hi Linus,

We've just concluded another Connectathon interoperability testing week,
and so here are the fixes for the bugs that were discovered.

Cheers,
  Trond

The following changes since commit 666b3d803a511fbc9bc5e5ea8ce66010cf03ea13:

  NLM: Ensure that we resend all pending blocking locks after a reclaim (2013-02-19 12:18:27 -0500)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.9-2

for you to fetch changes up to 512e4b291c0e97af24619a91f3e8963697da00d8:

  SUNRPC: One line comment fix (2013-03-02 15:54:11 -0800)

----------------------------------------------------------------
NFS client bugfixes for Linux 3.9

- Don't allow NFS silly-renamed files to be deleted
- Don't start the retransmission timer when out of socket space
- Fix a couple of pnfs-related Oopses.
- Fix one more NFSv4 state recovery deadlock
- Don't loop forever when LAYOUTGET returns NFS4ERR_LAYOUTTRYLATER

----------------------------------------------------------------
Benny Halevy (1):
      pnfs: fix resend_to_mds for directio

Jeff Layton (1):
      nfs: don't allow nfs_find_actor to match inodes of the wrong type

Trond Myklebust (4):
      NFS: Don't allow NFS silly-renamed files to be deleted, no signal
      SUNRPC: Don't start the retransmission timer when out of socket space
      NFSv4: Fix another open/open_recovery deadlock
      SUNRPC: One line comment fix

Weston Andros Adamson (4):
      NFSv4.1: Hold reference to layout hdr in layoutget
      PNFS: set the default DS timeout to 60 seconds
      SUNRPC: add call to get configured timeout
      NFSv4.1: LAYOUTGET EDELAY loops timeout to the MDS

 fs/nfs/inode.c              |  2 ++
 fs/nfs/nfs4filelayout.c     |  6 ++++--
 fs/nfs/nfs4filelayout.h     |  2 +-
 fs/nfs/nfs4proc.c           | 21 ++++++++++++++++++---
 fs/nfs/pnfs.c               | 21 +++++++++++++--------
 fs/nfs/pnfs.h               |  6 ++++--
 fs/nfs/unlink.c             | 20 +++++++++++++-------
 include/linux/nfs_xdr.h     |  1 +
 include/linux/sunrpc/clnt.h |  1 +
 net/sunrpc/clnt.c           | 15 +++++++++++++++
 net/sunrpc/xprt.c           |  6 +++++-
 11 files changed, 77 insertions(+), 24 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2013-02-21  3:38 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2013-02-21  3:38 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list

Hi Linus,

The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7:

  Linux 3.8-rc6 (2013-02-01 12:08:14 +1100)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.9-1

for you to fetch changes up to 666b3d803a511fbc9bc5e5ea8ce66010cf03ea13:

  NLM: Ensure that we resend all pending blocking locks after a reclaim (2013-02-19 12:18:27 -0500)

----------------------------------------------------------------
NFS client bugfixes for Linux 3.9

- Fix an Oops in the pNFS layoutget code
- Fix a number of NFSv4 and v4.1 state recovery deadlocks and hangs
  due to the interaction of the session drain lock and state management
  locks.
- Remove task->tk_xprt, which was hiding a lot of RCU dereferencing bugs
- Fix a long standing NFSv3 posix lock recovery bug.
- Revert commit 324d003b0cd82151adbaecefef57b73f7959a469. It turned out
  that the root cause of the deadlock was due to interactions with the
  workqueues that have now been resolved.

----------------------------------------------------------------
Jeff Layton (1):
      sunrpc: silence build warning in gss_fill_context

Tim Gardner (1):
      nfs: remove kfree() redundant null checks

Trond Myklebust (18):
      SUNRPC: Eliminate task->tk_xprt accesses that bypass rcu_dereference()
      SUNRPC: Pass a pointer to struct rpc_xprt to the connect callback
      SUNRPC: Fix an RCU dereference in xs_local_rpcbind
      SUNRPC: Pass pointers to struct rpc_xprt to the congestion window
      SUNRPC: Fix an RCU dereference in xprt_reserve
      SUNRPC: Avoid RCU dereferences in the transport bind and connect code
      SUNRPC: Nuke the tk_xprt macro
      Revert "NFS: add nfs_sb_deactive_async to avoid deadlock"
      SUNRPC: Add missing static declaration to _gss_mech_get_by_name
      NFSv4: Allow the state manager to mark an open_owner as being recovered
      NFSv4.1: Prevent deadlocks between state recovery and file locking
      NFSv4.1: Don't lose locks when a server reboots during delegation return
      NFSv4: Fix up the return values of nfs4_open_delegation_recall
      NFSv4: Ensure delegation recall and byte range lock removal don't conflict
      NFSv4: Fix a reboot recovery race when opening a file
      NFSv4.1: Fix an ABBA locking issue with session and state serialisation
      NFSv4.1: Fix bulk recall and destroy of layouts
      NLM: Ensure that we resend all pending blocking locks after a reclaim

Weston Andros Adamson (1):
      NFSv4.1: Don't decode skipped layoutgets

fanchaoting (1):
      umount oops when remove blocklayoutdriver first

 fs/lockd/clntproc.c                   |   3 +
 fs/nfs/blocklayout/blocklayout.c      |   1 +
 fs/nfs/callback_proc.c                |  61 ++------------
 fs/nfs/delegation.c                   | 154 ++++++++++++++++++++++++----------
 fs/nfs/delegation.h                   |   1 +
 fs/nfs/getroot.c                      |   3 +-
 fs/nfs/inode.c                        |   5 +-
 fs/nfs/internal.h                     |   1 -
 fs/nfs/nfs4_fs.h                      |   4 +
 fs/nfs/nfs4proc.c                     | 133 ++++++++++++++++++++---------
 fs/nfs/nfs4state.c                    |  11 ++-
 fs/nfs/objlayout/objio_osd.c          |   1 +
 fs/nfs/pnfs.c                         | 150 ++++++++++++++++++++++++++++-----
 fs/nfs/pnfs.h                         |   7 +-
 fs/nfs/super.c                        |  49 -----------
 fs/nfs/unlink.c                       |   5 +-
 include/linux/sunrpc/sched.h          |   1 -
 include/linux/sunrpc/xprt.h           |   6 +-
 net/sunrpc/auth_gss/auth_gss.c        |   5 +-
 net/sunrpc/auth_gss/gss_mech_switch.c |   4 +-
 net/sunrpc/clnt.c                     |  16 ++--
 net/sunrpc/xprt.c                     |  21 +++--
 net/sunrpc/xprtrdma/rpc_rdma.c        |   4 +-
 net/sunrpc/xprtrdma/transport.c       |   7 +-
 net/sunrpc/xprtrdma/xprt_rdma.h       |   6 +-
 net/sunrpc/xprtsock.c                 |  16 ++--
 26 files changed, 415 insertions(+), 260 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2013-01-07 15:45 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2013-01-07 15:45 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Linux NFS mailing list

Hi Linus,

The following changes since commit d1c3ed669a2d452cacfb48c2d171a1f364dae2ed:

  Linux 3.8-rc2 (2013-01-02 18:13:21 -0800)

are available in the git repository at:

  git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.8-2

for you to fetch changes up to ecf0eb9edbb607d74f74b73c14af8b43f3729528:

  nfs: avoid dereferencing null pointer in initiate+AF8-bulk+AF8-draining (2013-01-05 14:26:51 -0500)

----------------------------------------------------------------
NFS client bugfixes for Linux 3.8

- Fix a permissions problem when opening NFSv4 files that only have the
  exec bit set.
- Fix a couple of typos in pNFS (inverted logic), and the mount parsing
  (missing pointer dereference).
- Work around a series of deadlock issues due to workqueues using
  struct work+AF8-struct pointer address comparisons in the re-entrancy
  tests. Ensure that we don't free struct work+AF8-struct prematurely if
  our work function involves waiting for completion of other work
  items (e.g. by calling rpc+AF8-shutdown+AF8-client).
- Revert the part of commit 168e4b3 that is causing unnecessary warnings
  to be issued in the nfsd callback code.

----------------------------------------------------------------
Nickolai Zeldovich (1):
      nfs: avoid dereferencing null pointer in initiate+AF8-bulk+AF8-draining

Trond Myklebust (3):
      SUNRPC: Ensure that we free the rpc+AF8-task after cleanups are done
      NFS: Ensure that we free the rpc+AF8-task after read and write cleanups are done
      SUNRPC: Partial revert of commit 168e4b39d1afb79a7e3ea6c3bb246b4c82c6bdb9

Weston Andros Adamson (1):
      NFS: Fix access to suid/sgid executables

Xi Wang (1):
      nfs: fix null checking in nfs+AF8-get+AF8-option+AF8-str()

Yanchuan Nian (1):
      pnfs: Increase the refcount when LAYOUTGET fails the first time

 fs/nfs/callback+AF8-proc.c +AHw-  2 +--
 fs/nfs/dir.c           +AHw- 16 +-+-+-+-+-+-+-+-+-+-------
 fs/nfs/nfs4proc.c      +AHw- 18 +-+-+-+-+-+-+-+-+-+-+--------
 fs/nfs/pnfs.c          +AHw-  2 +--
 fs/nfs/read.c          +AHw- 10 +-+-+-+-+-+-+----
 fs/nfs/super.c         +AHw-  2 +--
 fs/nfs/write.c         +AHw- 10 +-+-+-+-+-+-+----
 net/sunrpc/clnt.c      +AHw-  5 -----
 net/sunrpc/sched.c     +AHw- 27 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-----
 9 files changed, 61 insertions(+-), 31 deletions(-)

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust+AEA-netapp.com
www.netapp.com

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2012-11-03 19:48 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2012-11-03 19:48 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list

SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgMDhmMDVjNDk3
NDllZTY1NWJlZjkyMWQxMjE2MDk2MGEyNzNhYWQ0NzoNCg0KICBSZXR1cm4gdGhlIHJpZ2h0IGVy
cm9yIHZhbHVlIHdoZW4gZHVwWzIzXSgpIG5ld2ZkIGFyZ3VtZW50IGlzIHRvbyBsYXJnZSAoMjAx
Mi0xMC0zMCAyMToyNzoyOCAtMDcwMCkNCg0KYXJlIGF2YWlsYWJsZSBpbiB0aGUgZ2l0IHJlcG9z
aXRvcnkgYXQ6DQoNCiAgZ2l0Oi8vZ2l0LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9s
aW51eC1uZnMuZ2l0IHRhZ3MvbmZzLWZvci0zLjctNA0KDQpmb3IgeW91IHRvIGZldGNoIGNoYW5n
ZXMgdXAgdG8gOTk4ZjQwYjU1MGYyNTdlNDM2NDg1MjkxODAyZmE5MzhlNGNmNTgwZjoNCg0KICBO
RlM0OiBuZnM0X29wZW5kYXRhX2FjY2VzcyBzaG91bGQgcmV0dXJuIGVycm5vICgyMDEyLTExLTAy
IDE4OjUxOjU0IC0wNDAwKQ0KDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpORlMgYnVnZml4ZXMgZm9yIExpbnV4IDMuNw0K
DQotIEZpeCBhIGJ1bmNoIG9mIGRlYWRsb2NrIHNpdHVhdGlvbnM6DQogICogU3RhdGUgcmVjb3Zl
cnkgY2FuIGRlYWRsb2NrIGlmIHdlIGZhaWwgdG8gcmVsZWFzZSBzZXF1ZW5jZSBpZHMgYmVmb3Jl
DQogICAgc2NoZWR1bGluZyB0aGUgcmVjb3ZlcnkgdGhyZWFkLg0KICAqIENhbGxpbmcgZGVhY3Rp
dmF0ZV9zdXBlcigpIGZyb20gYW4gUlBDIHdvcmtxdWV1ZSB0aHJlYWQgY2FuIGRlYWRsb2NrDQog
ICAgYmVjYXVzZSBvZiB0aGUgY2FsbCB0byBycGNfc2h1dGRvd25fY2xpZW50Lg0KLSBEaXNwbGF5
IHRoZSBkZXZpY2UgbmFtZSBjb3JyZWN0bHkgaW4gL3Byb2MvKi9tb3VudHMNCi0gRml4IGEgbnVt
YmVyIG9mIGluY29ycmVjdCBlcnJvciByZXR1cm4gdmFsdWVzOg0KICAqIFdoZW4gTkZTdjMgbW91
bnRzIGZhaWwgZHVlIHRvIGEgdGltZW91dC4NCiAgKiBPbiBORlN2NC4xIGJhY2tjaGFubmVsIHNl
dHVwIGZhaWx1cmUNCiAgKiBPbiBORlN2NCBvcGVuIGFjY2VzcyBjaGVja3MNCi0gcG5mc19maW5k
X2FsbG9jX2xheW91dCgpIG11c3QgY2hlY2sgdGhlIGxheW91dCBwb2ludGVyIGZvciBOVUxMDQot
IEZpeCBhIHJlZ3Jlc3Npb24gaW4gdGhlIGxlZ2FjeSBETlMgcmVzb2x2ZWQNCg0KLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0K
QmVuIEh1dGNoaW5ncyAoMSk6DQogICAgICBuZnM6IFNob3cgb3JpZ2luYWwgZGV2aWNlIG5hbWUg
dmVyYmF0aW0gaW4gL3Byb2MvKi9tb3VudHtzLGluZm99DQoNCkJyeWFuIFNjaHVtYWtlciAoMSk6
DQogICAgICBORlM6IFdhaXQgZm9yIHNlc3Npb24gcmVjb3ZlcnkgdG8gZmluaXNoIGJlZm9yZSBy
ZXR1cm5pbmcNCg0KTmVpbEJyb3duICgxKToNCiAgICAgIE5GUzogZml4IGJ1ZyBpbiBsZWdhY3kg
RE5TIHJlc29sdmVyLg0KDQpTY290dCBNYXloZXcgKDEpOg0KICAgICAgbmZzdjM6IE1ha2UgdjMg
bW91bnRzIGZhaWwgd2l0aCBFVElNRURPVVRzIGluc3RlYWQgRUlPIG9uIG1vdW50ZCB0aW1lb3V0
cw0KDQpUcm9uZCBNeWtsZWJ1c3QgKDMpOg0KICAgICAgTkZTdjQuMTogV2UgbXVzdCByZWxlYXNl
IHRoZSBzZXF1ZW5jZSBpZCB3aGVuIHdlIGZhaWwgdG8gZ2V0IGEgc2Vzc2lvbiBzbG90DQogICAg
ICBORlN2NDogbmZzNF9sb2NrdV9kb25lIG11c3QgcmVsZWFzZSB0aGUgc2VxdWVuY2UgaWQNCiAg
ICAgIE5GU3Y0OiBJbml0aWFsaXNlIHRoZSBORlN2NC4xIHNsb3QgdGFibGUgaGlnaGVzdF91c2Vk
X3Nsb3RpZCBjb3JyZWN0bHkNCg0KV2VzdG9uIEFuZHJvcyBBZGFtc29uICgzKToNCiAgICAgIE5G
UzogYWRkIG5mc19zYl9kZWFjdGl2ZV9hc3luYyB0byBhdm9pZCBkZWFkbG9jaw0KICAgICAgU1VO
UlBDOiByZXR1cm4gcHJvcGVyIGVycm5vIGZyb20gYmFja2NoYW5uZWxfcnFzdA0KICAgICAgTkZT
NDogbmZzNF9vcGVuZGF0YV9hY2Nlc3Mgc2hvdWxkIHJldHVybiBlcnJubw0KDQpZYW5jaHVhbiBO
aWFuICgxKToNCiAgICAgIG5mczogQ2hlY2sgd2hldGhlciBhIGxheW91dCBwb2ludGVyIGlzIE5V
TEwgYmVmb3JlIGZyZWUgaXQNCg0KIGZzL25mcy9kbnNfcmVzb2x2ZS5jICAgICAgICAgIHwgIDUg
KysrLS0NCiBmcy9uZnMvaW5vZGUuYyAgICAgICAgICAgICAgICB8ICA1ICsrKystDQogZnMvbmZz
L2ludGVybmFsLmggICAgICAgICAgICAgfCAgNiArKystLQ0KIGZzL25mcy9tb3VudF9jbG50LmMg
ICAgICAgICAgIHwgIDIgKy0NCiBmcy9uZnMvbmFtZXNwYWNlLmMgICAgICAgICAgICB8IDE5ICsr
KysrKysrKysrLS0tLS0NCiBmcy9uZnMvbmZzNG5hbWVzcGFjZS5jICAgICAgICB8ICAzICsrLQ0K
IGZzL25mcy9uZnM0cHJvYy5jICAgICAgICAgICAgIHwgNDYgKysrKysrKysrKysrKysrKysrKysr
KystLS0tLS0tLS0tLS0tLS0NCiBmcy9uZnMvcG5mcy5jICAgICAgICAgICAgICAgICB8ICA0ICsr
LS0NCiBmcy9uZnMvc3VwZXIuYyAgICAgICAgICAgICAgICB8IDUxICsrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKy0NCiBmcy9uZnMvdW5saW5rLmMgICAgICAgICAgICAg
ICB8ICAyICstDQogbmV0L3N1bnJwYy9iYWNrY2hhbm5lbF9ycXN0LmMgfCAgMiArLQ0KIDExIGZp
bGVzIGNoYW5nZWQsIDExMCBpbnNlcnRpb25zKCspLCAzNSBkZWxldGlvbnMoLSkNCg0KLS0gDQpU
cm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lcg0KDQpOZXRBcHANClRy
b25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQp3d3cubmV0YXBwLmNvbQ0K

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes...
@ 2012-10-22 17:42 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2012-10-22 17:42 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list

SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgZGRmZmViOGM0
ZDAzMzE2MDllZjI1ODFkODRkZTRkNzYzNjA3YmQzNzoNCg0KICBMaW51eCAzLjctcmMxICgyMDEy
LTEwLTE0IDE0OjQxOjA0IC0wNzAwKQ0KDQphcmUgYXZhaWxhYmxlIGluIHRoZSBnaXQgcmVwb3Np
dG9yeSBhdDoNCg0KICBnaXQ6Ly9naXQubGludXgtbmZzLm9yZy9wcm9qZWN0cy90cm9uZG15L2xp
bnV4LW5mcy5naXQgdGFncy9uZnMtZm9yLTMuNy0yDQoNCmZvciB5b3UgdG8gZmV0Y2ggY2hhbmdl
cyB1cCB0byBlOWI3ZTkxNzQ1ZmE5ZGY5NDkwMGM4YWIwOGU2MzNmMzM2Njg2MDk4Og0KDQogIE5G
U3Y0OiBGaXggdGhlIHJldHVybiB2YWx1ZSBmb3IgbmZzX2NhbGxiYWNrX3N0YXJ0X3N2YyAoMjAx
Mi0xMC0xNiAxMzoxNDo0MiAtMDQwMCkNCg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KTkZTIGNsaWVudCBidWdmaXhlcyBm
b3IgTGludXggMy43DQoNCi0gRG8gbm90IGNhbGwgcG5mc19yZXR1cm5fbGF5b3V0KCkgZnJvbSBh
biBycGNpb2QgY29udGV4dA0KLSBuZnM0X2RzX2Rpc2Nvbm5lY3QgY2FuIGNhdXNlIE9vcHNlcy4g
S2lsbCBpdC4uLg0KLSBGaXggdGhlIHJldHVybiB2YWx1ZSBmb3IgbmZzX2NhbGxiYWNrX3N0YXJ0
X3N2Yw0KLSBGaXggYSBudW1iZXIgb2YgY29tcGlsZSB3YXJuaW5ncw0KDQotLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpUcm9u
ZCBNeWtsZWJ1c3QgKDYpOg0KICAgICAgTkZTdjQuMTogS2lsbCBuZnM0X2RzX2Rpc2Nvbm5lY3Qo
KQ0KICAgICAgTkZTdjQuMTogRG8gbm90IGNhbGwgcG5mc19yZXR1cm5fbGF5b3V0KCkgZnJvbSBh
biBycGNpb2QgY29udGV4dA0KICAgICAgTkZTdjQuMTogVXNlIGtjYWxsb2MoKSB0byBhbGxvY2F0
ZSB6ZXJvZWQgYXJyYXlzIGluc3RlYWQgb2Yga3phbGxvYygpDQogICAgICBORlN2NDogZnMvbmZz
L25mczRnZXRyb290LmMgbmVlZHMgdG8gaW5jbHVkZSAiaW50ZXJuYWwuaCINCiAgICAgIE5GU3Y0
LjE6IERlY2xhcmUgb3NkX3ByaV8yX3BuZnNfZXJyKCksIG9iamlvX2luaXRfcmVhZC93cml0ZSB0
byBiZSBzdGF0aWMNCiAgICAgIE5GU3Y0OiBGaXggdGhlIHJldHVybiB2YWx1ZSBmb3IgbmZzX2Nh
bGxiYWNrX3N0YXJ0X3N2Yw0KDQogZnMvbmZzL2NhbGxiYWNrLmMgICAgICAgICAgICB8ICAyICst
DQogZnMvbmZzL25mczRmaWxlbGF5b3V0LmMgICAgICB8IDIxICsrKysrKysrKysrKysrKystLS0t
LQ0KIGZzL25mcy9uZnM0ZmlsZWxheW91dC5oICAgICAgfCAgMSAtDQogZnMvbmZzL25mczRmaWxl
bGF5b3V0ZGV2LmMgICB8IDIyIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCiBmcy9uZnMvbmZzNGdl
dHJvb3QuYyAgICAgICAgIHwgIDEgKw0KIGZzL25mcy9vYmpsYXlvdXQvb2JqaW9fb3NkLmMgfCAg
NiArKystLS0NCiBmcy9uZnMvcG5mcy5oICAgICAgICAgICAgICAgIHwgIDEgKw0KIDcgZmlsZXMg
Y2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0pDQoNCi0tIA0KVHJvbmQg
TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCg0KTmV0QXBwDQpUcm9uZC5N
eWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5ldGFwcC5jb20NCg==

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2012-09-12 19:19 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2012-09-12 19:19 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux Kernel mailing list, Linux NFS mailing list

SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgMDg2NjAwNDMw
NDkzZTA0YjgwMmJlZTZlNWIzY2UwNDU4ZTRlYjc3ZjoNCg0KICBORlN2MzogRW5zdXJlIHRoYXQg
ZG9fcHJvY19nZXRfcm9vdCgpIHJlcG9ydHMgZXJyb3JzIGNvcnJlY3RseSAoMjAxMi0wOC0yMCAx
Mjo1Mjo0MiAtMDQwMCkNCg0KYXJlIGF2YWlsYWJsZSBpbiB0aGUgZ2l0IHJlcG9zaXRvcnkgYXQ6
DQoNCiAgZ2l0Oi8vZ2l0LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9saW51eC1uZnMu
Z2l0IHRhZ3MvbmZzLWZvci0zLjYtNA0KDQpmb3IgeW91IHRvIGZldGNoIGNoYW5nZXMgdXAgdG8g
N2IyODFlZTAyNjU1MmYxMDg2MmI2MTdhMmE1MWFjZjQ5YzgyOTU1NDoNCg0KICBORlM6IGZzeW5j
KCkgbXVzdCBleGl0IHdpdGggYW4gZXJyb3IgaWYgcGFnZSB3cml0ZWJhY2sgZmFpbGVkICgyMDEy
LTA5LTExIDE1OjM4OjMyIC0wNDAwKQ0KDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpORlMgY2xpZW50IGJ1Z2ZpeGVzIGZv
ciBMaW51eCAzLjYNCg0KLSBGaW5hbCAoaG9wZWZ1bGx5KSBmaXggZm9yIHRoZSByYW5nZSBjaGVj
a2luZyBjb2RlIGluIE5GU3Y0IGdldGFjbC4gVGhpcw0KICBzaG91bGQgZml4IHRoZSBPb3BzZXMg
YmVpbmcgc2VlbiB3aGVuIHRoZSBhY2wgc2l6ZSBpcyBjbG9zZSB0byBQQUdFX1NJWkUuDQotIEZp
eCBhIHJlZ3Jlc3Npb24gd2l0aCB0aGUgbGVnYWN5IGJpbmFyeSBtb3VudCBjb2RlDQotIEZpeCBh
IHJlZ3Jlc3Npb24gaW4gdGhlIHJlYWRkaXIgY29va2lldmVyZiBpbml0aWFsaXNhdGlvbg0KLSBG
aXggYW4gUlBDIG92ZXIgVURQIHJlZ3Jlc3Npb24NCi0gRW5zdXJlIHRoYXQgd2UgcmVwb3J0IGFs
bCBlcnJvcnMgaW4gdGhlIE5GU3Y0IG9wZW4gY29kZQ0KLSBFbnN1cmUgdGhhdCBmc3luYygpIHJl
cG9ydHMgYWxsIHJlbGV2YW50IHN5bmNocm9uaXNhdGlvbiBlcnJvcnMuDQoNCi0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NClRy
b25kIE15a2xlYnVzdCAoNik6DQogICAgICBORlM6IEZpeCB0aGUgaW5pdGlhbGlzYXRpb24gb2Yg
dGhlIHJlYWRkaXIgJ2Nvb2tpZXZlcmYnIGFycmF5DQogICAgICBORlM6IEZpeCBhIHByb2JsZW0g
d2l0aCB0aGUgbGVnYWN5IGJpbmFyeSBtb3VudCBjb2RlDQogICAgICBORlN2NDogRml4IHJhbmdl
IGNoZWNraW5nIGluIF9fbmZzNF9nZXRfYWNsX3VuY2FjaGVkIGFuZCBfX25mczRfcHJvY19zZXRf
YWNsDQogICAgICBORlN2NDogRml4IGJ1ZmZlciBvdmVyZmxvdyBjaGVja2luZyBpbiBfX25mczRf
Z2V0X2FjbF91bmNhY2hlZA0KICAgICAgU1VOUlBDOiBGaXggYSBVRFAgdHJhbnNwb3J0IHJlZ3Jl
c3Npb24NCiAgICAgIE5GUzogZnN5bmMoKSBtdXN0IGV4aXQgd2l0aCBhbiBlcnJvciBpZiBwYWdl
IHdyaXRlYmFjayBmYWlsZWQNCg0KV2VzdG9uIEFuZHJvcyBBZGFtc29uICgxKToNCiAgICAgIE5G
UzogcmV0dXJuIGVycm9yIGZyb20gZGVjb2RlX2dldGZoIGluIGRlY29kZSBvcGVuDQoNCiBmcy9u
ZnMvZmlsZS5jICAgICAgICAgICAgICAgICAgIHwgIDQgKystDQogZnMvbmZzL2lub2RlLmMgICAg
ICAgICAgICAgICAgICB8ICAyICstDQogZnMvbmZzL25mczNwcm9jLmMgICAgICAgICAgICAgICB8
ICAyICstDQogZnMvbmZzL25mczRmaWxlLmMgICAgICAgICAgICAgICB8ICA0ICsrLQ0KIGZzL25m
cy9uZnM0cHJvYy5jICAgICAgICAgICAgICAgfCA1NSArKysrKysrKysrKysrKysrKysrLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLQ0KIGZzL25mcy9uZnM0eGRyLmMgICAgICAgICAgICAgICAgfCAxNyAr
KysrKystLS0tLS0tDQogZnMvbmZzL3N1cGVyLmMgICAgICAgICAgICAgICAgICB8ICAyICsrDQog
aW5jbHVkZS9saW51eC9uZnNfZnMuaCAgICAgICAgICB8ICA1IC0tLS0NCiBpbmNsdWRlL2xpbnV4
L25mc194ZHIuaCAgICAgICAgIHwgIDIgKy0NCiBpbmNsdWRlL2xpbnV4L3N1bnJwYy94cHJ0Lmgg
ICAgIHwgIDMgKysrDQogbmV0L3N1bnJwYy94cHJ0LmMgICAgICAgICAgICAgICB8IDM0ICsrKysr
KysrKysrKysrLS0tLS0tLS0tLS0NCiBuZXQvc3VucnBjL3hwcnRyZG1hL3RyYW5zcG9ydC5jIHwg
IDEgKw0KIG5ldC9zdW5ycGMveHBydHNvY2suYyAgICAgICAgICAgfCAgMyArKysNCiAxMyBmaWxl
cyBjaGFuZ2VkLCA3MCBpbnNlcnRpb25zKCspLCA2NCBkZWxldGlvbnMoLSkNCg0KLS0gDQpUcm9u
ZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lcg0KDQpOZXRBcHANClRyb25k
Lk15a2xlYnVzdEBuZXRhcHAuY29tDQp3d3cubmV0YXBwLmNvbQ0K

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2012-07-13 15:14 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2012-07-13 15:14 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list

VGhlIGZvbGxvd2luZyBjaGFuZ2VzIHNpbmNlIGNvbW1pdCA2YjE2MzUxYWNiZDQxNWU2NmJhMTZi
ZjdkNDczZWNlMTU3NGNmMGJjOg0KDQogIExpbnV4IDMuNS1yYzQgKDIwMTItMDYtMjQgMTI6NTM6
MDQgLTA3MDApDQoNCmFyZSBhdmFpbGFibGUgaW4gdGhlIGdpdCByZXBvc2l0b3J5IGF0Og0KDQog
IGdpdDovL2dpdC5saW51eC1uZnMub3JnL3Byb2plY3RzL3Ryb25kbXkvbGludXgtbmZzLmdpdCB0
YWdzL25mcy1mb3ItMy41LTQNCg0KZm9yIHlvdSB0byBmZXRjaCBjaGFuZ2VzIHVwIHRvIGYxZGFm
NjY2ZGQ3ZDA5NzY1M2JkMzgzMjAyNDhjNjgwODRiMWZlYmY6DQoNCiAgTkZTdjQ6IEZpeCBhbiBO
RlN2NCBtb3VudCByZWdyZXNzaW9uICgyMDEyLTA3LTEwIDEzOjI1OjM5IC0wNDAwKQ0KDQotLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tDQpORlMgY2xpZW50IGJ1Z2ZpeGVzIGZvciBMaW51eCAzLjUNCg0KLSBGaXggYW4gTkZTdjQg
bW91bnQgcmVncmVzc2lvbg0KLSBGaXggT19ESVJFQ1QgbGlzdCBtYW5pcHVsYXRpb24gc25hZnVz
DQoNCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0NClRyb25kIE15a2xlYnVzdCAoMik6DQogICAgICBORlM6IEZpeCBsaXN0IG1h
bmlwdWxhdGlvbiBzbmFmdXMgaW4gZnMvbmZzL2RpcmVjdC5jDQogICAgICBORlN2NDogRml4IGFu
IE5GU3Y0IG1vdW50IHJlZ3Jlc3Npb24NCg0KIGZzL25mcy9kaXJlY3QuYyB8ICAgIDYgKysrKyst
DQogZnMvbmZzL3N1cGVyLmMgIHwgICAgMiArKw0KIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRp
b25zKCspLCAxIGRlbGV0aW9uKC0pDQoNCkNoZWVycw0KICBUcm9uZA0KDQotLSANClRyb25kIE15
a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyDQoNCk5ldEFwcA0KVHJvbmQuTXlr
bGVidXN0QG5ldGFwcC5jb20NCnd3dy5uZXRhcHAuY29tDQoNCg==

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2012-05-02  3:57 Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2012-05-02  3:57 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list

SGkgTGludXMsDQoNClBsZWFzZSBwdWxsIGZyb20gdGhlIHNpZ25lZCB0YWcgIm5mcy1mb3ItMy40
LTQiIGluIHRoZSByZXBvc2l0b3J5IGF0DQoNCiAgIGdpdCBwdWxsIGdpdDovL2dpdC5saW51eC1u
ZnMub3JnL3Byb2plY3RzL3Ryb25kbXkvbGludXgtbmZzLmdpdCB0YWdzL25mcy1mb3ItMy40LTQN
Cg0KVGhpcyB3aWxsIHVwZGF0ZSB0aGUgZm9sbG93aW5nIGZpbGVzIHRocm91Z2ggdGhlIGFwcGVu
ZGVkIGNoYW5nZXNldHMuDQoNCiAgQ2hlZXJzLA0KICAgIFRyb25kDQoNCi0tLS0NCiBmcy9uZnMv
YmxvY2tsYXlvdXQvYmxvY2tsYXlvdXQuYyB8ICAgIDQgKy0NCiBmcy9uZnMvY2xpZW50LmMgICAg
ICAgICAgICAgICAgICB8ICAgIDUgKy0NCiBmcy9uZnMvaWRtYXAuYyAgICAgICAgICAgICAgICAg
ICB8ICAgIDQgKw0KIGZzL25mcy9pbnRlcm5hbC5oICAgICAgICAgICAgICAgIHwgICAgOCArLQ0K
IGZzL25mcy9uYW1lc3BhY2UuYyAgICAgICAgICAgICAgIHwgICA5MyArKysrKysrLS0tLS0tLS0t
LS0tLS0tLS0tDQogZnMvbmZzL25mczRfZnMuaCAgICAgICAgICAgICAgICAgfCAgIDEwICsrLQ0K
IGZzL25mcy9uZnM0ZmlsZWxheW91dGRldi5jICAgICAgIHwgICAgMiArLQ0KIGZzL25mcy9uZnM0
bmFtZXNwYWNlLmMgICAgICAgICAgIHwgICA4NiArKysrKysrKysrKysrKysrKysrKystLQ0KIGZz
L25mcy9uZnM0cHJvYy5jICAgICAgICAgICAgICAgIHwgIDE0MiArKysrKysrKysrKysrKysrKysr
KysrKysrKystLS0tLS0tLS0tDQogZnMvbmZzL25mczR4ZHIuYyAgICAgICAgICAgICAgICAgfCAg
IDQ0ICsrKysrKysrLS0tLQ0KIGZzL25mcy9vYmpsYXlvdXQvb2JqbGF5b3V0LmMgICAgIHwgICAg
MiAtDQogZnMvbmZzL3BuZnMuYyAgICAgICAgICAgICAgICAgICAgfCAgICAyICstDQogZnMvbmZz
L3N1cGVyLmMgICAgICAgICAgICAgICAgICAgfCAgICA0ICstDQogbmV0L3N1bnJwYy9jbG50LmMg
ICAgICAgICAgICAgICAgfCAgIDUwICsrKysrKysrKystLS0NCiBuZXQvc3VucnBjL3JwY19waXBl
LmMgICAgICAgICAgICB8ICAgIDMgKy0NCiAxNSBmaWxlcyBjaGFuZ2VkLCAzMDggaW5zZXJ0aW9u
cygrKSwgMTUxIGRlbGV0aW9ucygtKQ0KDQpjb21taXQgMzYxN2U1MDMxYjNhY2VjMDRlZmFhMzY1
NjZhODExMWFjOGYwNzMyNQ0KQXV0aG9yOiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVz
dEBuZXRhcHAuY29tPg0KRGF0ZTogICBNb24gQXByIDMwIDEyOjA0OjU4IDIwMTIgLTA0MDANCg0K
ICAgIE5GU3Y0LjE6IFVzZSB0aGUgY29ycmVjdCBob3N0bmFtZSBpbiB0aGUgY2xpZW50IGlkZW50
aWZpZXIgc3RyaW5nDQogICAgDQogICAgV2UgbmVlZCB0byB1c2UgdGhlIGhvc3RuYW1lIG9mIHRo
ZSBwcm9jZXNzIHRoYXQgY3JlYXRlZCB0aGUgbmZzX2NsaWVudC4NCiAgICBUaGF0IGhvc3RuYW1l
IGlzIG5vdyBzdG9yZWQgaW4gdGhlIHJwY19jbGllbnQtPmNsX25vZGVuYW1lLg0KICAgIA0KICAg
IEFsc28gcmVtb3ZlIHRoZSB1dHNuYW1lKCktPmRvbWFpbm5hbWUgY29tcG9uZW50LiBUaGVyZSBp
cyBubyByZWFzb24NCiAgICB0byBpbmNsdWRlIHRoZSBOSVMvWVAgZG9tYWlubmFtZSBpbiBhIGNs
aWVudCBpZGVudGlmaWVyIHN0cmluZy4NCiAgICANCiAgICBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBN
eWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KDQpjb21taXQgY2JiYjM0NDk4
ZjhiMmIyNmNiZGM3OTUzMmM4YTJlZTVjZDFlNzU2YQ0KQXV0aG9yOiBUcm9uZCBNeWtsZWJ1c3Qg
PFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KRGF0ZTogICBNb24gQXByIDMwIDExOjUyOjQw
IDIwMTIgLTA0MDANCg0KICAgIFNVTlJQQzogUlBDIGNsaWVudCBtdXN0IHVzZSB0aGUgY3VycmVu
dCB1dHNuYW1lIGhvc3RuYW1lIHN0cmluZw0KICAgIA0KICAgIE5vdyB0aGF0IHRoZSBycGMgY2xp
ZW50IGlzIG5hbWVzcGFjZSBhd2FyZSwgaXQgbmVlZHMgdG8gdXNlIHRoZQ0KICAgIHV0c25hbWUg
b2YgdGhlIHByb2Nlc3MgdGhhdCBjcmVhdGVkIGl0IGluc3RlYWQgb2YgdXNpbmcgdGhlDQogICAg
aW5pdF91dHNuYW1lLiBCb3RoIHJwY19uZXdfY2xpZW50IGFuZCBycGNfY2xvbmVfY2xpZW50IG5l
ZWQgdG8NCiAgICBiZSBmaXhlZC4NCiAgICANCiAgICBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWts
ZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KICAgIENjOiBTdGFuaXNsYXYgS2lu
c2J1cnNreSA8c2tpbnNidXJza3lAcGFyYWxsZWxzLmNvbT4NCg0KY29tbWl0IDcxZGZjNWZhNTE2
MGJiNzM3NTJmMDczMTUzOTQwNDU2OWE3N2ZhY2ENCkF1dGhvcjogU3RhbmlzbGF2IEtpbnNidXJz
a3kgPHNraW5zYnVyc2t5QHBhcmFsbGVscy5jb20+DQpEYXRlOiAgIFNhdCBBcHIgMjggMTk6MzI6
MjEgMjAxMiArMDQwMA0KDQogICAgTkZTOiBnZXQgbW9kdWxlIGluIGlkbWFwIFBpcGVGUyBub3Rp
ZmllciBjYWxsYmFjaw0KICAgIA0KICAgIFRoaXMgaXMgYnVnIGZpeC4NCiAgICBOb3RpZmllciBj
YWxsYmFjayBpcyBjYWxsZWQgZnJvbSBTVU5SUEMgbW9kdWxlLiBTbyBiZWZvcmUgZGVyZWZlcmVu
Y2luZyBORlMNCiAgICBtb2R1bGUgd2UgaGF2ZSB0byBtYWtlIHN1cmUsIHRoYXQgaXQncyBhbGl2
ZS4NCiAgICANCiAgICBTaWduZWQtb2ZmLWJ5OiBTdGFuaXNsYXYgS2luc2J1cnNreSA8c2tpbnNi
dXJza3lAcGFyYWxsZWxzLmNvbT4NCiAgICBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3Qg
PFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KDQpjb21taXQgZTI0NWQ0MjUwZDAzMjZjZmNm
N2M4MTZhMjA4MWI2YWIyZWE4MTBiZQ0KQXV0aG9yOiBCcnlhbiBTY2h1bWFrZXIgPGJqc2NodW1h
QG5ldGFwcC5jb20+DQpEYXRlOiAgIEZyaSBBcHIgMjcgMTM6Mjc6NDMgMjAxMiAtMDQwMA0KDQog
ICAgTkZTOiBSZW1vdmUgdW51c2VkIGZ1bmN0aW9uIG5mc19sb29rdXBfd2l0aF9zZWMoKQ0KICAg
IA0KICAgIFRoaXMgZml4ZXMgYSBjb21waWxlciB3YXJuaW5nLg0KICAgIA0KICAgIFNpZ25lZC1v
ZmYtYnk6IEJyeWFuIFNjaHVtYWtlciA8YmpzY2h1bWFAbmV0YXBwLmNvbT4NCiAgICBTaWduZWQt
b2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KDQpj
b21taXQgN2U2ZWI2ODNkMjYwZDkzMjVmMGQxYmQ5MTE1MThkNWVkM2NiNGYwYw0KQXV0aG9yOiBC
cnlhbiBTY2h1bWFrZXIgPGJqc2NodW1hQG5ldGFwcC5jb20+DQpEYXRlOiAgIEZyaSBBcHIgMjcg
MTM6Mjc6NDIgMjAxMiAtMDQwMA0KDQogICAgTkZTOiBIb25vciB0aGUgYXV0aGZsYXZvciBzZXQg
aW4gdGhlIGNsb25lIG1vdW50IGRhdGENCiAgICANCiAgICBUaGUgYXV0aGZsYXZvciBpcyBzZXQg
aW4gYW4gbmZzX2Nsb25lX21vdW50IHN0cnVjdHVyZSBhbmQgcGFzc2VkIHRvIHRoZQ0KICAgIHhk
ZXZfbW91bnQoKSBmdW5jdGlvbnMgd2hlcmUgaXQgd2FzIHByb21wdGx5IGlnbm9yZWQuICBJbnN0
ZWFkLCB1c2UgaXQNCiAgICB0byBpbml0aWFsaXplIGFuIHJwY19jbG50IGZvciB0aGUgY2xvbmVk
IHNlcnZlci4NCiAgICANCiAgICBTaWduZWQtb2ZmLWJ5OiBCcnlhbiBTY2h1bWFrZXIgPGJqc2No
dW1hQG5ldGFwcC5jb20+DQogICAgU2lnbmVkLW9mZi1ieTogVHJvbmQgTXlrbGVidXN0IDxUcm9u
ZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbT4NCg0KY29tbWl0IGYwNWQxNDdmN2UzY2YwZDg2YjNhNGJk
NTYwMzAyOWE3Y2IxMDk2MzMNCkF1dGhvcjogQnJ5YW4gU2NodW1ha2VyIDxianNjaHVtYUBuZXRh
cHAuY29tPg0KRGF0ZTogICBGcmkgQXByIDI3IDEzOjI3OjQxIDIwMTIgLTA0MDANCg0KICAgIE5G
UzogRml4IGZvbGxvd2luZyByZWZlcnJhbCBtb3VudCBwb2ludHMgd2l0aCBkaWZmZXJlbnQgc2Vj
dXJpdHkNCiAgICANCiAgICBJIGNyZWF0ZSBhIG5ldyBwcm9jX2xvb2t1cF9tb3VudHBvaW50KCkg
dG8gdXNlIHdoZW4gc3VibW91bnRpbmcgYW4gTkZTDQogICAgdjQgc2hhcmUuICBUaGlzIGZ1bmN0
aW9uIHJldHVybnMgYW4gcnBjX2NsbnQgdG8gdXNlIGZvciBwZXJmb3JtaW5nIGFuDQogICAgZnNf
bG9jYXRpb25zKCkgY2FsbCBvbiBhIHJlZmVycmFsJ3MgbW91bnRwb2ludC4NCiAgICANCiAgICBT
aWduZWQtb2ZmLWJ5OiBCcnlhbiBTY2h1bWFrZXIgPGJqc2NodW1hQG5ldGFwcC5jb20+DQogICAg
U2lnbmVkLW9mZi1ieTogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNv
bT4NCg0KY29tbWl0IDcyZGU1M2VjNGJjYTM5YzI2NzA5MTIyYThmNzhiZmVmZTdiNmJjYTQNCkF1
dGhvcjogQnJ5YW4gU2NodW1ha2VyIDxianNjaHVtYUBuZXRhcHAuY29tPg0KRGF0ZTogICBGcmkg
QXByIDI3IDEzOjI3OjQwIDIwMTIgLTA0MDANCg0KICAgIE5GUzogRG8gc2VjaW5mbyBhcyBwYXJ0
IG9mIGxvb2t1cA0KICAgIA0KICAgIFdoZW5ldmVyIGxvb2t1cCBzZWVzIHdyb25nc2VjIGRvIGEg
c2VjaW5mbyBhbmQgcmV0cnkgdGhlIGxvb2t1cCB0byBmaW5kDQogICAgYXR0cmlidXRlcyBvZiB0
aGUgZmlsZSBvciBkaXJlY3RvcnksIHN1Y2ggYXMgImlzIHRoaXMgYSByZWZlcnJhbA0KICAgIG1v
dW50cG9pbnQ/Ii4gIFRoaXMgYWxzbyBhbGxvd3MgbWUgdG8gcmVtb3ZlIGhhbmRsaW5nIC1ORlM0
RVJSX1dST05TRUMNCiAgICBhcyBwYXJ0IG9mIGdldGF0dHIgeGRyIGRlY29kaW5nLg0KICAgIA0K
ICAgIFNpZ25lZC1vZmYtYnk6IEJyeWFuIFNjaHVtYWtlciA8YmpzY2h1bWFAbmV0YXBwLmNvbT4N
CiAgICBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRh
cHAuY29tPg0KDQpjb21taXQgZGIwYTk1OTNkNTJmOTM1YzgwMDg1ZDg5OTNiZGNlYWQxYWQzMGIw
Yw0KQXV0aG9yOiBCcnlhbiBTY2h1bWFrZXIgPGJqc2NodW1hQG5ldGFwcC5jb20+DQpEYXRlOiAg
IEZyaSBBcHIgMjcgMTM6Mjc6MzkgMjAxMiAtMDQwMA0KDQogICAgTkZTOiBIYW5kbGUgZXhjZXB0
aW9ucyBjb21pbmcgb3V0IG9mIG5mczRfcHJvY19mc19sb2NhdGlvbnMoKQ0KICAgIA0KICAgIFdl
IGRvbid0IHdhbnQgdG8gcmV0dXJuIC1ORlM0RVJSX1dST05HU0VDIHRvIHRoZSBWRlMgYmVjYXVz
ZSBpdCBjb3VsZA0KICAgIGNhdXNlIHRoZSBrZXJuZWwgdG8gb29wcy4NCiAgICANCiAgICBTaWdu
ZWQtb2ZmLWJ5OiBCcnlhbiBTY2h1bWFrZXIgPGJqc2NodW1hQG5ldGFwcC5jb20+DQogICAgU2ln
bmVkLW9mZi1ieTogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbT4N
Cg0KY29tbWl0IDMxZTRkZGE0NzQ3NzEzZGUxMzg4OWY3Yzc5YzdhZWMzNDFmZWE2MWINCkF1dGhv
cjogQnJ5YW4gU2NodW1ha2VyIDxianNjaHVtYUBuZXRhcHAuY29tPg0KRGF0ZTogICBGcmkgQXBy
IDI3IDEzOjI3OjM4IDIwMTIgLTA0MDANCg0KICAgIE5GUzogRml4IFNFQ0lORk9fTk9fTkFNRQ0K
ICAgIA0KICAgIEkgd2FzIHVzaW5nIHRoZSBzYW1lIGRlY29kZXIgZnVuY3Rpb24gZm9yIFNFQ0lO
Rk8gYW5kIFNFQ0lORk9fTk9fTkFNRSwNCiAgICBzbyBpdCB3YXMgcmV0dXJuaW5nIGFuIGVycm9y
IHdoZW4gaXQgdHJpZWQgdG8gZGVjb2RlIGFuIE9QX1NFQ0lORk9fTk9fTkFNRQ0KICAgIGhlYWRl
ciBhcyBPUF9TRUNJTkZPLg0KICAgIA0KICAgIFNpZ25lZC1vZmYtYnk6IEJyeWFuIFNjaHVtYWtl
ciA8YmpzY2h1bWFAbmV0YXBwLmNvbT4NCiAgICBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1
c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KDQpjb21taXQgZWE4Y2ZhMDY3OTViYjMw
ZDJlYTYxZjUwM2VmMTI5Mjg0NDkyYzA2YQ0KQXV0aG9yOiBTdGFuaXNsYXYgS2luc2J1cnNreSA8
c2tpbnNidXJza3lAcGFyYWxsZWxzLmNvbT4NCkRhdGU6ICAgRnJpIEFwciAyNyAxMzowMDoxNyAy
MDEyICswNDAwDQoNCiAgICBTVU5SUEM6IHRyYXZlcnNlIGNsaWVudHMgdHJlZSBvbiBQaXBlRlMg
ZXZlbnQNCiAgICANCiAgICB2MjogcmVjdXJzaW9uIHdhcyByZXBsYWNlZCBieSBsb29wDQogICAg
DQogICAgSWYgY2xpZW50IGlzIGEgY2xvbmUsIHRoZW4gaXQncyBwYXJlbnQgY2FuIG5vdCBiZSBp
biB0aGUgbGlzdC4NCiAgICBCdXQgcGFyZW50J3MgUGlwZWZzIGRlbnRyaWVzIGhhdmUgdG8gYmUg
Y3JlYXRlZCBhbmQgZGVzdHJveWVkLg0KICAgIA0KICAgIE5vdGU6IGV2ZW50IHNraXAgaGVscGVy
IGZvciBjbGllbnRzIGludHJvZHVjZWQNCiAgICANCiAgICBTaWduZWQtb2ZmLWJ5OiBTdGFuaXNs
YXYgS2luc2J1cnNreSA8c2tpbnNidXJza3lAcGFyYWxsZWxzLmNvbT4NCiAgICBTaWduZWQtb2Zm
LWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KDQpjb21t
aXQgMzc2MjliNTcyY2M0ZTgwZmMyNGI0MTM5YTI0ZGYxYTg5NDE1ZDUzNA0KQXV0aG9yOiBTdGFu
aXNsYXYgS2luc2J1cnNreSA8c2tpbnNidXJza3lAcGFyYWxsZWxzLmNvbT4NCkRhdGU6ICAgRnJp
IEFwciAyMCAxODoxOTo1NiAyMDEyICswNDAwDQoNCiAgICBTVU5SUEM6IHNldCBwZXItbmV0IFBp
cGVGUyBzdXBlcmJsb2NrIGJlZm9yZSBub3RpZmljYXRpb24NCiAgICANCiAgICBUaGVyZSBjYW4g
YmUgYSBjYXNlLCB3aGVuIG9uIE1PVU5UIGV2ZW50IFJQQyBjbGllbnQgKGFmdGVyIGl0J3MgZGVu
dHJpZXMgd2VyZQ0KICAgIGNyZWF0ZWQpIGlzIG5vdCBsb25nZXIgaG9sZCBieSBhbnlvbmUgZXhj
ZXB0IG5vdGlmaWNhdGlvbiBjYWxsYmFjay4NCiAgICBJLmUuIG9uIHJlbGVhc2UgdGhpcyBjbGll
bnQgd2lsbCBiZSBkZXN0b3JveWVkLiBBbmQgaXQncyBkZW50cmllcyBoYXZlIHRvIGJlDQogICAg
ZGVzdHJveWVkIGFzIHdlbGwuIFdoaWNoIGluIHR1cm4gcmVxdWlyZXMgcGVyLW5ldCBQaXBlRlMg
c3VwZXJibG9jayB0byBiZSBzZXQuDQogICAgDQogICAgU2lnbmVkLW9mZi1ieTogU3RhbmlzbGF2
IEtpbnNidXJza3kgPHNraW5zYnVyc2t5QHBhcmFsbGVscy5jb20+DQogICAgU2lnbmVkLW9mZi1i
eTogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbT4NCg0KY29tbWl0
IDdhYWI0NDllNWEyZWJmYTljNTExNmU4N2UxNjUzNmJjNDE5NWU0ZGUNCkF1dGhvcjogU3Rhbmlz
bGF2IEtpbnNidXJza3kgPHNraW5zYnVyc2t5QHBhcmFsbGVscy5jb20+DQpEYXRlOiAgIEZyaSBB
cHIgMjAgMTg6MTk6MTggMjAxMiArMDQwMA0KDQogICAgU1VOUlBDOiBza2lwIGNsaWVudHMgd2l0
aCBwcm9ncmFtIHdpdGhvdXQgUGlwZUZTIGVudHJpZXMNCiAgICANCiAgICAxKSBUaGlzIGlzIHNh
bmUuDQogICAgMikgT3RoZXJ3aXNlIHRoZXJlIHdpbGwgYmUgc29mdCBsb2NrdXA6DQogICAgDQog
ICAgZG8gew0KICAgIAlycGNfZ2V0X2NsaWVudF9mb3JfZXZlbnQgKGNsbnQtPmNsX2RlbnRyeSA9
PSBOVUxMID09PiBjaG9vc2UpDQogICAgCV9fcnBjX3BpcGVmc19ldmVudCAoY2xudC0+Y2xfcHJv
Z3JhbS0+cGlwZV9kaXJfbmFtZSA9PSBOVUxMID09PiByZXR1cm4pDQogICAgfSB3aGlsZSAoMSkN
CiAgICANCiAgICBTaWduZWQtb2ZmLWJ5OiBTdGFuaXNsYXYgS2luc2J1cnNreSA8c2tpbnNidXJz
a3lAcGFyYWxsZWxzLmNvbT4NCiAgICBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPFRy
b25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KDQpjb21taXQgYTRkZmYxYmM0OTJlZTRhMjE4NGQz
ODRhZThiNWJjYWI1ODU5ZTE1MA0KQXV0aG9yOiBTdGFuaXNsYXYgS2luc2J1cnNreSA8c2tpbnNi
dXJza3lAcGFyYWxsZWxzLmNvbT4NCkRhdGU6ICAgRnJpIEFwciAyMCAxODoxMTowMiAyMDEyICsw
NDAwDQoNCiAgICBTVU5SUEM6IHNraXAgZGVhZCBidXQgbm90IGJ1cmllZCBjbGllbnRzIG9uIFBp
cGVGUyBldmVudHMNCiAgICANCiAgICBUaGVzZSBjbGllbnRzIGNhbid0IGJlIHNhZmVseSBkZXJl
ZmVyZW5jZWQgaWYgdGhlaXIgY291bnRlciBpbiAwLg0KICAgIA0KICAgIFNpZ25lZC1vZmYtYnk6
IFN0YW5pc2xhdiBLaW5zYnVyc2t5IDxza2luc2J1cnNreUBwYXJhbGxlbHMuY29tPg0KICAgIFNp
Z25lZC1vZmYtYnk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20+
DQoNCmNvbW1pdCA1Nzk0ZDIxZWY0NjM5ZjBlMzM0NDA5MjdiYjkwM2Y5NTk4YzIxZTkyDQpBdXRo
b3I6IFNhY2hpbiBQcmFiaHUgPHNwcmFiaHVAcmVkaGF0LmNvbT4NCkRhdGU6ICAgVHVlIEFwciAx
NyAxNDozNjo0MCAyMDEyICswMTAwDQoNCiAgICBBdm9pZCBiZXlvbmQgYm91bmRzIGNvcHkgd2hp
bGUgY2FjaGluZyBBQ0wNCiAgICANCiAgICBXaGVuIGF0dGVtcHRpbmcgdG8gY2FjaGUgQUNMcyBy
ZXR1cm5lZCBmcm9tIHRoZSBzZXJ2ZXIsIGlmIHRoZSBiaXRtYXANCiAgICBzaXplICsgdGhlIEFD
TCBzaXplIGlzIGdyZWF0ZXIgdGhhbiBhIFBBR0VfU0laRSBidXQgdGhlIEFDTCBzaXplIGl0c2Vs
Zg0KICAgIGlzIHNtYWxsZXIgdGhhbiBhIFBBR0VfU0laRSwgd2UgY2FuIHJlYWQgcGFzdCB0aGUg
YnVmZmVyIHBhZ2UgYm91bmRhcnkuDQogICAgDQogICAgU2lnbmVkLW9mZi1ieTogU2FjaGluIFBy
YWJodSA8c3ByYWJodUByZWRoYXQuY29tPg0KICAgIFJlcG9ydGVkLWJ5OiBKaWFuIExpIDxqaWFs
aUByZWRoYXQuY29tPg0KICAgIFNpZ25lZC1vZmYtYnk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQu
TXlrbGVidXN0QG5ldGFwcC5jb20+DQoNCmNvbW1pdCA1YTAwNjg5OTMwYWI5NzVmZGQxYjM3YjAz
NDQ3NTAxN2U0NjBjZjJhDQpBdXRob3I6IFNhY2hpbiBQcmFiaHUgPHNwcmFiaHVAcmVkaGF0LmNv
bT4NCkRhdGU6ICAgVHVlIEFwciAxNyAxNDozNTozOSAyMDEyICswMTAwDQoNCiAgICBBdm9pZCBy
ZWFkaW5nIHBhc3QgYnVmZmVyIHdoZW4gY2FsbGluZyBHRVRBQ0wNCiAgICANCiAgICBCdWcgbm90
aWNlZCBpbiBjb21taXQNCiAgICBiZjExOGEzNDJmMTBkYWZlNDRiMTQ0NTFhMTM5MmMzMjU0NjI5
YTFmDQogICAgDQogICAgV2hlbiBjYWxsaW5nIEdFVEFDTCwgaWYgdGhlIHNpemUgb2YgdGhlIGJp
dG1hcCBhcnJheSwgdGhlIGxlbmd0aA0KICAgIGF0dHJpYnV0ZSBhbmQgdGhlIGFjbCByZXR1cm5l
ZCBieSB0aGUgc2VydmVyIGlzIGdyZWF0ZXIgdGhhbiB0aGUNCiAgICBhbGxvY2F0ZWQgYnVmZmVy
KGFyZ3MuYWNsX2xlbiksIHdlIGNhbiBPb3BzIHdpdGggYSBHZW5lcmFsIFByb3RlY3Rpb24NCiAg
ICBmYXVsdCBhdCBfY29weV9mcm9tX3BhZ2VzKCkgd2hlbiB3ZSBhdHRlbXB0IHRvIHJlYWQgcGFz
dCB0aGUgcGFnZXMNCiAgICBhbGxvY2F0ZWQuDQogICAgDQogICAgVGhpcyBwYXRjaCBhbGxvY2F0
ZXMgYW4gZXh0cmEgUEFHRSBmb3IgdGhlIGJpdG1hcCBhbmQgY2hlY2tzIHRvIHNlZSB0aGF0DQog
ICAgdGhlIGJpdG1hcCArIGF0dHJpYnV0ZV9sZW5ndGggKyBBQ0xzIGRvbid0IGV4Y2VlZCB0aGUg
YnVmZmVyIHNwYWNlDQogICAgYWxsb2NhdGVkIHRvIGl0Lg0KICAgIA0KICAgIFNpZ25lZC1vZmYt
Ynk6IFNhY2hpbiBQcmFiaHUgPHNwcmFiaHVAcmVkaGF0LmNvbT4NCiAgICBSZXBvcnRlZC1ieTog
SmlhbiBMaSA8amlhbGlAcmVkaGF0LmNvbT4NCiAgICBbVHJvbmQ6IEZpeGVkIGEgc2l6ZV90IHZz
IHVuc2lnbmVkIGludCBwcmludGsoKSB3YXJuaW5nXQ0KICAgIFNpZ25lZC1vZmYtYnk6IFRyb25k
IE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20+DQoNCmNvbW1pdCAxMGJkMjk1
YTBiNjQ4OGViZTYzNGI3MmExMWQ4OTg2YmQzYWYzODE5DQpBdXRob3I6IEppbSBSZWVzIDxyZWVz
QHVtaWNoLmVkdT4NCkRhdGU6ICAgTW9uIEFwciA5IDIyOjMzOjM5IDIwMTIgLTA0MDANCg0KICAg
IGZpeCBwYWdlIG51bWJlciBjYWxjdWxhdGlvbiBidWcgZm9yIGJsb2NrIGxheW91dCBkZWNvZGUg
YnVmZmVyDQogICAgDQogICAgU2lnbmVkLW9mZi1ieTogSmltIFJlZXMgPHJlZXNAdW1pY2guZWR1
Pg0KICAgIFN1Z2dlc3RlZC1ieTogQW5keSBBZGFtc29uIDxhbmRyb3NAbmV0YXBwLmNvbT4NCiAg
ICBTdWdnZXN0ZWQtYnk6IEZyZWQgSXNhbWFuIDxpaXNhbWFuQG5ldGFwcC5jb20+DQogICAgU2ln
bmVkLW9mZi1ieTogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbT4N
Cg0KY29tbWl0IGU1MjY1YTBjNTg3NDIzYmJkMjFhNmIzOWE1NzJjZWNmZjE2YjkzNDYNCkF1dGhv
cjogQW5keSBBZGFtc29uIDxhbmRyb3NAbmV0YXBwLmNvbT4NCkRhdGU6ICAgU2F0IEFwciAxNCAw
Mzo1NjozNSAyMDEyIC0wNDAwDQoNCiAgICBORlN2NC4xIGZpeCBwYWdlIG51bWJlciBjYWxjdWxh
dGlvbiBidWcgZm9yIGZpbGVsYXlvdXQgZGVjb2RlIGJ1ZmZlcnMNCiAgICANCiAgICBTaWduZWQt
b2ZmLWJ5OiBBbmR5IEFkYW1zb24gPGFuZHJvc0BuZXRhcHAuY29tPg0KICAgIFNpZ25lZC1vZmYt
Ynk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20+DQoNCmNvbW1p
dCA5NTI2YjJiNmQ2YjlmMTgzYjY2Y2YyMWM0YWZhNmU3OWQ1YTE0ZjQ0DQpBdXRob3I6IFNhY2hp
biBCaGFtYXJlIDxzYmhhbWFyZUBwYW5hc2FzLmNvbT4NCkRhdGU6ICAgRnJpIE1hciAzMCAxNDoy
OTo1OSAyMDEyIC0wNzAwDQoNCiAgICBwbmZzLW9iajogUmVtb3ZlIHVudXNlZCB2YXJpYWJsZSBm
cm9tIG9iamxheW91dF9nZXRfZGV2aWNlaW5mbygpDQogICAgDQogICAgTG9jYWwgdmFyaWFibGUg
J3NiJyB3YXMgbm90IGJlaW5nIHVzZWQgaW4gb2JqbGF5b3V0X2dldF9kZXZpY2VpbmZvKCkuDQog
ICAgDQogICAgU2lnbmVkLW9mZi1ieTogU2FjaGluIEJoYW1hcmUgPHNiaGFtYXJlQHBhbmFzYXMu
Y29tPg0KICAgIFNpZ25lZC1vZmYtYnk6IEJvYXogSGFycm9zaCA8YmhhcnJvc2hAcGFuYXNhcy5j
b20+DQogICAgU2lnbmVkLW9mZi1ieTogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RA
bmV0YXBwLmNvbT4NCg0KY29tbWl0IDFhYmExNTY3NjM3YjkzZWVlMzIyNTNiNDJkZWFhYWQzODFj
MzE3NWINCkF1dGhvcjogV2VzdG9uIEFuZHJvcyBBZGFtc29uIDxkcm9zQG5ldGFwcC5jb20+DQpE
YXRlOiAgIFR1ZSBBcHIgMjQgMTY6NTA6MzcgMjAxMiAtMDQwMA0KDQogICAgbmZzNDogZml4IHJl
ZmVycmFscyBvbiBtb3VudHMgdGhhdCB1c2UgSVB2NiBhZGRycw0KICAgIA0KICAgIEFsbCByZWZl
cnJhbHMgKElQdjQgYWRkciwgSVB2NiBhZGRyLCBhbmQgRE5TKSBhcmUgYnJva2VuIG9uIG1vdW50
cyBvZg0KICAgIElQdjYgYWRkcmVzc2VzLCBiZWNhdXNlIHZhbGlkYXRpb24gY29kZSB1c2VzIGEg
cGF0aCB0aGF0IGlzIHBhcnNlZA0KICAgIGZyb20gdGhlIGRldl9uYW1lICgiPHNlcnZlcj46PHBh
dGg+IikgYnkgc3BsaXR0aW5nIG9uIHRoZSBmaXJzdCBjb2xvbiBhbmQNCiAgICBjb2xvbnMgYXJl
IHVzZWQgaW4gSVB2NiBhZGRycy4NCiAgICBUaGlzIHBhdGNoIGlnbm9yZXMgY29sb25zIHdpdGhp
biBJUHY2IGFkZHJlc3NlcyB0aGF0IGFyZSBlc2NhcGVkIGJ5ICdbJyBhbmQgJ10nLg0KICAgIA0K
ICAgIFNpZ25lZC1vZmYtYnk6IFdlc3RvbiBBbmRyb3MgQWRhbXNvbiA8ZHJvc0BuZXRhcHAuY29t
Pg0KICAgIFNpZ25lZC1vZmYtYnk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0QG5l
dGFwcC5jb20+DQoNCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFp
bnRhaW5lcg0KDQpOZXRBcHANClRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQp3d3cubmV0YXBw
LmNvbQ0KDQo=

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] please pull NFS client bugfixes
@ 2012-04-24 20:18 " Myklebust, Trond
  0 siblings, 0 replies; 47+ messages in thread
From: Myklebust, Trond @ 2012-04-24 20:18 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list

SGkgTGludXMsDQoNClBsZWFzZSBwdWxsIGZyb20gdGhlIHNpZ25lZCB0YWcgIm5mcy1mb3ItMy40
LTMiIGluIHRoZSByZXBvc2l0b3J5IGF0DQoNCiAgIGdpdCBwdWxsIGdpdDovL2dpdC5saW51eC1u
ZnMub3JnL3Byb2plY3RzL3Ryb25kbXkvbGludXgtbmZzLmdpdCB0YWdzL25mcy1mb3ItMy40LTMN
Cg0KVGhpcyB3aWxsIHVwZGF0ZSB0aGUgZm9sbG93aW5nIGZpbGVzIHRocm91Z2ggdGhlIGFwcGVu
ZGVkIGNoYW5nZXNldHMuDQoNCiAgQ2hlZXJzLA0KICAgIFRyb25kDQoNCi0tLS0NCiBmcy9uZnMv
ZGlyLmMgICAgICAgICAgICAgfCAgICA0ICsrLS0NCiBmcy9uZnMvbmZzNF9mcy5oICAgICAgICAg
fCAgICAxICsNCiBmcy9uZnMvbmZzNHByb2MuYyAgICAgICAgfCAgIDQ0ICsrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tDQogZnMvbmZzL25mczRzdGF0ZS5jICAgICAg
IHwgICAzMSArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tDQogZnMvbmZzL25mczR4ZHIu
YyAgICAgICAgIHwgICAgOSArKysrKy0tLS0NCiBmcy9uZnMvcmVhZC5jICAgICAgICAgICAgfCAg
ICAyICstDQogZnMvbmZzL3N1cGVyLmMgICAgICAgICAgIHwgICAgOCArKysrKystLQ0KIGZzL25m
cy93cml0ZS5jICAgICAgICAgICB8ICAgIDUgKysrLS0NCiBpbmNsdWRlL2xpbnV4L25mc194ZHIu
aCAgfCAgICA3ICsrKysrKy0NCiBuZXQvc3VucnBjL3N1bnJwY19zeW1zLmMgfCAgIDE3ICsrKysr
KysrKy0tLS0tLS0tDQogMTAgZmlsZXMgY2hhbmdlZCwgODggaW5zZXJ0aW9ucygrKSwgNDAgZGVs
ZXRpb25zKC0pDQoNCmNvbW1pdCA3YmY5N2JjMjczMDhjZmRjN2E4ZGFkZDQwYWU1MGY3YzRjYjA5
YjAxDQpBdXRob3I6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20+
DQpEYXRlOiAgIFNhdCBBcHIgMjEgMTI6MzY6MTkgMjAxMiAtMDQwMA0KDQogICAgTkZTdjQ6IEtl
ZXAgZHJvcHBlZCBzdGF0ZSBvd25lcnMgb24gdGhlIExSVSBsaXN0IGZvciBhIHdoaWxlDQogICAg
DQogICAgVG8gZW5zdXJlIHRoYXQgd2UgZG9uJ3QgcmV1c2UgdGhlaXIgaWRlbnRpZmllcnMuDQog
ICAgDQogICAgU2lnbmVkLW9mZi1ieTogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RA
bmV0YXBwLmNvbT4NCg0KY29tbWl0IGM3NzM2NWM5NjNjZjg3MDNlY2YxMDA0Y2QzYjI5ODA2OGEz
ZTFiNzYNCkF1dGhvcjogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNv
bT4NCkRhdGU6ICAgU2F0IEFwciAyMSAxMjozMTowNSAyMDEyIC0wNDAwDQoNCiAgICBORlN2NDog
RW5zdXJlIHRoYXQgd2UgZG9uJ3QgZHJvcCBhIHN0YXRlIG93bmVyIG1vcmUgdGhhbiBvbmNlDQog
ICAgDQogICAgUmV0ZXN0IHRoZSBSQl9FTVBUWV9OT0RFKCkgY29uZGl0aW9uIHVuZGVyIHRoZSBz
cGluIGxvY2sNCiAgICB0byBlbnN1cmUgdGhhdCB3ZSBkb24ndCBjYWxsIHJiX2VyYXNlKCkgbW9y
ZSB0aGFuIG9uY2Ugb24gdGhlDQogICAgc2FtZSBzdGF0ZSBvd25lci4NCiAgICANCiAgICBTaWdu
ZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0K
DQpjb21taXQgOTViNzJlYjBiZGVmNjQ3NmI3ZTczMDYxZjAzODJhZGY0NmM1NDk1YQ0KQXV0aG9y
OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KRGF0ZTogICBG
cmkgQXByIDIwIDE5OjI0OjUxIDIwMTIgLTA0MDANCg0KICAgIE5GU3Y0OiBFbnN1cmUgd2UgZG8g
bm90IHJldXNlIG9wZW4gb3duZXIgbmFtZXMNCiAgICANCiAgICBUaGUgTkZTdjQgc3BlYyBpcyBh
bWJpZ3VvdXMgYWJvdXQgd2hldGhlciBvciBub3QgaXQgaXMgcGVybWlzc2libGUNCiAgICB0byBy
ZXVzZSBvcGVuIG93bmVyIG5hbWVzLCBzbyBwbGF5IGl0IHNhZmUuIFRoaXMgcGF0Y2ggYWRkcyBh
IHRpbWVzdGFtcA0KICAgIHRvIHRoZSBzdGF0ZV9vd25lciBzdHJ1Y3R1cmUsIGFuZCBjb21iaW5l
cyB0aGF0IHdpdGggdGhlIElEQSBiYXNlZA0KICAgIHVuaXF1aWZpZXIuDQogICAgRml4ZXMgYSBy
ZWdyZXNzaW9uIHdoZXJlYnkgdGhlIExpbnV4IHNlcnZlciByZXR1cm5zIE5GUzRFUlJfQkFEX1NF
UUlELg0KICAgIA0KICAgIFNpZ25lZC1vZmYtYnk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlr
bGVidXN0QG5ldGFwcC5jb20+DQoNCmNvbW1pdCA5OGEyMTM5ZjRmNGQ3YjVmY2MzYTU0YzdmZGRi
ZTg4NjEyYWJlZDIwDQpBdXRob3I6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+DQpEYXRlOiAgIFNh
dCBTZXAgMyAwMTowOTo0MyAyMDExICswMjAwDQoNCiAgICBuZnM6IEVuY2xvc2UgaG9zdG5hbWUg
aW4gYnJhY2tldHMgd2hlbiBuZWVkZWQgaW4gbmZzX2RvX3Jvb3RfbW91bnQNCiAgICANCiAgICBX
aGVuIGhvc3RuYW1lIGNvbnRhaW5zIGNvbG9uIChlLmcuIHdoZW4gaXQgaXMgYW4gSVB2NiBhZGRy
ZXNzKSBpdCBuZWVkcw0KICAgIHRvIGJlIGVuY2xvc2VkIGluIGJyYWNrZXRzIHRvIG1ha2UgcGFy
c2luZyBvZiBORlMgZGV2aWNlIHN0cmluZyBwb3NzaWJsZS4NCiAgICBGaXggbmZzX2RvX3Jvb3Rf
bW91bnQoKSB0byBlbmNsb3NlIGhvc3RuYW1lIHByb3Blcmx5IHdoZW4gbmVlZGVkLiBORlMgY29k
ZQ0KICAgIGFjdHVhbGx5IGRvZXMgbm90IG5lZWQgdGhpcyBhcyBpdCBkb2VzIG5vdCBwYXJzZSB0
aGUgc3RyaW5nIHBhc3NlZCBieQ0KICAgIG5mc19kb19yb290X21vdW50KCkgYnV0IHRoZSBkZXZp
Y2Ugc3RyaW5nIGlzIGV4cG9zZWQgdG8gdXNlcnNwYWNlIGluDQogICAgL3Byb2MvbW91bnRzLg0K
ICAgIA0KICAgIENDOiBKb3NoIEJveWVyIDxqd2JveWVyQHJlZGhhdC5jb20+DQogICAgQ0M6IFRy
b25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20+DQogICAgU2lnbmVkLW9m
Zi1ieTogSmFuIEthcmEgPGphY2tAc3VzZS5jej4NCiAgICBDYzogc3RhYmxlQHZnZXIua2VybmVs
Lm9yZw0KICAgIFNpZ25lZC1vZmYtYnk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0
QG5ldGFwcC5jb20+DQoNCmNvbW1pdCA4Y2NkMjcxZjdhM2E4NDZjZTZmODVlYWQwNzYwZDlkMTI5
OTRhNjExDQpBdXRob3I6IEZyZWQgSXNhbWFuIDxpaXNhbWFuQG5ldGFwcC5jb20+DQpEYXRlOiAg
IEZyaSBBcHIgMjAgMTQ6NDc6MzUgMjAxMiAtMDQwMA0KDQogICAgTkZTOiBwdXQgb3BlbiBjb250
ZXh0IG9uIGVycm9yIGluIG5mc19mbHVzaF9tdWx0aQ0KICAgIA0KICAgIENjOiA8c3RhYmxlQHZn
ZXIua2VybmVsLm9yZz4NCiAgICBTaWduZWQtb2ZmLWJ5OiBGcmVkIElzYW1hbiA8aWlzYW1hbkBu
ZXRhcHAuY29tPg0KICAgIFNpZ25lZC1vZmYtYnk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlr
bGVidXN0QG5ldGFwcC5jb20+DQoNCmNvbW1pdCA3M2ZiN2JjN2M1N2Q5NzFiMTFmMmUwMDUzNmFj
MmQzZTMxNmUwNjA5DQpBdXRob3I6IEZyZWQgSXNhbWFuIDxpaXNhbWFuQG5ldGFwcC5jb20+DQpE
YXRlOiAgIEZyaSBBcHIgMjAgMTQ6NDc6MzQgMjAxMiAtMDQwMA0KDQogICAgTkZTOiBwdXQgb3Bl
biBjb250ZXh0IG9uIGVycm9yIGluIG5mc19wYWdlaW5fbXVsdGkNCiAgICANCiAgICBDYzogPHN0
YWJsZUB2Z2VyLmtlcm5lbC5vcmc+DQogICAgU2lnbmVkLW9mZi1ieTogRnJlZCBJc2FtYW4gPGlp
c2FtYW5AbmV0YXBwLmNvbT4NCiAgICBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPFRy
b25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KDQpjb21taXQgNDUxMTQ2YmU5MzNlMjZlMjEyNzc4
NTJiNWU0MGM2YTUyMjY2ZWY5Ng0KQXV0aG9yOiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xl
YnVzdEBuZXRhcHAuY29tPg0KRGF0ZTogICBXZWQgQXByIDE4IDE2OjI5OjExIDIwMTIgLTA0MDAN
Cg0KICAgIE5GU3Y0OiBGaXggb3BlbihPX1RSVU5DKSBhbmQgZnRydW5jYXRlKCkgZXJyb3IgaGFu
ZGxpbmcNCiAgICANCiAgICBJZiB0aGUgZmlsZSB3YXNuJ3Qgb3BlbmVkIGZvciB3cml0aW5nLCB0
aGVuIHRydW5jYXRlIGFuZCBmdHJ1bmNhdGUNCiAgICBuZWVkIHRvIHJlcG9ydCB0aGUgYXBwcm9w
cmlhdGUgZXJyb3JzLg0KICAgIA0KICAgIFJlcG9ydGVkLWJ5OiBNaWtsb3MgU3plcmVkaSA8bWlr
bG9zQHN6ZXJlZGkuaHU+DQogICAgU2lnbmVkLW9mZi1ieTogVHJvbmQgTXlrbGVidXN0IDxUcm9u
ZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbT4NCiAgICBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZw0K
DQpjb21taXQgNTU3MjU1MTNiNWVmOWQ0NjJhYTNlMTg1Mjc2NThhMDM2MmFhYWU4Mw0KQXV0aG9y
OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KRGF0ZTogICBX
ZWQgQXByIDE4IDEyOjQ4OjM1IDIwMTIgLTA0MDANCg0KICAgIE5GU3Y0OiBFbnN1cmUgdGhhdCB3
ZSBjaGVjayBsb2NrIGV4Y2x1c2l2ZS9zaGFyZWQgdHlwZSBhZ2FpbnN0IG9wZW4gbW9kZXMNCiAg
ICANCiAgICBTaW5jZSB3ZSBtYXkgYmUgc2ltdWxhdGluZyBmbG9jaygpIGxvY2tzIHVzaW5nIE5G
UyBieXRlIHJhbmdlIGxvY2tzLA0KICAgIHdlIGNhbid0IHJlbHkgb24gdGhlIFZGUyBoYXZpbmcg
Y2hlY2tlZCB0aGUgZmlsZSBvcGVuIG1vZGUgZm9yIHVzLg0KICAgIA0KICAgIFNpZ25lZC1vZmYt
Ynk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20+DQogICAgQ2M6
IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcNCg0KY29tbWl0IDA1ZmZlMjRmNTI5MGRjMDk1Zjk4ZmJh
Zjg0YWZlNTFlZjQwNGNjYzUNCkF1dGhvcjogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1
c3RAbmV0YXBwLmNvbT4NCkRhdGU6ICAgV2VkIEFwciAxOCAxMjoyMDoxMCAyMDEyIC0wNDAwDQoN
CiAgICBORlN2NDogRW5zdXJlIHRoYXQgdGhlIExPQ0sgY29kZSBzZXRzIGV4Y2VwdGlvbi0+aW5v
ZGUNCiAgICANCiAgICBBbGwgY2FsbGVycyBvZiBuZnM0X2hhbmRsZV9leGNlcHRpb24oKSB0aGF0
IG5lZWQgdG8gaGFuZGxlDQogICAgTkZTNEVSUl9PUEVOTU9ERSBjb3JyZWN0bHkgc2hvdWxkIHNl
dCBleGNlcHRpb24tPmlub2RlDQogICAgDQogICAgU2lnbmVkLW9mZi1ieTogVHJvbmQgTXlrbGVi
dXN0IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbT4NCiAgICBDYzogc3RhYmxlQHZnZXIua2Vy
bmVsLm9yZw0KDQpjb21taXQgY2ExMzhmMzY4YTM2ZGJhNDBkM2VmNGE1M2Q2NGFmMjAxMWNkYTNj
Nw0KQXV0aG9yOiBGcmVkIElzYW1hbiA8aWlzYW1hbkBuZXRhcHAuY29tPg0KRGF0ZTogICBUaHUg
QXByIDUgMTU6MjY6MzYgMjAxMiAtMDQwMA0KDQogICAgTkZTOiBjaGVjayBmb3IgcmVxPT1OVUxM
IGluIG5mc190cnlfdG9fdXBkYXRlX3JlcXVlc3QgY2xlYW51cA0KICAgIA0KICAgIFNpZ25lZC1v
ZmYtYnk6IEZyZWQgSXNhbWFuIDxpaXNhbWFuQG5ldGFwcC5jb20+DQogICAgU2lnbmVkLW9mZi1i
eTogVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbT4NCg0KY29tbWl0
IGFkYWUwZmUwZWE4N2U4ZmIxYTcyZGRlMzA0OTM3YzYwNzU5YjQ5NWYNCkF1dGhvcjogU3Rhbmlz
bGF2IEtpbnNidXJza3kgPHNraW5zYnVyc2t5QHBhcmFsbGVscy5jb20+DQpEYXRlOiAgIFRodSBB
cHIgNSAyMTowNDozNyAyMDEyICswNDAwDQoNCiAgICBTVU5SUEM6IHJlZ2lzdGVyIFBpcGVGUyBm
aWxlIHN5c3RlbSBhZnRlciBwZXJuZXQgc3lic3lzdGVtDQogICAgDQogICAgUGlwZUZTIHN1cGVy
YmxvY2sgY3JlYXRpb24gcm91dGluZSByZWxheXMgb24gU1VOUlBDIHBlcm5ldCBkYXRhIHByZXNl
bnNlLCB3aGljaA0KICAgIGlzIGNyZWF0ZWQgb24gcmVnaXN0ZXJfcGVybmV0X3N1YnN5cygpIGNh
bGwgaW4gU1VOUlBDIG1vZHVsZSBpbml0IGZ1bmN0aW9uLg0KICAgIFJlZ2lzdGVyaW5nIG9mIFBp
cGVGUyBmaWxlc3lzdGVtIHByaW9yIHRvIHJlZ2lzdGVyaW5nIG9mIHBlci1uZXQgc3Vic3lzdGVt
DQogICAgbGVhZHMgdG8gcmFjZXMgKG1vdW50IG9mIFBpcGVGUyBjYW4gZGVyZWZlcmVuY2UgdW5p
bml0aWFsaXplZCBkYXRhKS4NCiAgICANCiAgICBTaWduZWQtb2ZmLWJ5OiBTdGFuaXNsYXYgS2lu
c2J1cnNreSA8c2tpbnNidXJza3lAcGFyYWxsZWxzLmNvbT4NCiAgICBTaWduZWQtb2ZmLWJ5OiBU
cm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KDQoNCi0tIA0KVHJv
bmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCg0KTmV0QXBwDQpUcm9u
ZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5ldGFwcC5jb20NCg0K

^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2011-12-20  6:15 " Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2011-12-20  6:15 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-nfs, linux-kernel

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/linux-nfs.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/file.c      |    2 +-
 fs/nfs/nfs4proc.c  |   24 ++++++++++++++++--------
 fs/nfs/nfs4state.c |   33 +++++++++++++++++++++------------
 net/sunrpc/sched.c |   30 +++++++++++++++++++++++-------
 net/sunrpc/xprt.c  |   10 ++++------
 5 files changed, 65 insertions(+), 34 deletions(-)

commit 6c52961743f38747401b47127b82159ab6d8a7a4
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Dec 15 18:38:10 2011 -0500

    NFS: Fix a regression in nfs_file_llseek()
    
    After commit 06222e491e663dac939f04b125c9dc52126a75c4 (fs: handle
    SEEK_HOLE/SEEK_DATA properly in all fs's that define their own llseek)
    the behaviour of llseek() was changed so that it always revalidates
    the file size. The bug appears to be due to a logic error in the
    afore-mentioned commit, which always evaluates to 'true'.
    
    Reported-by: Roel Kluin <roel.kluin@gmail.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@vger.kernel.org [>=3.1]

commit 652f89f64fabcdae9143ee2b4253cfa838fb0279
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Fri Dec 9 19:05:58 2011 -0500

    NFSv4: Do not accept delegated opens when a delegation recall is in effect
    
    ...and report the servers that try to return a delegation when the client
    is using the CLAIM_DELEG_CUR open mode. That behaviour is explicitly
    forbidden in RFC3530.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 4b44b40e04a758e2242ff4a3f7c15982801ec8bc
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Fri Dec 9 16:31:52 2011 -0500

    NFSv4: Ensure correct locking when accessing the 'lock_states' list
    
    There are currently 2 places in the state recovery code, where we do not
    take sufficient precautions before accessing the state->lock_states. In
    both cases, we should be holding the state->state_lock.
    
    Reported-by: Pascal Bouchareine <pascal@gandi.net>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 111d489f0fb431f4ae85d96851fbf8d3248c09d8
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Dec 1 16:37:42 2011 -0500

    NFSv4.1: Ensure that we handle _all_ SEQUENCE status bits.
    
    Currently, the code assumes that the SEQUENCE status bits are mutually
    exclusive. They are not...
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@vger.kernel.org [>= 2.6.34]

commit 4f38e4aadcca319650c0de31edf7193d7c384de2
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Dec 1 16:31:34 2011 -0500

    NFSv4: Don't error if we handled it in nfs4_recovery_handle_error
    
    If we handled an error condition, then nfs4_recovery_handle_error should
    return '0' so that the state recovery thread can continue.
    Also ensure that nfs4_check_lease() continues to abort if we haven't got
    any credentials by having it return ENOKEY (which is not handled).
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit c25573b5134294c0be82bfaecc6d08136835b271
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Dec 1 14:16:17 2011 -0500

    SUNRPC: Ensure we always bump the backlog queue in xprt_free_slot
    
    Whenever we free a slot, we know that the resulting xprt->num_reqs will
    be less than xprt->max_reqs, so we know that we can release at least one
    backlogged rpc_task.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@vger.kernel.org [>=3.1]

commit 7fdcf13b292e8b2e38e42de24be2503e37b2cf97
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Dec 1 14:00:15 2011 -0500

    SUNRPC: Fix the execution time statistics in the face of RPC restarts
    
    If the rpc_task gets restarted, then we want to ensure that we don't
    double-count the execution time statistics, timeout data, etc.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2011-11-22 11:50 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2011-11-22 11:50 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-nfs, linux-kernel

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/linux-nfs.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/dir.c            |    2 +-
 fs/nfs/file.c           |   91 ++++++++++++++++++++++++++--------------------
 fs/nfs/inode.c          |    2 +-
 fs/nfs/internal.h       |    2 +
 fs/nfs/nfs3proc.c       |    1 +
 fs/nfs/nfs4proc.c       |    4 +-
 fs/nfs/pnfs.c           |   26 +++++++++++---
 fs/nfs/proc.c           |    1 +
 fs/nfs/read.c           |   14 +------
 include/linux/nfs_fs.h  |    3 ++
 include/linux/nfs_xdr.h |    1 +
 net/sunrpc/xprtsock.c   |    4 ++-
 12 files changed, 89 insertions(+), 62 deletions(-)

commit 62e4a76987eab2b7fa952546614bc83e5bfc9d3e
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Nov 10 14:30:37 2011 -0500

    NFS: Revert pnfs ugliness from the generic NFS read code path
    
    pNFS-specific code belongs in the pnfs layer. It should not be
    hijacking generic NFS read or write code paths.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 2aa13531bbbc6582874bedfcd853e1058b0fb4f9
Author: Stanislav Kinsbursky <skinsbursky@parallels.com>
Date:   Thu Nov 10 14:33:23 2011 +0300

    SUNRPC: destroy freshly allocated transport in case of sockaddr init error
    
    Otherwise we will leak xprt structure and struct net reference.
    
    Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit a6f498a891c730327645a7afa10c5ae977de6fd8
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Mon Nov 7 15:50:32 2011 -0500

    NFS: Fix a regression in the referral code
    
    Fix a regression that was introduced by commit
    0c2e53f11a6dae9e3af5f50f5ad0382e7c3e0cfa (NFS: Remove the unused
    "lookupfh()" version of nfs4_proc_lookup()).
    
    In the case where the lookup gets an NFS4ERR_MOVED, we want to return
    the result of nfs4_get_referral(). Instead, that value is getting
    clobbered by the call to nfs4_handle_exception()...
    
    Reported-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
    Tested-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 0486958f57a496212e3c1e3d9194deebba3dc3d4
Author: Jeff Layton <jlayton@redhat.com>
Date:   Fri Nov 4 13:31:22 2011 -0400

    nfs: move nfs_file_operations declaration to bottom of file.c (try #2)
    
    ...a remove a set of forward declarations.
    
    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 1788ea6e3b2a58cf4fb00206e362d9caff8d86a7
Author: Jeff Layton <jlayton@redhat.com>
Date:   Fri Nov 4 13:31:21 2011 -0400

    nfs: when attempting to open a directory, fall back on normal lookup (try #5)
    
    commit d953126 changed how nfs_atomic_lookup handles an -EISDIR return
    from an OPEN call. Prior to that patch, that caused the client to fall
    back to doing a normal lookup. When that patch went in, the code began
    returning that error to userspace. The d_revalidate codepath however
    never had the corresponding change, so it was still possible to end up
    with a NULL ctx->state pointer after that.
    
    That patch caused a regression. When we attempt to open a directory that
    does not have a cached dentry, that open now errors out with EISDIR. If
    you attempt the same open with a cached dentry, it will succeed.
    
    Fix this by reverting the change in nfs_atomic_lookup and allowing
    attempts to open directories to fall back to a normal lookup
    
    Also, add a NFSv4-specific f_ops->open routine that just returns
    -ENOTDIR. This should never be called if things are working properly,
    but if it ever is, then the dprintk may help in debugging.
    
    To facilitate this, a new file_operations field is also added to the
    nfs_rpc_ops struct.
    
    Cc: stable@kernel.org
    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2011-08-19  1:05 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2011-08-19  1:05 UTC (permalink / raw)
  To: Linus Torvalds

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/linux-nfs.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/blocklayout/blocklayout.c    |    1 +
 fs/nfs/callback.h                   |    2 +-
 fs/nfs/callback_proc.c              |   25 +++++++++++++++++++------
 fs/nfs/callback_xdr.c               |   24 +++++++-----------------
 fs/nfs/objlayout/objio_osd.c        |   28 ++++++++++++----------------
 fs/nfs/objlayout/pnfs_osd_xdr_cli.c |    3 +++
 6 files changed, 43 insertions(+), 40 deletions(-)

commit 910ac68a2b80c7de95bc8488734067b1bb15d583
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue Aug 2 14:46:52 2011 -0400

    NFSv4.1: Return NFS4ERR_BADSESSION to callbacks during session resets
    
    If the client is in the process of resetting the session when it receives
    a callback, then returning NFS4ERR_DELAY may cause a deadlock with the
    DESTROY_SESSION call.
    
    Basically, if the client returns NFS4ERR_DELAY in response to the
    CB_SEQUENCE call, then the server is entitled to believe that the
    client is busy because it is already processing that call. In that
    case, the server is perfectly entitled to respond with a
    NFS4ERR_BACK_CHAN_BUSY to any DESTROY_SESSION call.
    
    Fix this by having the client reply with a NFS4ERR_BADSESSION in
    response to the callback if it is resetting the session.
    
    Cc: stable@kernel.org [2.6.38+]
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 55a673990ec04cf63005318bcf08c2b0046e5778
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue Aug 2 14:46:29 2011 -0400

    NFSv4.1: Fix the callback 'highest_used_slotid' behaviour
    
    Currently, there is no guarantee that we will call nfs4_cb_take_slot() even
    though nfs4_callback_compound() will consistently call
    nfs4_cb_free_slot() provided the cb_process_state has set the 'clp' field.
    The result is that we can trigger the BUG_ON() upon the next call to
    nfs4_cb_take_slot().
    
    This patch fixes the above problem by using the slot id that was taken in
    the CB_SEQUENCE operation as a flag for whether or not we need to call
    nfs4_cb_free_slot().
    It also fixes an atomicity problem: we need to set tbl->highest_used_slotid
    atomically with the check for NFS4_SESSION_DRAINING, otherwise we end up
    racing with the various tests in nfs4_begin_drain_session().
    
    Cc: stable@kernel.org [2.6.38+]
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 9af7db3228acc286c50e3a0f054ec982efdbc6c6
Author: Boaz Harrosh <bharrosh@panasas.com>
Date:   Wed Aug 3 21:52:51 2011 -0700

    pnfs-obj: Fix the comp_index != 0 case
    
    There were bugs in the case of partial layout where olo_comp_index
    is not zero. This used to work and was tested but one of the later
    cleanup SQUASHMEs broke it and was not tested since.
    
    Also add a dprint that specify those received layout parameters.
    Everything else was already printed.
    
    [Needed in v3.0]
    CC: Stable Tree <stable@kernel.org>
    Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 20618b21da0796115e81906d24ff1601552701b7
Author: Boaz Harrosh <bharrosh@panasas.com>
Date:   Wed Aug 3 21:54:33 2011 -0700

    pnfs-obj: Bug when we are running out of bio
    
    When we have a situation that the number of pages we want
    to encode is bigger then the size of the bio. (Which can
    currently happen only when all IO is going to a single device
    .e.g group_width==1) then the IO is submitted short and we
    report back only the amount of bytes we actually wrote/read
    and all is fine. BUT ...
    
    There was a bug that the current length counter was advanced
    before the fail to add the extra page, and we come to a situation
    that the CDB length was one-page longer then the actual bio size,
    which is of course rejected by the osd-target.
    
    While here also fix the bio size calculation, in the case
    that we received more then one group of devices.
    
    CC: Stable Tree <stable@kernel.org>
    Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 88c9e42196285a7c573e2abda11a4b5037c669bc
Author: Heiko Carstens <heiko.carstens@de.ibm.com>
Date:   Tue Aug 2 09:57:35 2011 +0200

    nfs: add missing prefetch.h include
    
    Fix this compile error on s390:
    
      CC [M]  fs/nfs/blocklayout/blocklayout.o
    fs/nfs/blocklayout/blocklayout.c: In function 'bl_end_io_read':
    fs/nfs/blocklayout/blocklayout.c:201:4: error: implicit declaration of function 'prefetchw'
    
    Introduced with 9549ec01 "pnfsblock: bl_read_pagelist".
    
    Cc: Fred Isaman <iisaman@citi.umich.edu>
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2011-07-12 23:30 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2011-07-12 23:30 UTC (permalink / raw)
  To: Linus Torvalds

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

Kudos to Ben Greear for finding a 4 year old bug in the rpcbind client code!

  Cheers,
    Trond

----
 fs/nfs/nfs4filelayout.c |    1 -
 fs/nfs/nfs4xdr.c        |    2 +-
 fs/nfs/write.c          |    2 ++
 net/sunrpc/rpcb_clnt.c  |    2 +-
 net/sunrpc/sched.c      |   27 +++++++++++----------------
 5 files changed, 15 insertions(+), 19 deletions(-)

commit ec0dd267bf7d08cb30e321e45a75fd40edd7e528
Author: Ben Greear <greearb@candelatech.com>
Date:   Tue Jul 12 10:27:55 2011 -0700

    SUNRPC: Fix use of static variable in rpcb_getport_async
    
    Because struct rpcbind_args *map was declared static, if two
    threads entered this method at the same time, the values
    assigned to map could be sent two two differen tasks.
    This could cause all sorts of problems, include use-after-free
    and double-free of memory.
    
    Fix this by removing the static declaration so that the map
    pointer is on the stack.
    
    Signed-off-by: Ben Greear <greearb@candelatech.com>
    Cc: stable@kernel.org
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit e5012d1f3861d18c7f3814e757c1c3ab3741dbcd
Author: Andy Adamson <andros@netapp.com>
Date:   Mon Jul 11 17:17:42 2011 -0400

    NFSv4.1: update nfs4_fattr_bitmap_maxsz
    
    Attribute IDs assigned in RFC 5661 now require three bitmaps.
    Fixes hitting a BUG_ON in xdr_shrink_bufhead when getting ACLs.
    
    Signed-off-by: Andy Adamson <andros@netapp.com>
    Cc:stable@kernel.org [2.6.39]
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit b55c59892e1f3b6c7d4b9ccffb4263e1486fb990
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Jul 6 19:58:23 2011 -0400

    SUNRPC: Fix a race between work-queue and rpc_killall_tasks
    
    Since rpc_killall_tasks may modify the rpc_task's tk_action field
    without any locking, we need to be careful when dereferencing it.
    
    Reported-by: Ben Greear <greearb@candelatech.com>
    Tested-by: Ben Greear <greearb@candelatech.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org

commit 2bea038c52e88badbbd5b420c1de918f7f2579e9
Author: Boaz Harrosh <bharrosh@panasas.com>
Date:   Thu Jun 16 11:35:46 2011 -0400

    pnfs: write: Set mds_offset in the generic layer - it is needed by all LDs
    
    In current pnfs tree, all the layouts set mds_offset in their
    .write_pagelist member.
    mds_offset is only used by generic layer and should be handled by it.
    
    This patch is for upstream. It is needed in this -rc series to fix a
    bug in objects layout_commit.
    
    I'll send patches for objects and blocks to be
    squashed into current pnfs tree.
    
    TODO: It looks like the read path needs the same patch.
    
    Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2011-05-13 20:23 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2011-05-13 20:23 UTC (permalink / raw)
  To: Linus Torvalds

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/nfs4filelayout.c    |   27 ++++++++++++++++-----------
 fs/nfs/nfs4filelayout.h    |    2 +-
 fs/nfs/nfs4filelayoutdev.c |   34 +++++++++++++++++-----------------
 fs/nfs/nfs4proc.c          |    6 ++++++
 fs/nfs/pnfs.c              |   34 ++++++++++++++++++++--------------
 fs/nfs/pnfs.h              |    6 +++---
 fs/nfs/read.c              |    4 ++--
 fs/nfs/write.c             |    4 ++--
 include/linux/nfs_xdr.h    |    1 +
 9 files changed, 68 insertions(+), 50 deletions(-)

commit a75b9df9d3bfc3cd1083974c045ae31ce5f3434f
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed May 11 18:00:51 2011 -0400

    NFSv4.1: Ensure that layoutget uses the correct gfp modes
    
    Currently, writebacks may end up recursing back into the filesystem due to
    GFP_KERNEL direct reclaims in the pnfs subsystem.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 2887fe45522843149ccf72e01f43813be4fb36c5
Author: Andy Adamson <andros@netapp.com>
Date:   Wed May 11 01:19:58 2011 -0400

    NFSv4.1: remove pnfs_layout_hdr from pnfs_destroy_all_layouts tmp_list
    
    Prevents an infinite loop as list was never emptied.
    
    Signed-off-by: Andy Adamson <andros@netapp.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit a8a4ae3a899a6c0b4771cc57884800d8b76a6996
Author: Andy Adamson <andros@netapp.com>
Date:   Tue May 3 13:43:03 2011 -0400

    NFSv41: Resend on NFS4ERR_RETRY_UNCACHED_REP
    
    Free the slot and resend the RPC with new session <slot#,seq#>.
    
    For nfs4_async_handle_error, return -EAGAIN and set the task->tk_status to 0
    to restart the async rpc in the rpc_restart_call_prepare state which resets
    the slot.
    
    For nfs4_handle_exception, retrying a call that uses nfs4_call_sync will
    reset the slot via nfs41_call_sync_prepare.
    
    For open/close/lock/locku/delegreturn/layoutcommit/unlink/rename/write
    cachethis is true, so these operations will not trigger an
    NFS4ERR_RETRY_UNCACHED_REP.
    
    Signed-off-by: Andy Adamson <andros@netapp.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] please pull NFS client bugfixes
@ 2011-04-08 18:40 " Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2011-04-08 18:40 UTC (permalink / raw)
  To: Linus Torvalds

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/namespace.c                  |   58 +++++++++++++++--------------------
 fs/nfs/nfs4proc.c                   |    4 +--
 net/sunrpc/auth_gss/gss_krb5_mech.c |    2 +-
 3 files changed, 27 insertions(+), 37 deletions(-)

commit 37adb89fadd65ce47f7e5cfd564938a76b351948
Author: Bryan Schumaker <bjschuma@netapp.com>
Date:   Thu Apr 7 16:02:20 2011 -0400

    NFS: Change initial mount authflavor only when server returns NFS4ERR_WRONGSEC
    
    When attempting an initial mount, we should only attempt other
    authflavors if AUTH_UNIX receives a NFS4ERR_WRONGSEC error.
    This allows other errors to be passed back to userspace programs.
    
    Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 418875900e3de4831c84f86ae4756690dac5be77
Author: Bryan Schumaker <bjschuma@netapp.com>
Date:   Wed Apr 6 14:33:28 2011 -0400

    NFS: Fix a signed vs. unsigned secinfo bug
    
    rpc_authflavor_t is cast from an unsigned int, but the
    initial code tried to use it as a signed int.  I fix
    this by passing an rpc_authflavor_t pointer around, and
    returning signed integers from functions.
    
    Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
    Reported-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 0867659fa3c245bf203d837a82e0f6ea5079c2c5
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Apr 6 10:13:32 2011 -0700

    Revert "net/sunrpc: Use static const char arrays"
    
    This reverts commit 411b5e05617593efebc06241dbc56f42150f2abe.
    
    Olga Kornievskaia reports:
    
    Problem: linux client mounting linux server using rc4-hmac-md5
    enctype. gssd fails with create a context after receiving a reply from
    the server.
    
    Diagnose: putting printout statements in the server kernel and
    kerberos libraries revealed that client and server derived different
    integrity keys.
    
    Server kernel code was at fault due the the commit
    
    [aglo@skydive linux-pnfs]$ git show 411b5e05617593efebc06241dbc56f42150f2abe
    
    Trond: The problem is that since it relies on virt_to_page(), you cannot
    call sg_set_buf() for data in the const section.
    
    Reported-by: Olga Kornievskaia <aglo@citi.umich.edu>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org	[2.6.36+]


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2011-03-14 18:09 " Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2011-03-14 18:09 UTC (permalink / raw)
  To: Linus Torvalds

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/inode.c                           |    7 ++-
 fs/nfs/nfs4_fs.h                         |   10 ++-
 fs/nfs/nfs4filelayoutdev.c               |    4 +
 fs/nfs/nfs4proc.c                        |   91 +++++++++++++++++-------------
 fs/nfs/nfs4state.c                       |   29 +++++++---
 fs/nfs/nfs4xdr.c                         |    4 +-
 fs/nfs/nfsroot.c                         |   29 +++++-----
 fs/nfs/unlink.c                          |    2 +-
 fs/nfs/write.c                           |    2 +
 include/linux/nfs_fs_sb.h                |   10 +--
 include/linux/sunrpc/sched.h             |    1 +
 kernel/sched.c                           |    1 +
 net/sunrpc/sched.c                       |   75 ++++++++++++++++++++-----
 net/sunrpc/xprtrdma/svc_rdma_transport.c |    1 +
 net/sunrpc/xprtsock.c                    |    3 +-
 15 files changed, 178 insertions(+), 91 deletions(-)

commit 53d4737580535e073963b91ce87d4216e434fab5
Author: Chuck Lever <chuck.lever@oracle.com>
Date:   Fri Mar 11 15:31:06 2011 -0500

    NFS: NFSROOT should default to "proto=udp"
    
    There have been a number of recent reports that NFSROOT is no longer
    working with default mount options, but fails only with certain NICs.
    
    Brian Downing <bdowning@lavos.net> bisected to commit 56463e50 "NFS:
    Use super.c for NFSROOT mount option parsing".  Among other things,
    this commit changes the default mount options for NFSROOT to use TCP
    instead of UDP as the underlying transport.
    
    TCP seems less able to deal with NICs that are slow to initialize.
    The system logs that have accompanied reports of problems all show
    that NFSROOT attempts to establish a TCP connection before the NIC is
    fully initialized, and thus the TCP connection attempt fails.
    
    When a TCP connection attempt fails during a mount operation, the
    NFS stack needs to fail the operation.  Usually user space knows how
    and when to retry it.  The network layer does not report a distinct
    error code for this particular failure mode.  Thus, there isn't a
    clean way for the RPC client to see that it needs to retry in this
    case, but not in others.
    
    Because NFSROOT is used in some environments where it is not possible
    to update the kernel command line to specify "udp", the proper thing
    to do is change NFSROOT to use UDP by default, as it did before commit
    56463e50.
    
    To make it easier to see how to change default mount options for
    NFSROOT and to distinguish default settings from mandatory settings,
    I've adjusted a couple of areas to document the specifics.
    
    root_nfs_cat() is also modified to deal with commas properly when
    concatenating strings containing mount option lists.  This keeps
    root_nfs_cat() call sites simpler, now that we may be concatenating
    multiple mount option strings.
    
    Tested-by: Brian Downing <bdowning@lavos.net>
    Tested-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
    Cc: <stable@kernel.org> # 2.6.37
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 57df216bd8c8813a79a6a618e3d2ec937d532b86
Author: Huang Weiyi <weiyi.huang@gmail.com>
Date:   Tue Mar 8 23:11:30 2011 +0000

    nfs4: remove duplicated #include
    
    Remove duplicated #include('s) in
      fs/nfs/nfs4proc.c
    
    Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit f9feab1e180d1392f2f59d692826c6da2e57adf4
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Mar 9 16:12:46 2011 -0500

    NFSv4: nfs4_state_mark_reclaim_nograce() should be static
    
    There are no more external users of nfs4_state_mark_reclaim_nograce() or
    nfs4_state_mark_reclaim_reboot(), so mark them as static.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit ecac799a5ecc364006f0db6f2db15e77ed4d63e2
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Mar 9 16:00:56 2011 -0500

    NFSv4: Fix the setlk error handler
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit b4410c2f7f775b03da31566c05bb8d2383c7dc27
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Mar 9 16:00:55 2011 -0500

    NFSv4.1: Fix the handling of the SEQUENCE status bits
    
    We want SEQUENCE status bits to be handled by the state manager in order
    to avoid threading issues.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 0400a6b0cb756f976bae32ae8db47bfa9853897c
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Mar 9 16:00:53 2011 -0500

    NFSv4/4.1: Fix nfs4_schedule_state_recovery abuses
    
    nfs4_schedule_state_recovery() should only be used when we need to force
    the state manager to check the lease. If we just want to start the
    state manager in order to handle a state recovery situation, we should be
    using nfs4_schedule_state_manager().
    
    This patch fixes the abuses of nfs4_schedule_state_recovery() by replacing
    its use with a set of helper functions that do the right thing.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit c34c32ea97718bb24fc06158733580003ba89211
Author: Andy Adamson <andros@netapp.com>
Date:   Wed Mar 9 13:13:46 2011 -0500

    NFSv4.1 reclaim complete must wait for completion
    
    Signed-off-by: Andy Adamson <andros@netapp.com>
    [Trond: fix whitespace errors]
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 114f64b5f24abac33a42f4f1856eb3a9766d497e
Author: Andy Adamson <andros@netapp.com>
Date:   Wed Mar 9 13:13:45 2011 -0500

    NFSv4: remove duplicate clientid in struct nfs_client
    
    Signed-off-by: Andy Adamson <andros@netapp.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 7d6d63d6427090cbb1d282364b65b12634ca59bd
Author: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
Date:   Wed Mar 9 13:13:44 2011 -0500

    NFSv4.1: Retry CREATE_SESSION on NFS4ERR_DELAY
    
    Fix bug where we currently retry the EXCHANGEID call again, eventhough
    we already have a valid clientid.  Instead, delay and retry the CREATE_SESSION
    call.
    
    Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 4cea288aaf0e11647880cc487350b1dc45d9febc
Author: Ben Hutchings <bhutchings@solarflare.com>
Date:   Tue Feb 22 21:54:34 2011 +0000

    sunrpc: Propagate errors from xs_bind() through xs_create_sock()
    
    xs_create_sock() is supposed to return a pointer or an ERR_PTR-encoded
    error, but it currently returns 0 if xs_bind() fails.
    
    Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
    Cc: stable@kernel.org [v2.6.37]
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 3fa0b4e201d254b52a251fa348bd53e53000cff6
Author: Frank Filz <ffilzlnx@us.ibm.com>
Date:   Thu Dec 2 19:31:23 2010 +0000

    (try3-resend) Fix nfs_compat_user_ino64 so it doesn't cause problems if bit 31 or 63 are set in fileid
    
    The problem was use of an int32, which when converted to a uint64
    is sign extended resulting in a fileid that doesn't fit in 32 bits
    even though the intent of the function is to fit the fileid into
    32 bits.
    
    Signed-off-by: Frank Filz <ffilzlnx@us.ibm.com>
    Reviewed-by: Jeff Layton <jlayton@redhat.com>
    [Trond: Added an include for compat.h]
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 43b7c3f051dea504afccc39bcb56d8e26c2e0b77
Author: Jovi Zhang <bookjovi@gmail.com>
Date:   Wed Mar 2 23:19:37 2011 +0000

    nfs: fix compilation warning
    
    this commit fix compilation warning as following:
    linux-2.6/fs/nfs/nfs4proc.c:3265: warning: comparison of distinct pointer types lacks a cast
    
    Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit b9f810570d9cc13177128e11a74e22d37aa68a1a
Author: Stanislav Fomichev <kernel@fomichev.me>
Date:   Sat Feb 5 23:13:01 2011 +0000

    nfs: add kmalloc return value check in decode_and_add_ds
    
    add kmalloc return value check in decode_and_add_ds
    
    Signed-off-by: Stanislav Fomichev <kernel@fomichev.me>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit a5e502681007779d4762fb3ef7e80a3ecd1cfe6b
Author: Jesper Juhl <jj@chaosbits.net>
Date:   Sat Jan 22 21:40:20 2011 +0000

    SUNRPC: Remove resource leak in svc_rdma_send_error()
    
    We leak the memory allocated to 'ctxt' when we return after
    'ib_dma_mapping_error()' returns !=0.
    
    Signed-off-by: Jesper Juhl <jj@chaosbits.net>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit d2224e7afbf2a6556f4f8f25bc0e96d99ec4d2bd
Author: Jeff Layton <jlayton@redhat.com>
Date:   Sun Mar 6 17:14:13 2011 +0000

    nfs: close NFSv4 COMMIT vs. CLOSE race
    
    I've been adding in more artificial delays in the NFSv4 commit and close
    codepaths to uncover races. The kernel I'm testing has the patch to
    close the race in __rpc_wait_for_completion_task that's in Trond's
    cthon2011 branch. The reproducer I've been using does this in a loop:
    
    	mkdir("DIR");
    	fd = open("DIR/FILE", O_WRONLY|O_CREAT|O_EXCL, 0644);
    	write(fd, "abcdefg", 7);
    	close(fd);
    	unlink("DIR/FILE");
    	rmdir("DIR");
    
    The above reproducer shouldn't result in any silly-renaming. However,
    when I add a "msleep(100)" just after the nfs_commit_clear_lock call in
    nfs_commit_release, I can almost always force one to occur. If I can
    force it to occur with that, then it can happen without that delay
    given the right timing.
    
    nfs_commit_inode waits for the NFS_INO_COMMIT bit to clear when called
    with FLUSH_SYNC set. nfs_commit_rpcsetup on the other hand does not wait
    for the task to complete before putting its reference to it, so the last
    reference get put in rpc_release task and gets queued to a workqueue.
    
    In this situation, the last open context reference may be put by the
    COMMIT release instead of the close() syscall. The close() syscall
    returns too quickly and the unlink runs while the d_count is still
    high since the COMMIT release hasn't put its dentry reference yet.
    
    Fix this by having rpc_commit_rpcsetup wait for the RPC call to complete
    before putting the task reference when FLUSH_SYNC is set. With this, the
    last reference is put by the process that's initiating the FLUSH_SYNC
    commit and the race is closed.
    
    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit bf294b41cefcb22fc3139e0f42c5b3f06728bd5e
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Mon Feb 21 11:05:41 2011 -0800

    SUNRPC: Close a race in __rpc_wait_for_completion_task()
    
    Although they run as rpciod background tasks, under normal operation
    (i.e. no SIGKILL), functions like nfs_sillyrename(), nfs4_proc_unlck()
    and nfs4_do_close() want to be fully synchronous. This means that when we
    exit, we want all references to the rpc_task to be gone, and we want
    any dentry references etc. held by that task to be released.
    
    For this reason these functions call __rpc_wait_for_completion_task(),
    followed by rpc_put_task() in the expectation that the latter will be
    releasing the last reference to the rpc_task, and thus ensuring that the
    callback_ops->rpc_release() has been called synchronously.
    
    This patch fixes a race which exists due to the fact that
    rpciod calls rpc_complete_task() (in order to wake up the callers of
    __rpc_wait_for_completion_task()) and then subsequently calls
    rpc_put_task() without ensuring that these two steps are done atomically.
    
    In order to avoid adding new spin locks, the patch uses the existing
    waitqueue spin lock to order the rpc_task reference count releases between
    the waiting process and rpciod.
    The common case where nobody is waiting for completion is optimised for by
    checking if the RPC_TASK_ASYNC flag is cleared and/or if the rpc_task
    reference count is 1: in those cases we drop trying to grab the spin lock,
    and immediately free up the rpc_task.
    
    Those few processes that need to put the rpc_task from inside an
    asynchronous context and that do not care about ordering are given a new
    helper: rpc_put_task_async().
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2010-11-26 18:56 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2010-11-26 18:56 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-nfs, linux-kernel

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/dir.c            |   62 +++++++++++++++++++++++++---------------------
 fs/nfs/direct.c         |    2 +-
 fs/nfs/internal.h       |    9 +++++++
 fs/nfs/nfs2xdr.c        |    4 ++-
 fs/nfs/nfs3xdr.c        |    4 ++-
 fs/nfs/nfs4xdr.c        |    6 ++++-
 include/linux/nfs_xdr.h |    1 +
 net/sunrpc/clnt.c       |   24 +++++++++++-------
 8 files changed, 71 insertions(+), 41 deletions(-)

commit 0b26a0bf6ff398185546432420bb772bcfdf8d94
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat Nov 20 14:26:44 2010 -0500

    NFS: Ensure we return the dirent->d_type when it is known
    
    Store the dirent->d_type in the struct nfs_cache_array_entry so that we
    can use it in getdents() calls.
    
    This fixes a regression with the new readdir code.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 3020093f578fb6c9acc6914dfd887a1ebd1db659
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat Nov 20 15:18:22 2010 -0500

    NFS: Correct the array bound calculation in nfs_readdir_add_to_array
    
    It looks as if the array size calculation in MAX_READDIR_ARRAY does not
    take the alignment of struct nfs_cache_array_entry into account.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit ece0b4233b6b915d1f63add2bd9f2733aec6317a
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat Nov 20 13:55:33 2010 -0500

    NFS: Don't ignore errors from nfs_do_filldir()
    
    We should ignore the errors from the filldir callback, and just interpret
    them as meaning we should exit, however we should definitely pass back
    ENOMEM errors.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 85f8607e163f8d281fb407357279cb4ac6df12e6
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat Nov 20 13:24:49 2010 -0500

    NFS: Fix the error handling in "uncached_readdir()"
    
    Currently, uncached_readdir() is broken because if fails to handle
    the results from nfs_readdir_xdr_to_array() correctly.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 7a8e1dc34f52fd2927dbf7e520d7cd8eadc51336
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat Nov 20 13:24:46 2010 -0500

    NFS: Fix a page leak in uncached_readdir()
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit e7c58e974a0318fcca5368e7b3570e10e9ae9028
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat Nov 20 13:22:24 2010 -0500

    NFS: Fix a page leak in nfs_do_filldir()
    
    nfs_do_filldir() must always free desc->page when it is done, otherwise
    we end up leaking the page.
    
    Also remove unused variable 'dentry'.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 5c346854d8ce6ca91931f8fc9177934257a667d0
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat Nov 20 12:43:45 2010 -0500

    NFS: Assume eof if the server returns no readdir records
    
    Some servers are known to be buggy w.r.t. this. Deal with them...
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 463a376eae1c92a66c912af539bfd4bbefa37673
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat Nov 20 12:22:20 2010 -0500

    NFS: Buffer overflow in ->decode_dirent() should not be fatal
    
    Overflowing the buffer in the readdir ->decode_dirent() should not lead to
    a fatal error, but rather to an attempt to reread the record in question.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit b47d19de2c714020ba8f5545a6e7d4968f37eb45
Author: Arun Bharadwaj <arun@linux.vnet.ibm.com>
Date:   Thu Nov 18 10:36:43 2010 +0000

    Pure nfs client performance using odirect.
    
    When an application opens a file with O_DIRECT flag, if the size of
    the data that is written is equal to wsize, the client sends a
    WRITE RPC with stable flag set to UNSTABLE followed by a single
    COMMIT RPC rather than sending a single WRITE RPC with the stable
    flag set to FILE_SYNC. This a bug.
    
    Patch to fix this.
    
    Signed-off-by: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 5fc43978a79e8021c189660ab63249fd29c5fb32
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat Nov 20 11:13:31 2010 -0500

    SUNRPC: Fix an infinite loop in call_refresh/call_refreshresult
    
    If the rpcauth_refreshcred() call returns an error other than
    EACCES, ENOMEM or ETIMEDOUT, we currently end up looping forever
    between call_refresh and call_refreshresult.
    
    The correct thing to do here is to exit on all errors except
    EAGAIN and ETIMEDOUT, for which case we retry 3 times, then
    return EACCES.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes...
@ 2010-05-26 19:42 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2010-05-26 19:42 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-nfs, linux-kernel

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/dir.c          |    1 +
 fs/nfs/write.c        |   20 ++++++++++++++++----
 net/sunrpc/xprtsock.c |   29 ++++++++++++++++++-----------
 3 files changed, 35 insertions(+), 15 deletions(-)

commit 0522f6adedd2736cbca3c0e16ca51df668993eee
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed May 26 08:42:24 2010 -0400

    NFS: Fix another nfs_wb_page() deadlock
    
    J.R. Okajima reports that the call to sync_inode() in nfs_wb_page() can
    deadlock with other writeback flush calls. It boils down to the fact
    that we cannot ever call writeback_single_inode() while holding a page
    lock (even if we do set nr_to_write to zero) since another process may
    already be waiting in the call to do_writepages(), and so will deny us
    the I_SYNC lock.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit c5efa5fc91f1f6d1d47e65f39e7ec6d1157c777d
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed May 26 08:42:11 2010 -0400

    NFS: Ensure that we mark the inode as dirty if we exit early from commit
    
    If we exit from nfs_commit_inode() without ensuring that the COMMIT rpc
    call has been completed, we must re-mark the inode as dirty. Otherwise,
    future calls to sync_inode() with the WB_SYNC_ALL flag set will fail to
    ensure that the data is on the disk.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 59844a9bd73e084b0ffefc0e13226098e28c71ad
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed May 26 08:42:24 2010 -0400

    NFS: Fix a lock imbalance typo in nfs_access_cache_shrinker
    
    Commit 9c7e7e23371e629dbb3b341610a418cdf1c19d91 (NFS: Don't call iput() in
    nfs_access_cache_shrinker) unintentionally removed the spin unlock for the
    inode->i_lock.
    
    Reported-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 0a68b0bed08eeb7ec62e0125f17856b1ccb1ea4b
Author: J. Bruce Fields <bfields@citi.umich.edu>
Date:   Wed May 26 08:42:24 2010 -0400

    sunrpc: fix leak on error on socket xprt setup
    
    Also collect exit code together while we're at it.
    
    Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
    Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>



^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes...
@ 2010-05-07  2:22 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2010-05-07  2:22 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-nfs, linux-kernel, David Howells, Paul E. McKenney

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/delegation.c |   86 ++++++++++++++++++++++++++++++---------------------
 1 files changed, 51 insertions(+), 35 deletions(-)

commit 17d2c0a0c4d4e074f0a2a5c0090ff6d88f5e1d44
Author: David Howells <dhowells@redhat.com>
Date:   Sat May 1 12:37:18 2010 -0400

    NFS: Fix RCU issues in the NFSv4 delegation code
    
    Fix a number of RCU issues in the NFSv4 delegation code.
    
     (1) delegation->cred doesn't need to be RCU protected as it's essentially an
         invariant refcounted structure.
    
         By the time we get to nfs_free_delegation(), the delegation is being
         released, so no one else should be attempting to use the saved
         credentials, and they can be cleared.
    
         However, since the list of delegations could still be under traversal at
         this point by such as nfs_client_return_marked_delegations(), the cred
         should be released in nfs_do_free_delegation() rather than in
         nfs_free_delegation().  Simply using rcu_assign_pointer() to clear it is
         insufficient as that doesn't stop the cred from being destroyed, and nor
         does calling put_rpccred() after call_rcu(), given that the latter is
         asynchronous.
    
     (2) nfs_detach_delegation_locked() and nfs_inode_set_delegation() should use
         rcu_derefence_protected() because they can only be called if
         nfs_client::cl_lock is held, and that guards against anyone changing
         nfsi->delegation under it.  Furthermore, the barrier imposed by
         rcu_dereference() is superfluous, given that the spin_lock() is also a
         barrier.
    
     (3) nfs_detach_delegation_locked() is now passed a pointer to the nfs_client
         struct so that it can issue lockdep advice based on clp->cl_lock for (2).
    
     (4) nfs_inode_return_delegation_noreclaim() and nfs_inode_return_delegation()
         should use rcu_access_pointer() outside the spinlocked region as they
         merely examine the pointer and don't follow it, thus rendering unnecessary
         the need to impose a partial ordering over the one item of interest.
    
         These result in an RCU warning like the following:
    
    [ INFO: suspicious rcu_dereference_check() usage. ]
    ---------------------------------------------------
    fs/nfs/delegation.c:332 invoked rcu_dereference_check() without protection!
    
    other info that might help us debug this:
    
    rcu_scheduler_active = 1, debug_locks = 0
    2 locks held by mount.nfs4/2281:
     #0:  (&type->s_umount_key#34){+.+...}, at: [<ffffffff810b25b4>] deactivate_super+0x60/0x80
     #1:  (iprune_sem){+.+...}, at: [<ffffffff810c332a>] invalidate_inodes+0x39/0x13a
    
    stack backtrace:
    Pid: 2281, comm: mount.nfs4 Not tainted 2.6.34-rc1-cachefs #110
    Call Trace:
     [<ffffffff8105149f>] lockdep_rcu_dereference+0xaa/0xb2
     [<ffffffffa00b4591>] nfs_inode_return_delegation_noreclaim+0x5b/0xa0 [nfs]
     [<ffffffffa0095d63>] nfs4_clear_inode+0x11/0x1e [nfs]
     [<ffffffff810c2d92>] clear_inode+0x9e/0xf8
     [<ffffffff810c3028>] dispose_list+0x67/0x10e
     [<ffffffff810c340d>] invalidate_inodes+0x11c/0x13a
     [<ffffffff810b1dc1>] generic_shutdown_super+0x42/0xf4
     [<ffffffff810b1ebe>] kill_anon_super+0x11/0x4f
     [<ffffffffa009893c>] nfs4_kill_super+0x3f/0x72 [nfs]
     [<ffffffff810b25bc>] deactivate_super+0x68/0x80
     [<ffffffff810c6744>] mntput_no_expire+0xbb/0xf8
     [<ffffffff810c681b>] release_mounts+0x9a/0xb0
     [<ffffffff810c689b>] put_mnt_ns+0x6a/0x79
     [<ffffffffa00983a1>] nfs_follow_remote_path+0x5a/0x146 [nfs]
     [<ffffffffa0098334>] ? nfs_do_root_mount+0x82/0x95 [nfs]
     [<ffffffffa00985a9>] nfs4_try_mount+0x75/0xaf [nfs]
     [<ffffffffa0098874>] nfs4_get_sb+0x291/0x31a [nfs]
     [<ffffffff810b2059>] vfs_kern_mount+0xb8/0x177
     [<ffffffff810b2176>] do_kern_mount+0x48/0xe8
     [<ffffffff810c810b>] do_mount+0x782/0x7f9
     [<ffffffff810c8205>] sys_mount+0x83/0xbe
     [<ffffffff81001eeb>] system_call_fastpath+0x16/0x1b
    
    Also on:
    
    fs/nfs/delegation.c:215 invoked rcu_dereference_check() without protection!
     [<ffffffff8105149f>] lockdep_rcu_dereference+0xaa/0xb2
     [<ffffffffa00b4223>] nfs_inode_set_delegation+0xfe/0x219 [nfs]
     [<ffffffffa00a9c6f>] nfs4_opendata_to_nfs4_state+0x2c2/0x30d [nfs]
     [<ffffffffa00aa15d>] nfs4_do_open+0x2a6/0x3a6 [nfs]
     ...
    
    And:
    
    fs/nfs/delegation.c:40 invoked rcu_dereference_check() without protection!
     [<ffffffff8105149f>] lockdep_rcu_dereference+0xaa/0xb2
     [<ffffffffa00b3bef>] nfs_free_delegation+0x3d/0x6e [nfs]
     [<ffffffffa00b3e71>] nfs_do_return_delegation+0x26/0x30 [nfs]
     [<ffffffffa00b406a>] __nfs_inode_return_delegation+0x1ef/0x1fe [nfs]
     [<ffffffffa00b448a>] nfs_client_return_marked_delegations+0xc9/0x124 [nfs]
     ...
    
    Signed-off-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 8f649c376254755f2261a693b3d48d09126218dc
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Sat May 1 12:36:18 2010 -0400

    NFSv4: Fix the locking in nfs_inode_reclaim_delegation()
    
    Ensure that we correctly rcu-dereference the delegation itself, and that we
    protect against removal while we're changing the contents.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Signed-off-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>



^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2010-04-29 16:48 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2010-04-29 16:48 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-nfs, linux-kernel

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/client.c        |    2 +
 fs/nfs/dir.c           |    2 +-
 fs/nfs/nfs4proc.c      |    5 +++-
 fs/nfs/super.c         |    3 +-
 fs/nfs/write.c         |   55 +++++++++++++++++++++++++++++++----------------
 include/linux/nfs_fs.h |    1 +
 net/sunrpc/auth.c      |    2 +-
 7 files changed, 47 insertions(+), 23 deletions(-)

commit 9699eda6bc1f708a28acb716e1477aa351362fe2
Author: Xiaotian Feng <dfeng@redhat.com>
Date:   Thu Apr 22 18:56:17 2010 +0800

    nfs: fix memory leak in nfs_get_sb with CONFIG_NFS_V4
    
    With CONFIG_NFS_V4 and data version 4, nfs_get_sb will allocate memory for
    export_path in nfs4_validate_text_mount_data, so we need to free it then.
    This is addressed in following kmemleak report:
    
    unreferenced object 0xffff88016bf48a50 (size 16):
      comm "mount.nfs", pid 22567, jiffies 4651574704 (age 175471.200s)
      hex dump (first 16 bytes):
        2f 6f 70 74 2f 77 6f 72 6b 00 6b 6b 6b 6b 6b a5  /opt/work.kkkkk.
      backtrace:
        [<ffffffff814b34f9>] kmemleak_alloc+0x60/0xa7
        [<ffffffff81102c76>] kmemleak_alloc_recursive.clone.5+0x1b/0x1d
        [<ffffffff811046b3>] __kmalloc_track_caller+0x18f/0x1b7
        [<ffffffff810e1b08>] kstrndup+0x37/0x54
        [<ffffffffa0336971>] nfs_parse_devname+0x152/0x204 [nfs]
        [<ffffffffa0336af3>] nfs4_validate_text_mount_data+0xd0/0xdc [nfs]
        [<ffffffffa0338deb>] nfs_get_sb+0x325/0x736 [nfs]
        [<ffffffff81113671>] vfs_kern_mount+0xbd/0x17c
        [<ffffffff81113798>] do_kern_mount+0x4d/0xed
        [<ffffffff81129a87>] do_mount+0x787/0x7fe
        [<ffffffff81129b86>] sys_mount+0x88/0xc2
        [<ffffffff81009b42>] system_call_fastpath+0x16/0x1b
    
    Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
    Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: Chuck Lever <chuck.lever@oracle.com>
    Cc: Benny Halevy <bhalevy@panasas.com>
    Cc: Al Viro <viro@ZenIV.linux.org.uk>
    Cc: Andy Adamson <andros@netapp.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit acf82b85a70f39786e3cbb1ffed8655bcc972424
Author: Dan Carpenter <error27@gmail.com>
Date:   Thu Apr 22 11:28:39 2010 +0200

    nfs: fix some issues in nfs41_proc_reclaim_complete()
    
    The original code passed an ERR_PTR() to rpc_put_task() and instead of
    returning zero on success it returned -ENOMEM.
    
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit ba8b06e67ed7a560b0e7c80091bcadda4f4727a5
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue Apr 27 18:33:54 2010 -0400

    NFS: Ensure that nfs_wb_page() waits for Pg_writeback to clear
    
    Neil Brown reports that he is seeing the BUG_ON(ret == 0) trigger in
    nfs_page_async_flush. According to the trace in
         https://bugzilla.novell.com/show_bug.cgi?id=599628
    the problem appears to be due to nfs_wb_page() not waiting for the
    PG_writeback flag to clear.
    
    There is a ditto problem in nfs_wb_page_cancel()
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 71d0a6112a363e703e383ae5b12c492485c39701
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Apr 22 15:35:57 2010 -0400

    NFS: Fix an unstable write data integrity race
    
    Commit 2c61be0a9478258f77b66208a0c4b1f5f8161c3c (NFS: Ensure that the WRITE
    and COMMIT RPC calls are always uninterruptible) exposed a race on file
    close. In order to ensure correct close-to-open behaviour, we want to wait
    for all outstanding background commit operations to complete.
    
    This patch adds an inode flag that indicates if a commit operation is under
    way, and provides a mechanism to allow ->write_inode() to wait for its
    completion if this is a data integrity flush.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit cdd29ecfcb9554132cd94b82ae8b69ba37adb3b5
Author: Dan Carpenter <error27@gmail.com>
Date:   Thu Apr 22 15:35:56 2010 -0400

    nfs: testing for null instead of ERR_PTR()
    
    nfs_path() returns an ERR_PTR(), it doesn't return null.
    
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 356e76b855bdbfd8d1c5e75bcf0c6bf0dfe83496
Author: Chuck Lever <chuck.lever@oracle.com>
Date:   Thu Apr 22 15:35:56 2010 -0400

    NFS: rsize and wsize settings ignored on v4 mounts
    
    NFSv4 mounts ignore the rsize and wsize mount options, and always use
    the default transfer size for both.  This seems to be because all
    NFSv4 mounts are now cloned, and the cloning logic doesn't copy the
    rsize and wsize settings from the parent nfs_server.
    
    I tested Fedora's 2.6.32.11-99 and it seems to have this problem as
    well, so I'm guessing that .33, .32, and perhaps older kernels have
    this issue as well.
    
    Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
    Cc: Stable <stable@kernel.org>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 1f063d2cdf332a8a5722006b1345d15d16007c6e
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Apr 22 15:35:55 2010 -0400

    NFSv4: Don't attempt an atomic open if the file is a mountpoint
    
    Fix https://bugzilla.kernel.org/show_bug.cgi?id=15789
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 3d7b08945e54a3a5358d5890240619a013cb7388
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Apr 22 15:35:55 2010 -0400

    SUNRPC: Fix a bug in rpcauth_prune_expired
    
    Don't want to evict a credential if cred->cr_expire == jiffies, since that
    means that it was just placed on the cred_unused list. We therefore need to
    use time_in_range() rather than time_in_range_open().
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>



^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2010-03-23 17:00 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2010-03-23 17:00 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-nfs, linux-kernel

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/file.c                  |    3 ++-
 fs/nfs/nfs4xdr.c               |    2 ++
 include/linux/sunrpc/bc_xprt.h |    5 ++++-
 net/sunrpc/auth_gss/auth_gss.c |    5 ++---
 net/sunrpc/bc_svc.c            |   15 ---------------
 net/sunrpc/clnt.c              |    1 +
 net/sunrpc/rpc_pipe.c          |    2 ++
 net/sunrpc/xprt.c              |   22 +++++++++-------------
 net/sunrpc/xprtsock.c          |    3 ---
 9 files changed, 22 insertions(+), 36 deletions(-)

commit 556ae3bb32cabe483375b857dda1322384c57b65
Author: Jeff Layton <jlayton@redhat.com>
Date:   Sun Mar 21 12:10:36 2010 -0400

    NFS: don't try to decode GETATTR if DELEGRETURN returned error
    
    The reply parsing code attempts to decode the GETATTR response even if
    the DELEGRETURN portion of the compound returned an error. The GETATTR
    response won't actually exist if that's the case and we're asking the
    parser to read past the end of the response.
    
    This bug is fairly benign. The parser catches this without reading past
    the end of the response and decode_getfattr returns -EIO. Earlier
    kernels however had decode_op_hdr using the READ_BUF macro, and this
    bug would make this printk pop any time the client got an error from
    a delegreturn:
    
    kernel: decode_op_hdr: reply buffer overflowed in line XXXX
    
    More recent kernels seem to have replaced this printk with a dprintk.
    
    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit f1f0abe192a72e75d7c59972e30784d043fd8d73
Author: Dan Carpenter <error27@gmail.com>
Date:   Sun Mar 21 12:10:34 2010 -0400

    sunrpc: handle allocation errors from __rpc_lookup_create()
    
    __rpc_lookup_create() can return ERR_PTR(-ENOMEM).
    
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org

commit ff0901f8036a1586037c30a365c9666e946af0f1
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Fri Mar 19 16:17:45 2010 -0400

    SUNRPC: Fix the return value of rpc_run_bc_task()
    
    Currently rpc_run_bc_task() will return NULL if the task allocation failed.
    However the only caller is bc_send, which assumes that the return value
    will be an ERR_PTR.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit c9acb42ef1904d15d0fb315061cefbe638f67f3a
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Fri Mar 19 15:36:22 2010 -0400

    SUNRPC: Fix a use after free bug with the NFSv4.1 backchannel
    
    The ->release_request() callback was designed to allow the transport layer
    to do housekeeping after the RPC call is done. It cannot be used to free
    the request itself, and doing so leads to a use-after-free bug in
    xprt_release().
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit cdead7cf12896c0e50a8be2e52de52c364603095
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Fri Mar 19 15:36:22 2010 -0400

    SUNRPC: Fix a potential memory leak in auth_gss
    
    The function alloc_enc_pages() currently fails to release the pointer
    rqstp->rq_enc_pages in the error path.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Acked-by: J. Bruce Fields <bfields@citi.umich.edu>
    Cc: stable@kernel.org

commit d812e575822a2b7ab1a7cadae2571505ec6ec2bd
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Fri Mar 19 13:55:17 2010 -0400

    NFS: Prevent another deadlock in nfs_release_page()
    
    We should not attempt to free the page if __GFP_FS is not set. Otherwise we
    can deadlock as per
    
      http://bugzilla.kernel.org/show_bug.cgi?id=15578
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org



^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes...
@ 2010-03-17 21:55 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2010-03-17 21:55 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-nfs, linux-kernel

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/callback_xdr.c |    1 +
 fs/nfs/delegation.h   |    6 ++++++
 fs/nfs/dir.c          |    2 +-
 fs/nfs/inode.c        |    2 +-
 fs/nfs/nfs4proc.c     |    1 +
 fs/nfs/pagelist.c     |   23 +++++++++++++----------
 fs/nfs/super.c        |   25 ++++++++++++++++++++-----
 net/sunrpc/xprtsock.c |    8 ++------
 8 files changed, 45 insertions(+), 23 deletions(-)

commit cfbc0683af235106e7dabe92003870b82ad6f0ba
Author: NeilBrown <neilb@suse.de>
Date:   Thu Mar 11 11:20:17 2010 +1100

    NFS: ensure bdi_unregister is called on mount failure.
    
    bdi_unregister is called by nfs_put_super which is only called by
    generic_shutdown_super if ->s_root is not NULL.  So if we error out
    in a circumstance where we called nfs_bdi_register (i.e. server !=
    NULL) but have not set s_root, then we need to call bdi_unregister
    explicitly in nfs_get_sb and various other *_get_sb() functions.
    
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit bb6fbc4548b9ae7ebbd06ef72f00229df259d217
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Mar 11 09:19:35 2010 -0500

    NFS: Avoid a deadlock in nfs_release_page
    
    J.R. Okajima reports the following deadlock:
    
    INFO: task kswapd0:305 blocked for more than 120 seconds.
    "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
    kswapd0       D 0000000000000001     0   305      2 0x00000000
     ffff88001f21d4f0 0000000000000046 ffff88001fdea680 ffff88001f21c000
     ffff88001f21dfd8 ffff88001f21c000 ffff88001f21dfd8 ffff88001f21dfd8
     ffff88001fdea040 0000000000014c00 0000000000000001 ffff88001fdea040
    Call Trace:
     [<ffffffff8146155d>] io_schedule+0x4d/0x70
     [<ffffffff810d2be5>] sync_page+0x65/0xa0
     [<ffffffff81461b12>] __wait_on_bit_lock+0x52/0xb0
     [<ffffffff810d2b80>] ? sync_page+0x0/0xa0
     [<ffffffff810d2b64>] __lock_page+0x64/0x70
     [<ffffffff81070ce0>] ? wake_bit_function+0x0/0x40
     [<ffffffff810df1d4>] truncate_inode_pages_range+0x344/0x4a0
     [<ffffffff810df340>] truncate_inode_pages+0x10/0x20
     [<ffffffff8112cbfe>] generic_delete_inode+0x15e/0x190
     [<ffffffff8112cc8d>] generic_drop_inode+0x5d/0x80
     [<ffffffff8112bb88>] iput+0x78/0x80
     [<ffffffff811bc908>] nfs_dentry_iput+0x38/0x50
     [<ffffffff811285f4>] dentry_iput+0x84/0x110
     [<ffffffff811286ae>] d_kill+0x2e/0x60
     [<ffffffff8112912a>] dput+0x7a/0x170
     [<ffffffff8111e925>] path_put+0x15/0x40
     [<ffffffff811c3a44>] __put_nfs_open_context+0xa4/0xb0
     [<ffffffff811cb5d0>] ? nfs_free_request+0x0/0x50
     [<ffffffff811c3b0b>] put_nfs_open_context+0xb/0x10
     [<ffffffff811cb5f9>] nfs_free_request+0x29/0x50
     [<ffffffff81234b7e>] kref_put+0x8e/0xe0
     [<ffffffff811cb594>] nfs_release_request+0x14/0x20
     [<ffffffff811cf769>] nfs_find_and_lock_request+0x89/0xa0
     [<ffffffff811d1180>] nfs_wb_page+0x80/0x110
     [<ffffffff811c0770>] nfs_release_page+0x70/0x90
     [<ffffffff810d18ee>] try_to_release_page+0x5e/0x80
     [<ffffffff810e1178>] shrink_page_list+0x638/0x860
     [<ffffffff810e19de>] shrink_zone+0x63e/0xc40
    
    We can fix this by making the call to put_nfs_open_context() happen when we
    actually remove the write request from the inode (which is done by the
    nfsiod thread in this case).
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org

commit b4d2314bb88b07e5a04e6c75b442a1dfcd60e340
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Mar 10 15:21:44 2010 -0500

    NFSv4: Don't ignore the NFS_INO_REVAL_FORCED flag in nfs_revalidate_inode()
    
    If the NFS_INO_REVAL_FORCED flag is set, that means that we don't yet have
    an up to date attribute cache. Even if we hold a delegation, we must
    put a GETATTR on the wire.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org

commit 49697ee79242d5f8ac88f1ebc62e583d16bcc687
Author: Steve Dickson <SteveD@redhat.com>
Date:   Tue Oct 13 16:07:33 2009 -0400

    nfs4: Make the v4 callback service hidden
    
    To avoid hangs in the svc_unregister(), on version 4 mounts
    (and unmounts), when rpcbind is not running, make the nfs4 callback
    program an 'hidden' service by setting the 'vs_hidden' flag in the
    nfs4_callback_version structure.
    
    Signed-off-by: Steve Dickson <steved@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 7dd08a570dcf45d52155996fee688405635ee481
Author: Dan Carpenter <error27@gmail.com>
Date:   Sat Mar 6 15:02:22 2010 +0300

    nfs: fix unlikely memory leak
    
    I'll admit that it's unlikely for the first allocation to fail and
    the second one to succeed.  I won't be offended if you ignore this
    patch.
    
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 5fe46e9d733f19a880ef7e516002bd4c2b833e14
Author: Bian Naimeng <biannm@cn.fujitsu.com>
Date:   Mon Mar 8 14:49:01 2010 +0800

    rpc client can not deal with ENOSOCK, so translate it into ENOCONN
    
    If NFSv4 client send a request before connect, or the old connection was broken
    because a ETIMEOUT error catched by call_status, ->send_request will return
    ENOSOCK, but rpc layer can not deal with it, so make sure ->send_request can
    translate ENOSOCK into ENOCONN.
    
    Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>



^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2010-02-04 19:10 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2010-02-04 19:10 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, linux-nfs

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/file.c      |    2 +
 fs/nfs/inode.c     |    4 ++-
 fs/nfs/nfs4_fs.h   |    2 +
 fs/nfs/nfs4proc.c  |   78 ++++++++++++++++++++++++++++++++++++++-------------
 fs/nfs/nfs4state.c |    2 +-
 fs/nfs/pagelist.c  |   17 ++++++-----
 fs/nfs/super.c     |   15 +++++++++-
 fs/nfs/sysctl.c    |    2 +
 fs/nfs/write.c     |    3 +-
 9 files changed, 93 insertions(+), 32 deletions(-)

commit 9b4b351346b41d923d69adec865814fdaac4dba9
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Feb 3 08:27:35 2010 -0500

    NFS: Don't clobber the attribute type in nfs_update_inode()
    
    If the NFS_ATTR_FATTR_TYPE field isn't set in fattr->valid, then we should
    not set the S_IFMT part of inode->i_mode.
    
    Reported-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 387c149b54b4321cbc790dadbd4f8eedb5a90468
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Feb 3 08:27:35 2010 -0500

    NFS: Fix a umount race
    
    Ensure that we unregister the bdi before kill_anon_super() calls
    ida_remove() on our device name.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org

commit 9f557cd8073104b39528794d44e129331ded649f
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Wed Feb 3 08:27:22 2010 -0500

    NFS: Fix an Oops when truncating a file
    
    The VM/VFS does not allow mapping->a_ops->invalidatepage() to fail.
    Unfortunately, nfs_wb_page_cancel() may fail if a fatal signal occurs.
    Since the NFS code assumes that the page stays mapped for as long as the
    writeback is active, we can end up Oopsing (among other things).
    
    The only safe fix here is to convert nfs_wait_on_request(), so as to make
    it uninterruptible (as is already the case with wait_on_page_writeback()).
    
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org

commit a2c0b9e291208f65221a0ad8a0c80a377707d480
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue Jan 26 15:42:47 2010 -0500

    NFS: Ensure that we handle NFS4ERR_STALE_STATEID correctly
    
    Even if the server is crazy, we should be able to mark the stateid as being
    bad, to ensure it gets recovered.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

commit 03391693a95900875b0973569d2d73ff3aa8972e
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue Jan 26 15:42:38 2010 -0500

    NFSv4.1: Don't call nfs4_schedule_state_recovery() unnecessarily
    
    Currently, nfs4_handle_exception() will call it twice if called with an
    error of -NFS4ERR_STALE_CLIENTID, -NFS4ERR_STALE_STATEID or
    -NFS4ERR_EXPIRED.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

commit 8e469ebd6dc32cbaf620e134d79f740bf0ebab79
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue Jan 26 15:42:30 2010 -0500

    NFSv4: Don't allow posix locking against servers that don't support it
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org
    Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

commit 2bee72a6aa1e6d0a4f5da56217f0d0bbbdd0d9a3
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue Jan 26 15:42:21 2010 -0500

    NFSv4: Ensure that the NFSv4 locking can recover from stateid errors
    
    In most cases, we just want to mark the lock_stateid sequence id as being
    uninitialised.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org
    Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

commit b0706ca415b188ed58788420de4d5c9972b2afb2
Author: David Howells <dhowells@redhat.com>
Date:   Tue Jan 26 15:42:11 2010 -0500

    NFS: Avoid warnings when CONFIG_NFS_V4=n
    
    Avoid the following warnings when CONFIG_NFS_V4=n:
    
    	fs/nfs/sysctl.c:19: warning: unused variable `nfs_set_port_max'
    	fs/nfs/sysctl.c:18: warning: unused variable `nfs_set_port_min'
    
    by making those variables contingent on NFSv4 being configured.
    
    Signed-off-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

commit 0aa05887af728b058af91197f0ae9b3ae63dd74a
Author: H Hartley Sweeten <hartleys@visionengravers.com>
Date:   Tue Jan 26 15:42:03 2010 -0500

    NFS: Make nfs_commitdata_release static
    
    The symbol nfs_commitdata_release is only used locally
    in this file. Make it static to prevent the following sparse warning:
    
    warning: symbol 'nfs_commitdata_release' was not declared. Should it be static?
    
    Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
    Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

commit 82be934a59ff891cac598727e5a862ba2b9d1fac
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue Jan 26 15:41:53 2010 -0500

    NFS: Try to commit unstable writes in nfs_release_page()
    
    If someone calls nfs_release_page(), we presumably already know that the
    page is clean, however it may be holding an unstable write.
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org
    Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

commit c9edda7140ec6a22accf7f2f86da362dfbfd41fc
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue Jan 26 15:41:34 2010 -0500

    NFS: Fix a reference leak in nfs_wb_cancel_page()
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Cc: stable@kernel.org
    Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 6b89132..63f2071 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -486,6 +486,8 @@ static int nfs_release_page(struct page *page, gfp_t gfp)
 {
 	dfprintk(PAGECACHE, "NFS: release_page(%p)\n", page);
 
+	if (gfp & __GFP_WAIT)
+		nfs_wb_page(page->mapping->host, page);
 	/* If PagePrivate() is set, then the page is not freeable */
 	if (PagePrivate(page))
 		return 0;
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index faa0918..f141bde 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -1261,8 +1261,10 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
 
 	if (fattr->valid & NFS_ATTR_FATTR_MODE) {
 		if ((inode->i_mode & S_IALLUGO) != (fattr->mode & S_IALLUGO)) {
+			umode_t newmode = inode->i_mode & S_IFMT;
+			newmode |= fattr->mode & S_IALLUGO;
+			inode->i_mode = newmode;
 			invalid |= NFS_INO_INVALID_ATTR|NFS_INO_INVALID_ACCESS|NFS_INO_INVALID_ACL;
-			inode->i_mode = fattr->mode;
 		}
 	} else if (server->caps & NFS_CAP_MODE)
 		invalid |= save_cache_validity & (NFS_INO_INVALID_ATTR
diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
index 865265b..0c6fda3 100644
--- a/fs/nfs/nfs4_fs.h
+++ b/fs/nfs/nfs4_fs.h
@@ -146,6 +146,7 @@ enum {
 	NFS_O_RDWR_STATE,		/* OPEN stateid has read/write state */
 	NFS_STATE_RECLAIM_REBOOT,	/* OPEN stateid server rebooted */
 	NFS_STATE_RECLAIM_NOGRACE,	/* OPEN stateid needs to recover state */
+	NFS_STATE_POSIX_LOCKS,		/* Posix locks are supported */
 };
 
 struct nfs4_state {
@@ -277,6 +278,7 @@ extern void nfs4_state_set_mode_locked(struct nfs4_state *, fmode_t);
 extern void nfs4_schedule_state_recovery(struct nfs_client *);
 extern void nfs4_schedule_state_manager(struct nfs_client *);
 extern int nfs4_state_mark_reclaim_nograce(struct nfs_client *clp, struct nfs4_state *state);
+extern int nfs4_state_mark_reclaim_reboot(struct nfs_client *clp, struct nfs4_state *state);
 extern void nfs41_handle_sequence_flag_errors(struct nfs_client *clp, u32 flags);
 extern void nfs4_put_lock_state(struct nfs4_lock_state *lsp);
 extern int nfs4_set_lock_state(struct nfs4_state *state, struct file_lock *fl);
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 198d51d..375f0fa 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -249,19 +249,15 @@ static int nfs4_handle_exception(const struct nfs_server *server, int errorcode,
 			if (state == NULL)
 				break;
 			nfs4_state_mark_reclaim_nograce(clp, state);
-		case -NFS4ERR_STALE_CLIENTID:
+			goto do_state_recovery;
 		case -NFS4ERR_STALE_STATEID:
-		case -NFS4ERR_EXPIRED:
-			nfs4_schedule_state_recovery(clp);
-			ret = nfs4_wait_clnt_recover(clp);
-			if (ret == 0)
-				exception->retry = 1;
-#if !defined(CONFIG_NFS_V4_1)
-			break;
-#else /* !defined(CONFIG_NFS_V4_1) */
-			if (!nfs4_has_session(server->nfs_client))
+			if (state == NULL)
 				break;
-			/* FALLTHROUGH */
+			nfs4_state_mark_reclaim_reboot(clp, state);
+		case -NFS4ERR_STALE_CLIENTID:
+		case -NFS4ERR_EXPIRED:
+			goto do_state_recovery;
+#if defined(CONFIG_NFS_V4_1)
 		case -NFS4ERR_BADSESSION:
 		case -NFS4ERR_BADSLOT:
 		case -NFS4ERR_BAD_HIGH_SLOT:
@@ -274,7 +270,7 @@ static int nfs4_handle_exception(const struct nfs_server *server, int errorcode,
 			nfs4_schedule_state_recovery(clp);
 			exception->retry = 1;
 			break;
-#endif /* !defined(CONFIG_NFS_V4_1) */
+#endif /* defined(CONFIG_NFS_V4_1) */
 		case -NFS4ERR_FILE_OPEN:
 			if (exception->timeout > HZ) {
 				/* We have retried a decent amount, time to
@@ -293,6 +289,12 @@ static int nfs4_handle_exception(const struct nfs_server *server, int errorcode,
 	}
 	/* We failed to handle the error */
 	return nfs4_map_errors(ret);
+do_state_recovery:
+	nfs4_schedule_state_recovery(clp);
+	ret = nfs4_wait_clnt_recover(clp);
+	if (ret == 0)
+		exception->retry = 1;
+	return ret;
 }
 

@@ -1658,6 +1660,8 @@ static int _nfs4_do_open(struct inode *dir, struct path *path, fmode_t fmode, in
 	status = PTR_ERR(state);
 	if (IS_ERR(state))
 		goto err_opendata_put;
+	if ((opendata->o_res.rflags & NFS4_OPEN_RESULT_LOCKTYPE_POSIX) != 0)
+		set_bit(NFS_STATE_POSIX_LOCKS, &state->flags);
 	nfs4_opendata_put(opendata);
 	nfs4_put_state_owner(sp);
 	*res = state;
@@ -3422,15 +3426,14 @@ _nfs4_async_handle_error(struct rpc_task *task, const struct nfs_server *server,
 			if (state == NULL)
 				break;
 			nfs4_state_mark_reclaim_nograce(clp, state);
-		case -NFS4ERR_STALE_CLIENTID:
+			goto do_state_recovery;
 		case -NFS4ERR_STALE_STATEID:
+			if (state == NULL)
+				break;
+			nfs4_state_mark_reclaim_reboot(clp, state);
+		case -NFS4ERR_STALE_CLIENTID:
 		case -NFS4ERR_EXPIRED:
-			rpc_sleep_on(&clp->cl_rpcwaitq, task, NULL);
-			nfs4_schedule_state_recovery(clp);
-			if (test_bit(NFS4CLNT_MANAGER_RUNNING, &clp->cl_state) == 0)
-				rpc_wake_up_queued_task(&clp->cl_rpcwaitq, task);
-			task->tk_status = 0;
-			return -EAGAIN;
+			goto do_state_recovery;
 #if defined(CONFIG_NFS_V4_1)
 		case -NFS4ERR_BADSESSION:
 		case -NFS4ERR_BADSLOT:
@@ -3458,6 +3461,13 @@ _nfs4_async_handle_error(struct rpc_task *task, const struct nfs_server *server,
 	}
 	task->tk_status = nfs4_map_errors(task->tk_status);
 	return 0;
+do_state_recovery:
+	rpc_sleep_on(&clp->cl_rpcwaitq, task, NULL);
+	nfs4_schedule_state_recovery(clp);
+	if (test_bit(NFS4CLNT_MANAGER_RUNNING, &clp->cl_state) == 0)
+		rpc_wake_up_queued_task(&clp->cl_rpcwaitq, task);
+	task->tk_status = 0;
+	return -EAGAIN;
 }
 
 static int
@@ -4088,6 +4098,28 @@ static const struct rpc_call_ops nfs4_recover_lock_ops = {
 	.rpc_release = nfs4_lock_release,
 };
 
+static void nfs4_handle_setlk_error(struct nfs_server *server, struct nfs4_lock_state *lsp, int new_lock_owner, int error)
+{
+	struct nfs_client *clp = server->nfs_client;
+	struct nfs4_state *state = lsp->ls_state;
+
+	switch (error) {
+	case -NFS4ERR_ADMIN_REVOKED:
+	case -NFS4ERR_BAD_STATEID:
+	case -NFS4ERR_EXPIRED:
+		if (new_lock_owner != 0 ||
+		   (lsp->ls_flags & NFS_LOCK_INITIALIZED) != 0)
+			nfs4_state_mark_reclaim_nograce(clp, state);
+		lsp->ls_seqid.flags &= ~NFS_SEQID_CONFIRMED;
+		break;
+	case -NFS4ERR_STALE_STATEID:
+		if (new_lock_owner != 0 ||
+		    (lsp->ls_flags & NFS_LOCK_INITIALIZED) != 0)
+			nfs4_state_mark_reclaim_reboot(clp, state);
+		lsp->ls_seqid.flags &= ~NFS_SEQID_CONFIRMED;
+	};
+}
+
 static int _nfs4_do_setlk(struct nfs4_state *state, int cmd, struct file_lock *fl, int recovery_type)
 {
 	struct nfs4_lockdata *data;
@@ -4126,6 +4158,9 @@ static int _nfs4_do_setlk(struct nfs4_state *state, int cmd, struct file_lock *f
 	ret = nfs4_wait_for_completion_rpc_task(task);
 	if (ret == 0) {
 		ret = data->rpc_status;
+		if (ret)
+			nfs4_handle_setlk_error(data->server, data->lsp,
+					data->arg.new_lock_owner, ret);
 	} else
 		data->cancelled = 1;
 	rpc_put_task(task);
@@ -4181,8 +4216,11 @@ static int _nfs4_proc_setlk(struct nfs4_state *state, int cmd, struct file_lock
 {
 	struct nfs_inode *nfsi = NFS_I(state->inode);
 	unsigned char fl_flags = request->fl_flags;
-	int status;
+	int status = -ENOLCK;
 
+	if ((fl_flags & FL_POSIX) &&
+			!test_bit(NFS_STATE_POSIX_LOCKS, &state->flags))
+		goto out;
 	/* Is this a delegated open? */
 	status = nfs4_set_lock_state(state, request);
 	if (status != 0)
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 6d263ed..c1e2733 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -901,7 +901,7 @@ void nfs4_schedule_state_recovery(struct nfs_client *clp)
 	nfs4_schedule_state_manager(clp);
 }
 
-static int nfs4_state_mark_reclaim_reboot(struct nfs_client *clp, struct nfs4_state *state)
+int nfs4_state_mark_reclaim_reboot(struct nfs_client *clp, struct nfs4_state *state)
 {
 
 	set_bit(NFS_STATE_RECLAIM_REBOOT, &state->flags);
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index e297593..a12c45b 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -176,6 +176,12 @@ void nfs_release_request(struct nfs_page *req)
 	kref_put(&req->wb_kref, nfs_free_request);
 }
 
+static int nfs_wait_bit_uninterruptible(void *word)
+{
+	io_schedule();
+	return 0;
+}
+
 /**
  * nfs_wait_on_request - Wait for a request to complete.
  * @req: request to wait upon.
@@ -186,14 +192,9 @@ void nfs_release_request(struct nfs_page *req)
 int
 nfs_wait_on_request(struct nfs_page *req)
 {
-	int ret = 0;
-
-	if (!test_bit(PG_BUSY, &req->wb_flags))
-		goto out;
-	ret = out_of_line_wait_on_bit(&req->wb_flags, PG_BUSY,
-			nfs_wait_bit_killable, TASK_KILLABLE);
-out:
-	return ret;
+	return wait_on_bit(&req->wb_flags, PG_BUSY,
+			nfs_wait_bit_uninterruptible,
+			TASK_UNINTERRUPTIBLE);
 }
 
 /**
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index ce907ef..f1afee4 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -243,6 +243,7 @@ static int  nfs_show_stats(struct seq_file *, struct vfsmount *);
 static int nfs_get_sb(struct file_system_type *, int, const char *, void *, struct vfsmount *);
 static int nfs_xdev_get_sb(struct file_system_type *fs_type,
 		int flags, const char *dev_name, void *raw_data, struct vfsmount *mnt);
+static void nfs_put_super(struct super_block *);
 static void nfs_kill_super(struct super_block *);
 static int nfs_remount(struct super_block *sb, int *flags, char *raw_data);
 
@@ -266,6 +267,7 @@ static const struct super_operations nfs_sops = {
 	.alloc_inode	= nfs_alloc_inode,
 	.destroy_inode	= nfs_destroy_inode,
 	.write_inode	= nfs_write_inode,
+	.put_super	= nfs_put_super,
 	.statfs		= nfs_statfs,
 	.clear_inode	= nfs_clear_inode,
 	.umount_begin	= nfs_umount_begin,
@@ -335,6 +337,7 @@ static const struct super_operations nfs4_sops = {
 	.alloc_inode	= nfs_alloc_inode,
 	.destroy_inode	= nfs_destroy_inode,
 	.write_inode	= nfs_write_inode,
+	.put_super	= nfs_put_super,
 	.statfs		= nfs_statfs,
 	.clear_inode	= nfs4_clear_inode,
 	.umount_begin	= nfs_umount_begin,
@@ -2258,6 +2261,17 @@ error_splat_super:
 }
 
 /*
+ * Ensure that we unregister the bdi before kill_anon_super
+ * releases the device name
+ */
+static void nfs_put_super(struct super_block *s)
+{
+	struct nfs_server *server = NFS_SB(s);
+
+	bdi_unregister(&server->backing_dev_info);
+}
+
+/*
  * Destroy an NFS2/3 superblock
  */
 static void nfs_kill_super(struct super_block *s)
@@ -2265,7 +2279,6 @@ static void nfs_kill_super(struct super_block *s)
 	struct nfs_server *server = NFS_SB(s);
 
 	kill_anon_super(s);
-	bdi_unregister(&server->backing_dev_info);
 	nfs_fscache_release_super_cookie(s);
 	nfs_free_server(server);
 }
diff --git a/fs/nfs/sysctl.c b/fs/nfs/sysctl.c
index 70e1fbb..ad4d2e7 100644
--- a/fs/nfs/sysctl.c
+++ b/fs/nfs/sysctl.c
@@ -15,8 +15,10 @@
 
 #include "callback.h"
 
+#ifdef CONFIG_NFS_V4
 static const int nfs_set_port_min = 0;
 static const int nfs_set_port_max = 65535;
+#endif
 static struct ctl_table_header *nfs_callback_sysctl_table;
 
 static ctl_table nfs_cb_sysctls[] = {
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index d171696..7b54b8b 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -1233,7 +1233,7 @@ int nfs_writeback_done(struct rpc_task *task, struct nfs_write_data *data)
 

 #if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
-void nfs_commitdata_release(void *data)
+static void nfs_commitdata_release(void *data)
 {
 	struct nfs_write_data *wdata = data;
 
@@ -1541,6 +1541,7 @@ int nfs_wb_page_cancel(struct inode *inode, struct page *page)
 			break;
 		}
 		ret = nfs_wait_on_request(req);
+		nfs_release_request(req);
 		if (ret < 0)
 			goto out;
 	}


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes....
@ 2010-01-07 20:29 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2010-01-07 20:29 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-nfs, linux-kernel, OGAWA Hirofumi, Marvin, Andrew Morton,
	Randy Dunlap, Jeff Layton

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/dir.c                          |    1 +
 net/sunrpc/auth_gss/auth_gss.c        |   17 ++++++++++++++++-
 net/sunrpc/auth_gss/gss_krb5_mech.c   |    4 +++-
 net/sunrpc/auth_gss/gss_mech_switch.c |    2 +-
 4 files changed, 21 insertions(+), 3 deletions(-)

commit 56335936de1a41c8978fde62b2158af77ddc7258
Author: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Date:   Wed Jan 6 18:48:26 2010 -0500

    nfs: fix oops in nfs_rename()
    
    Recent change is missing to update "rehash".  With that change, it will
    become the cause of adding dentry to hash twice.
    
    This explains the reason of Oops (dereference the freed dentry in
    __d_lookup()) on my machine.
    
    Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    Reported-by: Marvin <marvin24@gmx.de>
    Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 6c8530993e1fdf1d6af0403e796fe14d80b4b097
Author: Randy Dunlap <randy.dunlap@oracle.com>
Date:   Wed Jan 6 17:26:27 2010 -0500

    sunrpc: fix build-time warning
    
    Fix auth_gss printk format warning:
    
    net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
    
    Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    Acked-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 486bad2e40e938cd68fd853b7a9fa3115a9d3a4a
Author: Jeff Layton <jlayton@redhat.com>
Date:   Fri Dec 18 16:28:20 2009 -0500

    sunrpc: on successful gss error pipe write, don't return error
    
    When handling the gssd downcall, the kernel should distinguish between a
    successful downcall that contains an error code and a failed downcall
    (i.e. where the parsing failed or some other sort of problem occurred).
    
    In the former case, gss_pipe_downcall should be returning the number of
    bytes written to the pipe instead of an error. In the event of other
    errors, we generally want the initiating task to retry the upcall so
    we set msg.errno to -EAGAIN. An unexpected error code here is a bug
    however, so BUG() in that case.
    
    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    Cc: stable@kernel.org
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit b891e4a05ef6beac85465295a032431577c66b16
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Fri Dec 18 16:28:12 2009 -0500

    SUNRPC: Fix the return value in gss_import_sec_context()
    
    If the context allocation fails, it will return GSS_S_FAILURE, which is
    neither a valid error code, nor is it even negative.
    
    Return ENOMEM instead...
    
    Reported-by: Jeff Layton <jlayton@redhat.com>
    Cc: stable@kernel.org
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 14ace024b1e16d2bb9445c8387494fbbd820a738
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Fri Dec 18 16:28:05 2009 -0500

    SUNRPC: Fix up an error return value in gss_import_sec_context_kerberos()
    
    If the context allocation fails, the function currently returns a random
    error code, since the variable 'p' still points to a valid memory location.
    
    Ensure that it returns ENOMEM...
    
    Cc: stable@kernel.org
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 2c5ace4..3c7f03b 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -1615,6 +1615,7 @@ static int nfs_rename(struct inode *old_dir, struct dentry *old_dentry,
 				goto out;
 
 			new_dentry = dentry;
+			rehash = NULL;
 			new_inode = NULL;
 		}
 	}
diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
index 3c3c50f..f7a7f83 100644
--- a/net/sunrpc/auth_gss/auth_gss.c
+++ b/net/sunrpc/auth_gss/auth_gss.c
@@ -644,7 +644,22 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
 	p = gss_fill_context(p, end, ctx, gss_msg->auth->mech);
 	if (IS_ERR(p)) {
 		err = PTR_ERR(p);
-		gss_msg->msg.errno = (err == -EAGAIN) ? -EAGAIN : -EACCES;
+		switch (err) {
+		case -EACCES:
+			gss_msg->msg.errno = err;
+			err = mlen;
+			break;
+		case -EFAULT:
+		case -ENOMEM:
+		case -EINVAL:
+		case -ENOSYS:
+			gss_msg->msg.errno = -EAGAIN;
+			break;
+		default:
+			printk(KERN_CRIT "%s: bad return from "
+				"gss_fill_context: %zd\n", __func__, err);
+			BUG();
+		}
 		goto err_release_msg;
 	}
 	gss_msg->ctx = gss_get_ctx(ctx);
diff --git a/net/sunrpc/auth_gss/gss_krb5_mech.c b/net/sunrpc/auth_gss/gss_krb5_mech.c
index ef45eba..2deb0ed 100644
--- a/net/sunrpc/auth_gss/gss_krb5_mech.c
+++ b/net/sunrpc/auth_gss/gss_krb5_mech.c
@@ -131,8 +131,10 @@ gss_import_sec_context_kerberos(const void *p,
 	struct	krb5_ctx *ctx;
 	int tmp;
 
-	if (!(ctx = kzalloc(sizeof(*ctx), GFP_NOFS)))
+	if (!(ctx = kzalloc(sizeof(*ctx), GFP_NOFS))) {
+		p = ERR_PTR(-ENOMEM);
 		goto out_err;
+	}
 
 	p = simple_get_bytes(p, end, &ctx->initiate, sizeof(ctx->initiate));
 	if (IS_ERR(p))
diff --git a/net/sunrpc/auth_gss/gss_mech_switch.c b/net/sunrpc/auth_gss/gss_mech_switch.c
index 6efbb0c..76e4c6f 100644
--- a/net/sunrpc/auth_gss/gss_mech_switch.c
+++ b/net/sunrpc/auth_gss/gss_mech_switch.c
@@ -252,7 +252,7 @@ gss_import_sec_context(const void *input_token, size_t bufsize,
 		       struct gss_ctx		**ctx_id)
 {
 	if (!(*ctx_id = kzalloc(sizeof(**ctx_id), GFP_KERNEL)))
-		return GSS_S_FAILURE;
+		return -ENOMEM;
 	(*ctx_id)->mech_type = gss_mech_get(mech);
 
 	return mech->gm_ops


^ permalink raw reply	[flat|nested] 47+ messages in thread

* [GIT PULL] Please pull NFS client bugfixes
@ 2009-05-26 19:06 Trond Myklebust
  0 siblings, 0 replies; 47+ messages in thread
From: Trond Myklebust @ 2009-05-26 19:06 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-nfs, linux-kernel, Sam Ravnborg, Steven Whitehouse,
	Stephen Rothwell, Vu Pham, Tom Talpey

Hi Linus,

Please pull from the "bugfixes" branch of the repository at

   git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes

This will update the following files through the appended changesets.

  Cheers,
    Trond

----
 fs/nfs/nfs4proc.c           |    9 +++------
 fs/nfs/nfsroot.c            |    2 +-
 net/sunrpc/xprtrdma/verbs.c |    3 ++-
 3 files changed, 6 insertions(+), 8 deletions(-)

commit 95baa25c7321eb8613246acbf61b97911cc748d3
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Tue May 26 14:51:00 2009 -0400

    NFSv4: Fix the case where NFSv4 renewal fails
    
    If the asynchronous lease renewal fails (usually due to a soft timeout),
    then we _must_ schedule state recovery in order to ensure that we don't
    lose the lease unnecessarily or, if the lease is already lost, that we
    recover the locking state promptly...
    
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit d0367a508af9cf97beb202935bb9ad8883d30cd1
Author: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
Date:   Tue May 26 14:51:00 2009 -0400

    nfs: fix build error in nfsroot with initconst
    
    fix build error with latest kbuild adjustments to initconst.
    
    The commit a447c0932445f92ce6f4c1bd020f62c5097a7842 ("vfs: Use
    const for kernel parser table") changed:
    
        static match_table_t __initdata tokens = {
    to
        static match_table_t __initconst tokens = {
    
    But the missing const causes powerpc to fail with latest
    updates to __initconst like this:
    
    fs/nfs/nfsroot.c:400: error: __setup_str_nfs_root_setup causes a section type conflict
    fs/nfs/nfsroot.c:400: error: __setup_str_nfs_root_setup causes a section type conflict
    
    The bug is only present with kbuild-next.
    Following patch has been build tested.
    
    Signed-off-by: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
    Cc: Steven Whitehouse <swhiteho@redhat.com>
    Cc: Stephen Rothwell <sfr@canb.auug.org.au>
    Acked-by: Jan Beulich <jbeulich@novell.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

commit 68743082b560067e3e93eab8b2568f238e486865
Author: Vu Pham <vu@mellanox.com>
Date:   Tue May 26 14:51:00 2009 -0400

    XPRTRDMA: fix client rpcrdma FRMR registration on mlx4 devices
    
    mlx4/connectX FRMR requires local write enable together with remote
    rdma write enable. This fixes NFS/RDMA operation over the ConnectX
    Infiniband HCA in the default memreg mode.
    
    Signed-off-by: Vu Pham <vu@mellanox.com>
    Signed-off-by: Tom Talpey <tmtalpey@gmail.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index a4d2426..4674f80 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -2594,12 +2594,9 @@ static void nfs4_renew_done(struct rpc_task *task, void *data)
 	unsigned long timestamp = (unsigned long)data;
 
 	if (task->tk_status < 0) {
-		switch (task->tk_status) {
-			case -NFS4ERR_STALE_CLIENTID:
-			case -NFS4ERR_EXPIRED:
-			case -NFS4ERR_CB_PATH_DOWN:
-				nfs4_schedule_state_recovery(clp);
-		}
+		/* Unless we're shutting down, schedule state recovery! */
+		if (test_bit(NFS_CS_RENEWD, &clp->cl_res_state) != 0)
+			nfs4_schedule_state_recovery(clp);
 		return;
 	}
 	spin_lock(&clp->cl_lock);
diff --git a/fs/nfs/nfsroot.c b/fs/nfs/nfsroot.c
index d9ef602..e3ed590 100644
--- a/fs/nfs/nfsroot.c
+++ b/fs/nfs/nfsroot.c
@@ -129,7 +129,7 @@ enum {
 	Opt_err
 };
 
-static match_table_t __initconst tokens = {
+static const match_table_t tokens __initconst = {
 	{Opt_port, "port=%u"},
 	{Opt_rsize, "rsize=%u"},
 	{Opt_wsize, "wsize=%u"},
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index 3b21e0c..465aafc 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -1495,7 +1495,8 @@ rpcrdma_register_frmr_external(struct rpcrdma_mr_seg *seg,
 	frmr_wr.wr.fast_reg.page_shift = PAGE_SHIFT;
 	frmr_wr.wr.fast_reg.length = i << PAGE_SHIFT;
 	frmr_wr.wr.fast_reg.access_flags = (writing ?
-				IB_ACCESS_REMOTE_WRITE : IB_ACCESS_REMOTE_READ);
+				IB_ACCESS_REMOTE_WRITE | IB_ACCESS_LOCAL_WRITE :
+				IB_ACCESS_REMOTE_READ);
 	frmr_wr.wr.fast_reg.rkey = seg1->mr_chunk.rl_mw->r.frmr.fr_mr->rkey;
 	DECR_CQCOUNT(&r_xprt->rx_ep);
 

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

^ permalink raw reply	[flat|nested] 47+ messages in thread

end of thread, back to index

Thread overview: 47+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19 16:49 [GIT PULL] Please pull NFS client bugfixes Trond Myklebust
2018-12-20  2:50 ` pr-tracker-bot
2018-12-20 15:23 ` Geert Uytterhoeven
  -- strict thread matches above, loose matches on Subject: below --
2018-03-12 17:29 Trond Myklebust
2018-02-25 17:02 Trond Myklebust
2017-01-28 17:04 Trond Myklebust
2017-01-16 20:14 Trond Myklebust
2016-10-21 20:30 Anna Schumaker
2015-10-07  2:52 Trond Myklebust
2015-09-25 15:14 Trond Myklebust
2015-07-28 16:03 Trond Myklebust
2015-03-06  3:46 Trond Myklebust
2015-01-29 21:37 Trond Myklebust
2015-01-16 14:35 Trond Myklebust
2014-11-14 23:04 Trond Myklebust
2014-09-19 19:32 Trond Myklebust
2014-01-31 21:41 Trond Myklebust
2013-12-05 17:20 Trond Myklebust
2013-11-16 21:09 Myklebust, Trond
2013-09-30 22:02 Myklebust, Trond
2013-05-26 19:29 Myklebust, Trond
2013-03-26 18:26 Myklebust, Trond
2013-03-03  0:08 Myklebust, Trond
2013-02-21  3:38 Myklebust, Trond
2013-01-07 15:45 Myklebust, Trond
2012-11-03 19:48 Myklebust, Trond
2012-10-22 17:42 Myklebust, Trond
2012-09-12 19:19 Myklebust, Trond
2012-07-13 15:14 Myklebust, Trond
2012-05-02  3:57 Myklebust, Trond
2012-04-24 20:18 [GIT PULL] please " Myklebust, Trond
2011-12-20  6:15 [GIT PULL] Please " Trond Myklebust
2011-11-22 11:50 Trond Myklebust
2011-08-19  1:05 Trond Myklebust
2011-07-12 23:30 Trond Myklebust
2011-05-13 20:23 Trond Myklebust
2011-04-08 18:40 [GIT PULL] please " Trond Myklebust
2011-03-14 18:09 [GIT PULL] Please " Trond Myklebust
2010-11-26 18:56 Trond Myklebust
2010-05-26 19:42 Trond Myklebust
2010-05-07  2:22 Trond Myklebust
2010-04-29 16:48 Trond Myklebust
2010-03-23 17:00 Trond Myklebust
2010-03-17 21:55 Trond Myklebust
2010-02-04 19:10 Trond Myklebust
2010-01-07 20:29 Trond Myklebust
2009-05-26 19:06 Trond Myklebust

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org linux-nfs@archiver.kernel.org
	public-inbox-index linux-nfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox