From: Olga Kornievskaia <email@example.com> To: Amir Goldstein <firstname.lastname@example.org> Cc: "J. Bruce Fields" <email@example.com>, linux-nfs <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v2 01/10] VFS generic copy_file_range() support Date: Sat, 1 Dec 2018 08:44:24 -0500 Message-ID: <CAN-5tyFwE=5K4vCfjVLsyjgOfmLwQU9c-gwJHKedAwOoVWmQ=A@mail.gmail.com> (raw) In-Reply-To: <CAN-5tyGV1F6EAwN3e3dHyvfL6UJhJu1m=GKCT4iVMy6uprcSfirstname.lastname@example.org> On Sat, Dec 1, 2018 at 8:23 AM Olga Kornievskaia <email@example.com> wrote: > > On Sat, Dec 1, 2018 at 3:11 AM Amir Goldstein <firstname.lastname@example.org> wrote: > > > > On Fri, Nov 30, 2018 at 10:04 PM Olga Kornievskaia > > <email@example.com> wrote: > > > > > > Relax the condition that input files must be from the same > > > file systems. > > > > > > Add checks that input parameters adhere semantics. > > > > > > If no copy_file_range() support is found, then do generic > > > checks for the unsupported page cache ranges, LFS, limits, > > > and clear setuid/setgid if not running as root before calling > > > do_splice_direct(). Update atime,ctime,mtime afterwards. > > > > > > Signed-off-by: Olga Kornievskaia <firstname.lastname@example.org> > > > --- > > > > This patch is either going to bring you down or make you stronger ;-) > > > > This is not how its done. Behavior change and refactoring mixed into > > one patch is wrong for several reasons. And when you relax same sb > > check you need to restrict it inside filesystems, like your previous patch > > did. > > > > You already had v7 patch reviewed-by 4 developers. > > What made you go and change it (and posted as v2)? > > > > Your intentions were good trying to fix the broken syscall, but > > I hope you understood that Dave didn't mean that you *have* to > > add the missing generic checks as part of your work. He just > > pointed out how broken the current interface is in the context of > > reviewing your patch. > > > > In any case, I hear that Dave is neck deep in fixing copy_file_range() > > so changes to this function should be collaborated with him. Or better > > yet, wait until he posts his fixes and carry on from there. > > > > If I were you, I would just go back to the reviewed v7 vfs patch. > > This is NOT a replacement to the v7 vfs patch??? This is a new patch > on top of that one. > > I assume that v7 patch has been OK-ed by everybody and is ready to go in??? > > As you recall, what was left is to provide the functionality to relax > the check for the superblocks to be the same before calling the > do_splice_direct(). This patch attempt do this. I was under the > impression that to do so extra checks were needed to be added which I > added. > To clarify, previously I had a VFS patch with the client-side series to support "server to server" copy offload. It needed the functionality to be able to call copy_file_range with different super blocks. This patch series is for the server side support for the "server to server" copy offload. It requires ability to call copy_file_range() and do a copy between NFS and a local file system. Thus it needs generic_copy_file_range. > > > > > Thanks, > > Amir.
next prev parent reply index Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-30 20:03 [PATCH v2 00/10] server-side support for "inter" SSC copy Olga Kornievskaia 2018-11-30 20:03 ` [PATCH v2 01/10] VFS generic copy_file_range() support Olga Kornievskaia 2018-12-01 8:11 ` Amir Goldstein 2018-12-01 13:23 ` Olga Kornievskaia 2018-12-01 13:44 ` Olga Kornievskaia [this message] [not found] ` <CAOQ4uxgENLCDH7QwtBPxA60dKEXvLVknBMY_Lgoetq_uQ=7gwA@mail.gmail.com> [not found] ` <CAN-5tyFGV=fUCbAG5mSvy=LXDpdp8VG9Sh1aGMkBHQAG1Rp1sQ@mail.gmail.com> 2018-12-01 16:59 ` Amir Goldstein 2018-12-01 22:00 ` Dave Chinner 2018-12-02 3:12 ` Olga Kornievskaia 2018-12-02 15:19 ` Olga Kornievskaia 2018-12-02 20:47 ` Dave Chinner 2018-12-01 21:18 ` Matthew Wilcox 2018-12-01 22:36 ` Dave Chinner 2018-11-30 20:03 ` [PATCH v2 02/10] NFS fallback to generic_copy_file_range Olga Kornievskaia 2018-11-30 20:03 ` [PATCH v2 03/10] NFSD fill-in netloc4 structure Olga Kornievskaia 2018-11-30 20:03 ` [PATCH v2 04/10] NFSD add ca_source_server<> to COPY Olga Kornievskaia 2019-02-19 16:17 ` bfields 2018-11-30 20:03 ` [PATCH v2 05/10] NFSD return nfs4_stid in nfs4_preprocess_stateid_op Olga Kornievskaia 2018-11-30 20:03 ` [PATCH v2 06/10] NFSD add COPY_NOTIFY operation Olga Kornievskaia 2019-02-20 1:44 ` bfields 2019-02-20 2:07 ` bfields 2019-02-20 14:04 ` J. Bruce Fields 2019-02-20 2:12 ` bfields 2019-02-20 2:35 ` bfields 2019-06-14 19:11 ` Olga Kornievskaia 2018-11-30 20:03 ` [PATCH v2 07/10] NFSD check stateids against copy stateids Olga Kornievskaia 2018-11-30 20:03 ` [PATCH v2 08/10] NFSD generalize nfsd4_compound_state flag names Olga Kornievskaia 2018-11-30 20:03 ` [PATCH v2 09/10] NFSD: allow inter server COPY to have a STALE source server fh Olga Kornievskaia 2018-12-05 18:05 ` Olga Kornievskaia 2019-02-19 15:53 ` bfields 2018-11-30 20:03 ` [PATCH v2 10/10] NFSD add nfs4 inter ssc to nfsd4_copy Olga Kornievskaia 2019-02-19 15:54 ` bfields 2018-12-20 18:42 ` [PATCH v2 00/10] server-side support for "inter" SSC copy Olga Kornievskaia 2018-12-21 19:08 ` J. Bruce Fields 2019-01-14 14:53 ` Olga Kornievskaia 2019-01-16 22:08 ` J. Bruce Fields 2019-01-17 17:03 ` Olga Kornievskaia 2019-02-19 16:03 ` bfields
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAN-5tyFwE=5K4vCfjVLsyjgOfmLwQU9c-gwJHKedAwOoVWmQ=A@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-NFS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \ firstname.lastname@example.org email@example.com public-inbox-index linux-nfs Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs AGPL code for this site: git clone https://public-inbox.org/ public-inbox