From: Olga Kornievskaia <olga.kornievskaia@gmail.com>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v5 1/9] NFSD fill-in netloc4 structure
Date: Mon, 12 Aug 2019 12:12:33 -0400 [thread overview]
Message-ID: <CAN-5tyHtr6X+Rj8wCxkrTwSS+Y4Sug24n=hRaMjqjTq0O4JDUw@mail.gmail.com> (raw)
In-Reply-To: <201908111349.HDWO4xNv%lkp@intel.com>
Hi Bruce,
I believe I'm getting this because as it has been before NFSD patches
depend on client-side patches (or specifically) it needed
https://patchwork.kernel.org/patch/10649667/
I should have included the patch in both the client and server patch
series. How should I correct this?
Also, in general (to run things) nfsd patches need the client side
patches to be functional destination server (destination server nfs
client piece).
On Sun, Aug 11, 2019 at 1:49 AM kbuild test robot <lkp@intel.com> wrote:
>
> Hi Olga,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on nfsd/nfsd-next]
> [cannot apply to v5.3-rc3 next-20190809]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/server-side-support-for-inter-SSC-copy/20190811-120551
> base: git://linux-nfs.org/~bfields/linux.git nfsd-next
> config: x86_64-lkp (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from fs/nfsd/state.h:42:0,
> from fs/nfsd/trace.h:128,
> from fs/nfsd/trace.c:3:
> >> fs/nfsd/nfsd.h:391:16: warning: 'struct nfs42_netaddr' declared inside parameter list will not be visible outside of this definition or declaration
> struct nfs42_netaddr *netaddr)
> ^~~~~~~~~~~~~
> fs/nfsd/nfsd.h: In function 'nfsd4_set_netaddr':
> >> fs/nfsd/nfsd.h:401:18: error: dereferencing pointer to incomplete type 'struct nfs42_netaddr'
> sprintf(netaddr->netid, "tcp");
> ^~
>
> vim +401 fs/nfsd/nfsd.h
>
> 389
> 390 static inline u32 nfsd4_set_netaddr(struct sockaddr *addr,
> > 391 struct nfs42_netaddr *netaddr)
> 392 {
> 393 struct sockaddr_in *sin = (struct sockaddr_in *)addr;
> 394 struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)addr;
> 395 unsigned int port;
> 396 size_t ret_addr, ret_port;
> 397
> 398 switch (addr->sa_family) {
> 399 case AF_INET:
> 400 port = ntohs(sin->sin_port);
> > 401 sprintf(netaddr->netid, "tcp");
> 402 netaddr->netid_len = 3;
> 403 break;
> 404 case AF_INET6:
> 405 port = ntohs(sin6->sin6_port);
> 406 sprintf(netaddr->netid, "tcp6");
> 407 netaddr->netid_len = 4;
> 408 break;
> 409 default:
> 410 return nfserr_inval;
> 411 }
> 412 ret_addr = rpc_ntop(addr, netaddr->addr, sizeof(netaddr->addr));
> 413 ret_port = snprintf(netaddr->addr + ret_addr,
> 414 RPCBIND_MAXUADDRLEN + 1 - ret_addr,
> 415 ".%u.%u", port >> 8, port & 0xff);
> 416 WARN_ON(ret_port >= RPCBIND_MAXUADDRLEN + 1 - ret_addr);
> 417 netaddr->addr_len = ret_addr + ret_port;
> 418 return 0;
> 419 }
> 420
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-08-12 16:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 20:18 [PATCH v5 0/9] server-side support for "inter" SSC copy Olga Kornievskaia
2019-08-08 20:18 ` [PATCH v5 1/9] NFSD fill-in netloc4 structure Olga Kornievskaia
2019-08-11 5:48 ` kbuild test robot
2019-08-12 16:12 ` Olga Kornievskaia [this message]
2019-08-12 19:58 ` J. Bruce Fields
2019-08-08 20:18 ` [PATCH v5 2/9] NFSD add ca_source_server<> to COPY Olga Kornievskaia
2019-08-11 5:59 ` kbuild test robot
2019-08-11 7:00 ` kbuild test robot
2019-08-08 20:18 ` [PATCH v5 3/9] NFSD return nfs4_stid in nfs4_preprocess_stateid_op Olga Kornievskaia
2019-08-08 20:18 ` [PATCH v5 4/9] NFSD COPY_NOTIFY xdr Olga Kornievskaia
2019-08-11 6:10 ` kbuild test robot
2019-08-08 20:18 ` [PATCH v5 5/9] NFSD add COPY_NOTIFY operation Olga Kornievskaia
2019-08-11 6:17 ` kbuild test robot
2019-08-12 16:19 ` Olga Kornievskaia
2019-08-12 19:16 ` Olga Kornievskaia
2019-08-12 20:00 ` J. Bruce Fields
2019-08-12 20:00 ` J. Bruce Fields
2019-08-13 17:57 ` Olga Kornievskaia
2019-08-14 15:05 ` Olga Kornievskaia
2019-08-29 19:23 ` Olga Kornievskaia
2019-08-30 17:56 ` J. Bruce Fields
2019-08-08 20:18 ` [PATCH v5 6/9] NFSD check stateids against copy stateids Olga Kornievskaia
2019-08-08 20:18 ` [PATCH v5 7/9] NFSD generalize nfsd4_compound_state flag names Olga Kornievskaia
2019-08-08 20:18 ` [PATCH v5 8/9] NFSD: allow inter server COPY to have a STALE source server fh Olga Kornievskaia
2019-08-08 20:18 ` [PATCH v5 9/9] NFSD add nfs4 inter ssc to nfsd4_copy Olga Kornievskaia
2019-08-11 6:24 ` kbuild test robot
2019-09-04 20:50 ` [PATCH v5 0/9] server-side support for "inter" SSC copy J. Bruce Fields
2019-09-05 0:05 ` Olga Kornievskaia
2019-09-05 0:13 ` Rick Macklem
2019-09-06 14:23 ` Olga Kornievskaia
2019-09-06 15:32 ` Rick Macklem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN-5tyHtr6X+Rj8wCxkrTwSS+Y4Sug24n=hRaMjqjTq0O4JDUw@mail.gmail.com' \
--to=olga.kornievskaia@gmail.com \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--subject='Re: [PATCH v5 1/9] NFSD fill-in netloc4 structure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).