Linux-NFS Archive on lore.kernel.org
 help / Atom feed
* Re: [PATCH] common/rc: improve _fstyp_has_non_default_seek_data_hole()
       [not found] <1557727987-3788-1-git-send-email-jefflexu@linux.alibaba.com>
@ 2019-05-13  8:27 ` Amir Goldstein
  0 siblings, 0 replies; 1+ messages in thread
From: Amir Goldstein @ 2019-05-13  8:27 UTC (permalink / raw)
  To: Jeffle Xu; +Cc: fstests, caspar, Linux NFS Mailing List

On Mon, May 13, 2019 at 9:13 AM Jeffle Xu <jefflexu@linux.alibaba.com> wrote:
>
> commit 34081087 adds more sanity to seek_sanity_test(), where
> some kinds of filesystem type should not only support default
> behavior of SEEK_HOLE, that is, always returns EOF. A hardcoded
> whitelist is maintained to distinguish whether a filesystem type
> is allowed to only support default behavior or not.

Its the other way around.
The whitelist is for filesystems that are allowed to support only
"non default" behavior.
A filesystem that is not whitelisted can support either default or
non-default behavior as far as the test is concerned.

>
> In this whitelist, NFS is not allowed to support default behavior
> only. However as far as I know, nfsv2 and nfsv3 only support
> default behavior of SEEK_HOLE in linux.

Correct.

>
> On the other hand, xfstests uses "mount -t nfs ..." to mount a
> NFS mount point. Normally the mount point is mounted on nfsv4,
> but it can be mounted mandatorily on nfsv3 if we specify
> "Nfsvers=3" in /etc/nfsmount.conf. And in this case, a series of
> tests fail (including generic/285, generic/448, generic/490, et
> cetera) with error message "Default behavior is not allowed.
> Aborting."
>
> So I just make some special handling for NFS in
> _fstyp_has_non_default_seek_data_hole(), that is, default behavior
> of SEEK_HOLE is acceptable for nfsv2 and nfsv3.
>
> I'm not sure how nfsv2 and nfsv3 behave SEEK_HOLE in other OS other
> than linux, and any comment is welcomed if I misunderstand the
> SEEK_HOLE behavior of nfsv2/nfsv3 in linux.

I think you understood well (CC NFS list).
xfstests does not support non Linux OS anymore.

>
> Thanks.
>
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
> ---
>  common/rc | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index cbd3c59..83e9729 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2315,9 +2315,15 @@ _fstyp_has_non_default_seek_data_hole()
>         fi
>
>         case "$fstyp" in
> -       btrfs|ext4|xfs|ceph|cifs|f2fs|gfs2|nfs*|ocfs2|tmpfs)
> +       btrfs|ext4|xfs|ceph|cifs|f2fs|gfs2|ocfs2|tmpfs)
>                 return 0
>                 ;;
> +       nfs*)
> +               # NFSv2 and NFSv3 only support default behavior of SEEK_HOLE,
> +               # while NFSv4 supports non-default behavior
> +               local nfsvers=`_df_device $TEST_DEV | $AWK_PROG '{ print $2 }'`
> +               [ "$nfsvers" = "nfs4" ] && return 0 || return 1

               [ "$nfsvers" = "nfs4" ]
               return $?

Thanks,
Amir.

^ permalink raw reply	[flat|nested] 1+ messages in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1557727987-3788-1-git-send-email-jefflexu@linux.alibaba.com>
2019-05-13  8:27 ` [PATCH] common/rc: improve _fstyp_has_non_default_seek_data_hole() Amir Goldstein

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org linux-nfs@archiver.kernel.org
	public-inbox-index linux-nfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox