From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC0CC432C0 for ; Sun, 24 Nov 2019 20:50:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC4E22075E for ; Sun, 24 Nov 2019 20:50:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B92UTXX4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726855AbfKXUuh (ORCPT ); Sun, 24 Nov 2019 15:50:37 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:37194 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726840AbfKXUuh (ORCPT ); Sun, 24 Nov 2019 15:50:37 -0500 Received: by mail-yw1-f67.google.com with SMTP id 4so4289856ywx.4; Sun, 24 Nov 2019 12:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M4Jt5yrKDU8F2fIaLcOguP/vgGp0gQsaGqz7ufIEi6I=; b=B92UTXX4Hw1rzeudiYXCoNOuQZgp3UVkc9TtbiHLeSGlLVCFuslndr3L21sCWJNUZR g/QWNw5pmDRxoK4VUeNsGmwJEZchiOrkVuCCC/gJM3vtUqhCHwUls5oknpZeqTh0uatw UAlaSgHkiA8JHnP5zraksKljDfcwWsJG8lBHfN4OxyTfZTbDVhh49GPA5mPthgn3ByNu kqlh+6zT+qlz8vVTCc9O4geXC/XcxGZpKKrpHBfixBJCGr38/XE+/fqDDCH0OjNitW3n O3s86E4xilXD1gqif+ybEUbaxyXbKmfaw5dzD7k69l72soqSmq+t6K/lEyYyc7C9dAmp 81Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M4Jt5yrKDU8F2fIaLcOguP/vgGp0gQsaGqz7ufIEi6I=; b=sFbw2WQKkQj4oWXnoUEiWojCxz3ffpA/+Iy2wU9iSUwaBqCqX7P1XxwDY2+YaOQO3e 38bMe7hPkdmnwQftDVXqaXJUT72pJzq7Ujr0ofyun0+DBZKCGazOmFHI6Pk/DN/rts5D uEDWDfengJpTM3cNGfB2VxQju2jRxnLdeXKZaFuBge8INyMJFaFRPLYEbonyGhEDA6d/ NqTHpIBgXEv2uLF3U9KPlvdS8JmH+o9LVFALwh05g8lmbASBv1Ml8xBSmZIq40/s9Xfa h5u1rPUbkUvfrtfRbe+FRycP6OF3trjtnxDMbeJsLozFle17y5sdaqbikjo3bHHinAXy UM8A== X-Gm-Message-State: APjAAAWCuoUAHKoNHmXhlGmyroWPw9Y7mYZBB56JfAZQzuFOdpkpqzDp iEmCAjREQmrP4Ilcwlfn7rKymnD/HLNc6WxEYZTOBQ== X-Google-Smtp-Source: APXvYqzLJipFAx0UYrDJ6Rm3/eyR3F9HzM7XHto0QkxHwcBc+WR9GbJhyiKDY7qRGKmt3yc+OD2/6mcxoCOWXLYsnzU= X-Received: by 2002:a81:58c6:: with SMTP id m189mr17689201ywb.25.1574628634187; Sun, 24 Nov 2019 12:50:34 -0800 (PST) MIME-Version: 1.0 References: <20191124193145.22945-1-amir73il@gmail.com> <20191124194934.GB4203@ZenIV.linux.org.uk> In-Reply-To: <20191124194934.GB4203@ZenIV.linux.org.uk> From: Amir Goldstein Date: Sun, 24 Nov 2019 22:50:23 +0200 Message-ID: Subject: Re: [PATCH] utimes: Clamp the timestamps in notify_change() To: Al Viro Cc: Arnd Bergmann , Deepa Dinamani , Jeff Layton , "J . Bruce Fields" , Miklos Szeredi , linux-fsdevel , overlayfs , Linux NFS Mailing List , y2038@lists.linaro.org Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Sun, Nov 24, 2019 at 9:49 PM Al Viro wrote: > > On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > > Push clamping timestamps down the call stack into notify_change(), so > > in-kernel callers like nfsd and overlayfs will get similar timestamp > > set behavior as utimes. > > Makes sense; said that, shouldn't we go through ->setattr() instances and > get rid of that there, now that notify_change() is made to do it? > Sounds reasonable. But I'd rather leave this cleanup to Deepa, who did all this work. Thanks, Amir.