linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ashish Sangwan <ashishsangwan2@gmail.com>
To: ffilz@redhat.com
Cc: linux-nfs@vger.kernel.org, neilb@suse.com
Subject: Re: Handling of duplicate inode numbers for the directories in the nfs v3 kernel client
Date: Fri, 14 Dec 2018 10:41:05 +0530	[thread overview]
Message-ID: <CAOiN93kfW2H_OEfUGxC4UKJPvn8Lo5Bpkf77UKcxHwWsBwEhXg@mail.gmail.com> (raw)
In-Reply-To: <09842ee0-9948-a5bd-a155-e0d6552b23bb@redhat.com>

On Thu, Dec 13, 2018 at 9:56 PM Frank Filz <ffilz@redhat.com> wrote:
>
> On 12/12/18 10:57 AM, Ashish Sangwan wrote:
> > Hi,
> >
> > Our NFS filer can sometimes return same inode number for different directories.
> > For example /mnt/dir1/dir2 and /mnt/dir3/dir4, in same rare cases dir2
> > and dir4 might end up returning the same inode number to the client.
> > Though it can never happen that inode numbers will be same for two
> > directories and also there parent is same. Can linux client handle
> > this case? What issues it can cause?
> > https://lkml.org/lkml/2006/10/2/346
> > I stumbled upon this thread where it is written that nfs client can
> > handle this but userspace will see inode collisions. Given that this
> > will happen only for directories, userspace utils logic might not get
> > affected from this as hardlinks on directories are not possible. But
> > the thread is really old. Wanted to confirm if this holds true even
> > now.
> >
> > Thanks,
> > Ashish
>
> The find tool will detect the collisions and report them, and if I
> recall it stops proceeding down the directory tree from the duplicate
> inode number. I know for sure I've seen it complain, and pretty sure I
> saw it stop descending the tree into the directory with the duplicate
> inode number.
>

True. Was just looking into the find code to check how they detect cycles.
They are using pair of "device node : inode number" so find will
certainly complain.

>
> Frank
>

  reply	other threads:[~2018-12-14  5:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 18:57 Handling of duplicate inode numbers for the directories in the nfs v3 kernel client Ashish Sangwan
2018-12-12 22:45 ` NeilBrown
2018-12-13  3:47   ` Ashish Sangwan
2018-12-13  3:55     ` NeilBrown
2019-01-10 20:33     ` J. Bruce Fields
2019-01-26  8:39       ` Ashish Sangwan
2018-12-13 16:26 ` Frank Filz
2018-12-14  5:11   ` Ashish Sangwan [this message]
2018-12-17 11:06     ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOiN93kfW2H_OEfUGxC4UKJPvn8Lo5Bpkf77UKcxHwWsBwEhXg@mail.gmail.com \
    --to=ashishsangwan2@gmail.com \
    --cc=ffilz@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).