linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever III <chuck.lever@oracle.com>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: Bruce Fields <bfields@fieldses.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: removed unused argument in nfsd_startup_generic()
Date: Thu, 15 Apr 2021 14:12:14 +0000	[thread overview]
Message-ID: <E093C02D-1EEF-4C8D-8265-52149FAE4922@oracle.com> (raw)
In-Reply-To: <b77da875-4a01-3f88-ef65-26ce2394becc@virtuozzo.com>



> On Apr 15, 2021, at 8:00 AM, Vasily Averin <vvs@virtuozzo.com> wrote:
> 
> Since commit 501cb1849f86 ("nfsd: rip out the raparms cache")
> nrservs is not used in nfsd_startup_generic()
> 
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>

Thanks for your patch. It's been added to the for-next topic branch in

git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git


> ---
> fs/nfsd/nfssvc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 6de4063..1669f5b 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -308,7 +308,7 @@ static int nfsd_init_socks(struct net *net, const struct cred *cred)
> 
> static int nfsd_users = 0;
> 
> -static int nfsd_startup_generic(int nrservs)
> +static int nfsd_startup_generic(void)
> {
> 	int ret;
> 
> @@ -374,7 +374,7 @@ void nfsd_reset_boot_verifier(struct nfsd_net *nn)
> 	write_sequnlock(&nn->boot_lock);
> }
> 
> -static int nfsd_startup_net(int nrservs, struct net *net, const struct cred *cred)
> +static int nfsd_startup_net(struct net *net, const struct cred *cred)
> {
> 	struct nfsd_net *nn = net_generic(net, nfsd_net_id);
> 	int ret;
> @@ -382,7 +382,7 @@ static int nfsd_startup_net(int nrservs, struct net *net, const struct cred *cre
> 	if (nn->nfsd_net_up)
> 		return 0;
> 
> -	ret = nfsd_startup_generic(nrservs);
> +	ret = nfsd_startup_generic();
> 	if (ret)
> 		return ret;
> 	ret = nfsd_init_socks(net, cred);
> @@ -758,7 +758,7 @@ int nfsd_set_nrthreads(int n, int *nthreads, struct net *net)
> 
> 	nfsd_up_before = nn->nfsd_net_up;
> 
> -	error = nfsd_startup_net(nrservs, net, cred);
> +	error = nfsd_startup_net(net, cred);
> 	if (error)
> 		goto out_destroy;
> 	error = nn->nfsd_serv->sv_ops->svo_setup(nn->nfsd_serv,
> -- 
> 1.8.3.1
> 

--
Chuck Lever




      reply	other threads:[~2021-04-15 14:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 12:00 [PATCH] nfsd: removed unused argument in nfsd_startup_generic() Vasily Averin
2021-04-15 14:12 ` Chuck Lever III [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E093C02D-1EEF-4C8D-8265-52149FAE4922@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=vvs@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).