From: Chuck Lever <chuck.lever@oracle.com>
To: Bruce Fields <bfields@fieldses.org>
Cc: linux-rdma@vger.kernel.org,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2] svcrdma: Ignore source port when computing DRC hash
Date: Wed, 19 Jun 2019 16:25:57 -0400 [thread overview]
Message-ID: <FAF5EE39-8B5D-4F5C-9E9E-8FCA6EED8378@oracle.com> (raw)
In-Reply-To: <20190611150116.4209.63309.stgit@klimt.1015granger.net>
> On Jun 11, 2019, at 11:01 AM, Chuck Lever <chuck.lever@oracle.com> wrote:
>
> The DRC appears to be effectively empty after an RPC/RDMA transport
> reconnect. The problem is that each connection uses a different
> source port, which defeats the DRC hash.
>
> Clients always have to disconnect before they send retransmissions
> to reset the connection's credit accounting, thus every retransmit
> on NFS/RDMA will miss the DRC.
>
> An NFS/RDMA client's IP source port is meaningless for RDMA
> transports. The transport layer typically sets the source port value
> on the connection to a random ephemeral port. The server already
> ignores it for the "secure port" check. See commit 16e4d93f6de7
> ("NFSD: Ignore client's source port on RDMA transports").
>
> The Linux NFS server's DRC resolves XID collisions from the same
> source IP address by using the checksum of the first 200 bytes of
> the RPC call header.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> Cc: stable@vger.kernel.org # v4.14+
> ---
> net/sunrpc/xprtrdma/svc_rdma_transport.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> index 027a3b0..0004535 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -211,9 +211,14 @@ static void handle_connect_req(struct rdma_cm_id *new_cma_id,
> /* Save client advertised inbound read limit for use later in accept. */
> newxprt->sc_ord = param->initiator_depth;
>
> - /* Set the local and remote addresses in the transport */
> sa = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr;
> svc_xprt_set_remote(&newxprt->sc_xprt, sa, svc_addr_len(sa));
> + /* The remote port is arbitrary and not under the control of the
> + * client ULP. Set it to a fixed value so that the DRC continues
> + * to be effective after a reconnect.
> + */
> + rpc_set_port((struct sockaddr *)&newxprt->sc_xprt.xpt_remote, 0);
> +
> sa = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr;
> svc_xprt_set_local(&newxprt->sc_xprt, sa, svc_addr_len(sa));
Hi Bruce, what's the disposition of this patch?
--
Chuck Lever
next prev parent reply other threads:[~2019-06-19 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 15:01 [PATCH v2] svcrdma: Ignore source port when computing DRC hash Chuck Lever
2019-06-19 20:25 ` Chuck Lever [this message]
2019-06-19 20:43 ` Bruce Fields
2019-06-19 20:44 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FAF5EE39-8B5D-4F5C-9E9E-8FCA6EED8378@oracle.com \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).