From: "Benjamin Coddington" <bcodding@redhat.com>
To: trondmy@kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 00/16] Readdir enhancements
Date: Wed, 04 Nov 2020 11:14:51 -0500 [thread overview]
Message-ID: <FEA7C67B-4091-4797-B05E-D762F0D0B3A1@redhat.com> (raw)
In-Reply-To: <20201103153329.531942-1-trondmy@kernel.org>
Hi Trond, these look great!
I'm doing some comparison testing before/after this set, and I'm getting
into some memory pressure on a client with 4G ram listing 1.5M dentries
with
12 char filenames.
It looks like before this set, the readdir code was a bit more resilient
in
the face of memory pressure, and I'm wondering if we've dropped a call
to
mark_page_accessed().
* Ben adds:
@@ -460,7 +461,8 @@ static int nfs_readdir_search_array(struct
nfs_readdir_descriptor *desc)
desc->last_cookie = array->last_cookie;
desc->current_index += array->size;
desc->page_index++;
- }
+ } else
+ mark_page_accessed(desc->page);
kunmap_atomic(array);
return status;
}
.. no, that's not any better. I'm still getting evicted pages (or, at
least, low-indexed pages that don't have PageUptodate() set), which
makes
it nearly impossible to finish listing this directory because we just
keep
invalidating the mapping.
Any ideas? I'll keep looking.
Ben
next prev parent reply other threads:[~2020-11-04 16:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 15:33 [PATCH v2 00/16] Readdir enhancements trondmy
2020-11-03 15:33 ` [PATCH v2 01/16] NFS: Ensure contents of struct nfs_open_dir_context are consistent trondmy
2020-11-03 15:33 ` [PATCH v2 02/16] NFS: Clean up readdir struct nfs_cache_array trondmy
2020-11-03 15:33 ` [PATCH v2 03/16] NFS: Clean up nfs_readdir_page_filler() trondmy
2020-11-03 15:33 ` [PATCH v2 04/16] NFS: Clean up directory array handling trondmy
2020-11-03 15:33 ` [PATCH v2 05/16] NFS: Don't discard readdir results trondmy
2020-11-03 15:33 ` [PATCH v2 06/16] NFS: Remove unnecessary kmap in nfs_readdir_xdr_to_array() trondmy
2020-11-03 15:33 ` [PATCH v2 07/16] NFS: Replace kmap() with kmap_atomic() in nfs_readdir_search_array() trondmy
2020-11-03 15:33 ` [PATCH v2 08/16] NFS: Simplify struct nfs_cache_array_entry trondmy
2020-11-03 15:33 ` [PATCH v2 09/16] NFS: Support larger readdir buffers trondmy
2020-11-03 15:33 ` [PATCH v2 10/16] NFS: More readdir cleanups trondmy
2020-11-03 15:33 ` [PATCH v2 11/16] NFS: nfs_do_filldir() does not return a value trondmy
2020-11-03 15:33 ` [PATCH v2 12/16] NFS: Reduce readdir stack usage trondmy
2020-11-03 15:33 ` [PATCH v2 13/16] NFS: Cleanup to remove nfs_readdir_descriptor_t typedef trondmy
2020-11-03 15:33 ` [PATCH v2 14/16] NFS: Allow the NFS generic code to pass in a verifier to readdir trondmy
2020-11-03 15:33 ` [PATCH v2 15/16] NFS: Handle NFS4ERR_NOT_SAME and NFSERR_BADCOOKIE from readdir calls trondmy
2020-11-03 15:33 ` [PATCH v2 16/16] NFS: Improve handling of directory verifiers trondmy
2020-11-04 10:12 ` Mkrtchyan, Tigran
2020-11-04 17:21 ` Trond Myklebust
2020-11-03 15:55 ` [PATCH v2 05/16] NFS: Don't discard readdir results Benjamin Coddington
2020-11-03 16:14 ` Trond Myklebust
2020-11-04 16:14 ` Benjamin Coddington [this message]
2020-11-04 17:04 ` [PATCH v2 00/16] Readdir enhancements Trond Myklebust
2020-11-04 17:19 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FEA7C67B-4091-4797-B05E-D762F0D0B3A1@redhat.com \
--to=bcodding@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).