From: Steve Dickson <steved@redhat.com>
To: Petr Vorel <petr.vorel@gmail.com>, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH 1/2] nfsdcltrack/sqlite: Fix printf format
Date: Mon, 26 Jul 2021 12:31:13 -0400 [thread overview]
Message-ID: <a186a8c6-26d5-e2e9-2950-8d4a743f901b@redhat.com> (raw)
In-Reply-To: <20210722161545.26923-1-petr.vorel@gmail.com>
On 7/22/21 12:15 PM, Petr Vorel wrote:
> sqlite.c: In function 'sqlite_remove_unreclaimed':
> sqlite.c:547:71: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'time_t' {aka 'long long int'} [-Werror=format=]
> 547 | ret = snprintf(buf, sizeof(buf), "DELETE FROM clients WHERE time < %ld",
> | ~~^
> | |
> | long int
> | %lld
> 548 | grace_start);
> | ~~~~~~~~~~~
> | |
> | time_t {aka long long int}
>
> Found in Buildroot riscv32 build.
>
> Link: http://autobuild.buildroot.net/results/9bc1d43a588338b7395af7bc97535ee16a6ea2d9/build-end.log
>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
Both Committed... (tag: nfs-utils-2-5-5-rc1)
steved
> ---
> utils/nfsdcltrack/sqlite.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/utils/nfsdcltrack/sqlite.c b/utils/nfsdcltrack/sqlite.c
> index f79aebb3..cea4a411 100644
> --- a/utils/nfsdcltrack/sqlite.c
> +++ b/utils/nfsdcltrack/sqlite.c
> @@ -46,6 +46,7 @@
> #include <sys/stat.h>
> #include <sys/types.h>
> #include <fcntl.h>
> +#include <inttypes.h>
> #include <unistd.h>
> #include <sqlite3.h>
> #include <linux/limits.h>
> @@ -544,7 +545,7 @@ sqlite_remove_unreclaimed(time_t grace_start)
> int ret;
> char *err = NULL;
>
> - ret = snprintf(buf, sizeof(buf), "DELETE FROM clients WHERE time < %ld",
> + ret = snprintf(buf, sizeof(buf), "DELETE FROM clients WHERE time < %"PRIu64,
> grace_start);
> if (ret < 0) {
> return ret;
>
prev parent reply other threads:[~2021-07-26 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 16:15 [nfs-utils PATCH 1/2] nfsdcltrack/sqlite: Fix printf format Petr Vorel
2021-07-22 16:15 ` [nfs-utils PATCH 2/2] nfsdcltrack/nfsdcltrack.c: " Petr Vorel
2021-07-26 16:31 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a186a8c6-26d5-e2e9-2950-8d4a743f901b@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=petr.vorel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).