From: Tom Talpey <tom@talpey.com>
To: Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 1/6] xprtrdma: Remove FMR support in rpcrdma_convert_iovs()
Date: Wed, 3 Feb 2021 13:06:49 -0500 [thread overview]
Message-ID: <a2a7d8a1-9372-04ac-7ad6-f29c34ef3804@talpey.com> (raw)
In-Reply-To: <161236943446.1030487.4542967452464402073.stgit@manet.1015granger.net>
On 2/3/2021 11:23 AM, Chuck Lever wrote:
> Support for FMR was removed by commit ba69cd122ece ("xprtrdma:
> Remove support for FMR memory registration") [Dec 2018]. That means
> the buffer-splitting behavior of rpcrdma_convert_kvec(), added by
> commit 821c791a0bde ("xprtrdma: Segment head and tail XDR buffers
> on page boundaries") [Mar 2016], is no longer necessary. FRWR
> memory registration handles this case with aplomb.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> net/sunrpc/xprtrdma/rpc_rdma.c | 19 ++++---------------
> 1 file changed, 4 insertions(+), 15 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c
> index 8f5d0cb68360..832765f3ebba 100644
> --- a/net/sunrpc/xprtrdma/rpc_rdma.c
> +++ b/net/sunrpc/xprtrdma/rpc_rdma.c
> @@ -204,9 +204,7 @@ rpcrdma_alloc_sparse_pages(struct xdr_buf *buf)
> return 0;
> }
>
> -/* Split @vec on page boundaries into SGEs. FMR registers pages, not
> - * a byte range. Other modes coalesce these SGEs into a single MR
> - * when they can.
> +/* Convert @vec to a single SGL element.
> *
> * Returns pointer to next available SGE, and bumps the total number
> * of SGEs consumed.
> @@ -215,21 +213,12 @@ static struct rpcrdma_mr_seg *
> rpcrdma_convert_kvec(struct kvec *vec, struct rpcrdma_mr_seg *seg,
> unsigned int *n)
> {
> - u32 remaining, page_offset;
> - char *base;
> -
> - base = vec->iov_base;
> - page_offset = offset_in_page(base);
> - remaining = vec->iov_len;
> - while (remaining) {
> + if (vec->iov_len) {
This is weird. Is it ever possible for a zero-length segment to be
passed? If so, it's obviously wrong to return an uninitialized "seg"
to the caller. I'd suggest simply asserting that iov_len is != 0.
I guess this was an issue in the existing code, but there, it would
only trigger if *all* the segs were zero.
> seg->mr_page = NULL;
> - seg->mr_offset = base;
> - seg->mr_len = min_t(u32, PAGE_SIZE - page_offset, remaining);
> - remaining -= seg->mr_len;
> - base += seg->mr_len;
> + seg->mr_offset = vec->iov_base;
I thought the previous discussion was that this should be offset_in_page
not the (virtual) iov_base.
Tom.
> + seg->mr_len = vec->iov_len;
> ++seg;
> ++(*n);
> - page_offset = 0;
> }
> return seg;
> }
>
>
>
next prev parent reply other threads:[~2021-02-03 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 16:23 [PATCH v2 0/6] RPC/RDMA client fixes Chuck Lever
2021-02-03 16:23 ` [PATCH v2 1/6] xprtrdma: Remove FMR support in rpcrdma_convert_iovs() Chuck Lever
2021-02-03 18:06 ` Tom Talpey [this message]
2021-02-03 18:09 ` Chuck Lever
2021-02-03 16:24 ` [PATCH v2 2/6] xprtrdma: Simplify rpcrdma_convert_kvec() and frwr_map() Chuck Lever
2021-02-03 18:07 ` Tom Talpey
2021-02-03 16:24 ` [PATCH v2 3/6] xprtrdma: Refactor invocations of offset_in_page() Chuck Lever
2021-02-03 18:09 ` Tom Talpey
2021-02-03 18:11 ` Chuck Lever
2021-02-03 18:19 ` Tom Talpey
2021-02-03 16:24 ` [PATCH v2 4/6] rpcrdma: Fix comments about reverse-direction operation Chuck Lever
2021-02-03 18:10 ` Tom Talpey
2021-02-03 16:24 ` [PATCH v2 5/6] xprtrdma: Pad optimization, revisited Chuck Lever
2021-02-03 18:13 ` Tom Talpey
2021-02-03 16:24 ` [PATCH v2 6/6] rpcrdma: Capture bytes received in Receive completion tracepoints Chuck Lever
2021-02-03 18:14 ` Tom Talpey
-- strict thread matches above, loose matches on Subject: below --
2021-02-03 16:20 [PATCH v2 0/6] Series short description Chuck Lever
2021-02-03 16:20 ` [PATCH v2 1/6] xprtrdma: Remove FMR support in rpcrdma_convert_iovs() Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2a7d8a1-9372-04ac-7ad6-f29c34ef3804@talpey.com \
--to=tom@talpey.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).