Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
From: Steve Dickson <SteveD@RedHat.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning
Date: Thu, 16 Jan 2020 15:07:00 -0500
Message-ID: <a9f351c6-22e5-35ef-7119-d261ef8d0159@RedHat.com> (raw)
In-Reply-To: <dd75fa26-a07a-49fb-ed22-1e60da31c8da@benettiengineering.com>



On 1/15/20 11:29 AM, Giulio Benetti wrote:
> Hi Steve,
> 
> you've missed this patch while applying the series. Can you please commit it?
It is in...

commit 6f4568f1f7395f967cc03995dcfb79a1ac5c11cd
Author: Giulio Benetti <giulio.benetti@benettiengineering.com>
Date:   Mon Jan 6 14:23:04 2020 -0500

    rpcgen: rpc_hout: fix potential -Wformat-security warning
    
    f_print()'s argument "separator" is not known because it's passed as an
    argument and with -Wformat-security will cause a useless warning. Let's
    ignore by adding "#pragma GCC diagnostic ignored/warning" before and
    after f_print().
    
    Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
    Signed-off-by: Steve Dickson <steved@redhat.com>

what am I missing?

steved.


  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03 21:50 [nfs-utils PATCH 0/7] silence some warning in rpcgen Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 1/7] rpcgen: rpc_cout: silence unused def parameter Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 2/7] rpcgen: rpc_util: add storeval args to prototype Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 3/7] rpcgen: rpc_util: add findval " Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 4/7] rpcgen: rpc_parse: add get_definition() void argument Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning Giulio Benetti
2020-01-15 16:29   ` Giulio Benetti
2020-01-16 20:07     ` Steve Dickson [this message]
2020-01-16 20:38       ` Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 6/7] rpcgen: rpc_hout: fix potential -Wformat-security warning Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 7/7] rpcgen: rpc_hout: fix indentation on f_print() argument separator Giulio Benetti
2020-01-07 19:06 ` [nfs-utils PATCH 0/7] silence some warning in rpcgen Steve Dickson
2020-01-09 14:00   ` Giulio Benetti
2020-01-09 15:10     ` Steve Dickson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9f351c6-22e5-35ef-7119-d261ef8d0159@RedHat.com \
    --to=steved@redhat.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org
	public-inbox-index linux-nfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git