From: Casey Schaufler <casey@schaufler-ca.com>
To: "linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
Tejun Heo <tj@kernel.org>
Cc: chandan.vn@samsung.com,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"bfields@fieldses.org" <bfields@fieldses.org>,
"jlayton@kernel.org" <jlayton@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
CPGS <cpgs@samsung.com>,
Sireesha Talluri <sireesha.t@samsung.com>,
Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH] Smack: Fix memory leak in smack_inode_getsecctx
Date: Mon, 4 Jun 2018 14:01:34 -0700 [thread overview]
Message-ID: <b6cc4bd5-8d79-bbc2-373f-ea0bf0806884@schaufler-ca.com> (raw)
In-Reply-To: <fa278910-5c99-11dc-c9cb-b88a97592e53@schaufler-ca.com>
On 6/1/2018 10:45 AM, Casey Schaufler wrote:
> Fix memory leak in smack_inode_getsecctx
>
> The implementation of smack_inode_getsecctx() made
> incorrect assumptions about how Smack presents a security
> context. Smack does not need to allocate memory to support
> security contexts, so "releasing" a Smack context is a no-op.
> The code made an unnecessary copy and returned that as a
> context, which was never freed. The revised implementation
> returns the context correctly.
>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Tejun, does this pass your tests?
> ---
> security/smack/smack_lsm.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 0b414836bebd..5e3beae334a8 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -1545,9 +1545,9 @@ static int smack_inode_listsecurity(struct inode *inode, char *buffer,
> */
> static void smack_inode_getsecid(struct inode *inode, u32 *secid)
> {
> - struct inode_smack *isp = inode->i_security;
> + struct smack_known *skp = smk_of_inode(inode);
>
> - *secid = isp->smk_inode->smk_secid;
> + *secid = skp->smk_secid;
> }
>
> /*
> @@ -4538,12 +4538,10 @@ static int smack_inode_setsecctx(struct dentry *dentry, void *ctx, u32 ctxlen)
>
> static int smack_inode_getsecctx(struct inode *inode, void **ctx, u32 *ctxlen)
> {
> - int len = 0;
> - len = smack_inode_getsecurity(inode, XATTR_SMACK_SUFFIX, ctx, true);
> + struct smack_known *skp = smk_of_inode(inode);
>
> - if (len < 0)
> - return len;
> - *ctxlen = len;
> + *ctx = skp->smk_known;
> + *ctxlen = strlen(skp->smk_known);
> return 0;
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2018-06-04 21:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180531092848epcas1p24b638ccd6da00f1e039bdb64de7e1a5b@epcas1p2.samsung.com>
2018-05-31 9:28 ` [PATCH 1/1] Fix memory leak in kernfs_security_xattr_set and kernfs_security_xattr_set CHANDAN VN
2018-05-31 15:26 ` Casey Schaufler
2018-05-31 20:57 ` Eric W. Biederman
2018-05-31 21:08 ` Casey Schaufler
2018-05-31 15:39 ` Tejun Heo
2018-05-31 16:04 ` Casey Schaufler
2018-05-31 16:11 ` Tejun Heo
2018-05-31 16:22 ` Casey Schaufler
[not found] ` <CGME20180531092848epcas1p24b638ccd6da00f1e039bdb64de7e1a5b@epcms5p5>
2018-06-01 8:56 ` CHANDAN VN
2018-06-01 16:22 ` Casey Schaufler
[not found] ` <CGME20180531092848epcas1p24b638ccd6da00f1e039bdb64de7e1a5b@epcms5p7>
2018-06-01 16:29 ` CHANDAN VN
2018-06-01 16:41 ` Casey Schaufler
2018-06-01 17:45 ` [PATCH] Smack: Fix memory leak in smack_inode_getsecctx Casey Schaufler
2018-06-04 21:01 ` Casey Schaufler [this message]
2018-06-04 21:27 ` Tejun Heo
[not found] ` <CGME20180531092848epcas1p24b638ccd6da00f1e039bdb64de7e1a5b@epcms5p3>
2018-06-05 7:04 ` CHANDAN VN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6cc4bd5-8d79-bbc2-373f-ea0bf0806884@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=bfields@fieldses.org \
--cc=chandan.vn@samsung.com \
--cc=chrisw@sous-sol.org \
--cc=cpgs@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sireesha.t@samsung.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).