Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces
@ 2020-06-28  9:24 Salvatore Bonaccorso
  2020-07-17 13:55 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Salvatore Bonaccorso @ 2020-06-28  9:24 UTC (permalink / raw)
  To: linux-nfs; +Cc: NeilBrown, Steve Dickson, Scott Mayhew, Salvatore Bonaccorso

Although whitespaces immediately before or after the "=" are ignored,
removing the extra whitespaces in some of the key=value assignments
makes the style more consistent.

At least since systemd v242-rc1[1] this has been clarified that
whitespaces immediately before and after the "=" are allowed.

 [1] https://github.com/systemd/systemd/commit/170342c90be07f418ab786718d95ef76289126a0

Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---
 systemd/nfs-server.service | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
index 24118d693965..06c1adb71692 100644
--- a/systemd/nfs-server.service
+++ b/systemd/nfs-server.service
@@ -1,18 +1,18 @@
 [Unit]
 Description=NFS server and services
 DefaultDependencies=no
-Requires= network.target proc-fs-nfsd.mount
-Requires= nfs-mountd.service
+Requires=network.target proc-fs-nfsd.mount
+Requires=nfs-mountd.service
 Wants=rpcbind.socket network-online.target
 Wants=rpc-statd.service nfs-idmapd.service
 Wants=rpc-statd-notify.service
 Wants=nfsdcld.service
 
-After= network-online.target local-fs.target
-After= proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
-After= nfs-idmapd.service rpc-statd.service
-After= nfsdcld.service
-Before= rpc-statd-notify.service
+After=network-online.target local-fs.target
+After=proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
+After=nfs-idmapd.service rpc-statd.service
+After=nfsdcld.service
+Before=rpc-statd-notify.service
 
 # GSS services dependencies and ordering
 Wants=auth-rpcgss-module.service
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces
  2020-06-28  9:24 [PATCH] nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces Salvatore Bonaccorso
@ 2020-07-17 13:55 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2020-07-17 13:55 UTC (permalink / raw)
  To: Salvatore Bonaccorso, linux-nfs; +Cc: NeilBrown, Scott Mayhew



On 6/28/20 5:24 AM, Salvatore Bonaccorso wrote:
> Although whitespaces immediately before or after the "=" are ignored,
> removing the extra whitespaces in some of the key=value assignments
> makes the style more consistent.
> 
> At least since systemd v242-rc1[1] this has been clarified that
> whitespaces immediately before and after the "=" are allowed.
> 
>  [1] https://github.com/systemd/systemd/commit/170342c90be07f418ab786718d95ef76289126a0
> 
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
Committed... (tag: nfs-utils-2-5-2-rc2)

steved.
> ---
>  systemd/nfs-server.service | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
> index 24118d693965..06c1adb71692 100644
> --- a/systemd/nfs-server.service
> +++ b/systemd/nfs-server.service
> @@ -1,18 +1,18 @@
>  [Unit]
>  Description=NFS server and services
>  DefaultDependencies=no
> -Requires= network.target proc-fs-nfsd.mount
> -Requires= nfs-mountd.service
> +Requires=network.target proc-fs-nfsd.mount
> +Requires=nfs-mountd.service
>  Wants=rpcbind.socket network-online.target
>  Wants=rpc-statd.service nfs-idmapd.service
>  Wants=rpc-statd-notify.service
>  Wants=nfsdcld.service
>  
> -After= network-online.target local-fs.target
> -After= proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
> -After= nfs-idmapd.service rpc-statd.service
> -After= nfsdcld.service
> -Before= rpc-statd-notify.service
> +After=network-online.target local-fs.target
> +After=proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
> +After=nfs-idmapd.service rpc-statd.service
> +After=nfsdcld.service
> +Before=rpc-statd-notify.service
>  
>  # GSS services dependencies and ordering
>  Wants=auth-rpcgss-module.service
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-28  9:24 [PATCH] nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces Salvatore Bonaccorso
2020-07-17 13:55 ` Steve Dickson

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org
	public-inbox-index linux-nfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git