From: Orion Poplawski <orion@nwra.com>
To: Steve Dickson <SteveD@RedHat.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files
Date: Wed, 8 May 2019 10:02:06 -0600 [thread overview]
Message-ID: <c32f477e-4389-6c97-573d-1faa45c2bcff@nwra.com> (raw)
In-Reply-To: <29ea93aa-9f20-9d09-c135-99f5976704db@RedHat.com>
[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]
On 5/8/19 9:54 AM, Steve Dickson wrote:
>
>
> On 5/8/19 10:58 AM, Orion Poplawski wrote:
>> This fixes:
>>
>> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
>> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
>> please update the unit file accordingly.
> Shouldn't the apps also be updated? I know there is a symbolic
> link... but just for completeness the pid files in both apps
> should be updated as well.
>
> steved.
I thought about that - but was concerned about legacy systems that still use
/var/run.
>>
>> Signed-off-by: Orion Poplawski <orion@nwra.com>
>> ---
>> systemd/nfs-blkmap.service | 2 +-
>> systemd/rpc-statd.service | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
>> index 2bbcee6..6aa45ba 100644
>> --- a/systemd/nfs-blkmap.service
>> +++ b/systemd/nfs-blkmap.service
>> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
>>
>> [Service]
>> Type=forking
>> -PIDFile=/var/run/blkmapd.pid
>> +PIDFile=/run/blkmapd.pid
>> ExecStart=/usr/sbin/blkmapd
>>
>> [Install]
>> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
>> index 3e92cf7..095629f 100644
>> --- a/systemd/rpc-statd.service
>> +++ b/systemd/rpc-statd.service
>> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
>> [Service]
>> Environment=RPC_STATD_NO_NOTIFY=1
>> Type=forking
>> -PIDFile=/var/run/rpc.statd.pid
>> +PIDFile=/run/rpc.statd.pid
>> ExecStart=/usr/sbin/rpc.statd
>> --
>> 1.8.3.1
>>
--
Orion Poplawski
Manager of NWRA Technical Systems 720-772-5637
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane orion@nwra.com
Boulder, CO 80301 https://www.nwra.com/
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3799 bytes --]
next prev parent reply other threads:[~2019-05-08 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 14:58 [PATCH] nfs-utils: Change /var/run -> /run in systemd service files Orion Poplawski
2019-05-08 15:54 ` Steve Dickson
2019-05-08 16:02 ` Orion Poplawski [this message]
2019-05-09 17:25 ` Steve Dickson
2019-05-10 15:07 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c32f477e-4389-6c97-573d-1faa45c2bcff@nwra.com \
--to=orion@nwra.com \
--cc=SteveD@RedHat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).