From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
"dcritch@redhat.com" <dcritch@redhat.com>,
"d.lesca@solinos.it" <d.lesca@solinos.it>
Subject: Re: [PATCH 1/2] nfsd: don't replace page in rq_pages if it's a continuation of last page
Date: Fri, 17 Mar 2023 13:23:55 -0400 [thread overview]
Message-ID: <c40c8cb067f0d33d0eb5cb70c236ec5402535990.camel@kernel.org> (raw)
In-Reply-To: <9EAA4947-0139-481D-8D0A-6DF30444342D@oracle.com>
On Fri, 2023-03-17 at 15:04 +0000, Chuck Lever III wrote:
>
> > On Mar 17, 2023, at 10:59 AM, Jeff Layton <jlayton@kernel.org> wrote:
> >
> > On Fri, 2023-03-17 at 14:16 +0000, Chuck Lever III wrote:
> >
> > > In the patch description, would you mention that this case
> > > arises if the READ request is not page-aligned?
> >
> > Does it though? I'm not sure that page alignment has that much to do
> > with it. I imagine you can hit this even with aligned I/Os.
>
> Maybe, but no-one has actually seen that. The vast majority of
> reports of this problem are with unaligned I/O, which POSIX OS
> NFS clients (like the Linux NFS client) usually avoid.
>
> I didn't mean to exclude the possibility of hitting this issue
> in other ways, but simply observing a common way it is hit.
>
An unaligned read will consume an extra page, so maybe it just makes it
more likely to overrun the array in that case?
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-03-17 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 10:56 [PATCH 1/2] nfsd: don't replace page in rq_pages if it's a continuation of last page Jeff Layton
2023-03-17 10:56 ` [PATCH 2/2] sunrpc: add bounds checking to svc_rqst_replace_page Jeff Layton
2023-03-17 13:44 ` Chuck Lever III
2023-03-17 13:52 ` Jeff Layton
2023-03-17 13:54 ` Chuck Lever III
2023-03-17 13:06 ` [PATCH 1/2] nfsd: don't replace page in rq_pages if it's a continuation of last page Jeff Layton
2023-03-17 14:16 ` Chuck Lever III
2023-03-17 14:59 ` Jeff Layton
2023-03-17 15:04 ` Chuck Lever III
2023-03-17 17:23 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c40c8cb067f0d33d0eb5cb70c236ec5402535990.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=d.lesca@solinos.it \
--cc=dcritch@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).