From: Trond Myklebust <trondmy@hammerspace.com>
To: "bcodding@redhat.com" <bcodding@redhat.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 4/5] NFS: Further optimisations for 'ls -l'
Date: Thu, 30 Sep 2021 14:51:13 +0000 [thread overview]
Message-ID: <d043f95fbc80b03cb923fbb8ee3c1d7804301ebd.camel@hammerspace.com> (raw)
In-Reply-To: <46C79084-3586-4B63-A55F-7A3B9ED547CE@redhat.com>
On Thu, 2021-09-30 at 10:29 -0400, Benjamin Coddington wrote:
> On 29 Sep 2021, at 16:35, Trond Myklebust wrote:
> > It is concerning, and indeed in our test we are seeing READDIR
> > amplification with these multiple process accesses. So scenarios
> > like
> > the one you describe above are exactly the kind of issue I was
> > looking
> > to fix with these patches.
>
> I spent some time trying to trigger the scenario I was concerned
> about, but
> I couldn't generate any op amplifications. Feel free to add my:
>
> Tested-by: Benjamin Coddington <bcodding@redhat.com>
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
>
Thanks Ben! I really appreciate your help.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2021-09-30 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 13:49 [PATCH 1/5] NFS: Don't set NFS_INO_DATA_INVAL_DEFER and NFS_INO_INVALID_DATA trondmy
2021-09-29 13:49 ` [PATCH 2/5] NFS: Ignore the directory size when marking for revalidation trondmy
2021-09-29 13:49 ` [PATCH 3/5] NFS: Fix up nfs_readdir_inode_mapping_valid() trondmy
2021-09-29 13:49 ` [PATCH 4/5] NFS: Further optimisations for 'ls -l' trondmy
2021-09-29 13:49 ` [PATCH 5/5] NFS: Fix dentry verifier races trondmy
2021-09-29 14:56 ` [PATCH 4/5] NFS: Further optimisations for 'ls -l' Benjamin Coddington
2021-09-29 16:23 ` Trond Myklebust
2021-09-29 20:21 ` Benjamin Coddington
2021-09-29 20:35 ` Trond Myklebust
2021-09-30 14:29 ` Benjamin Coddington
2021-09-30 14:51 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d043f95fbc80b03cb923fbb8ee3c1d7804301ebd.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=bcodding@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).