linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] Fix more function prototypes
@ 2022-09-16 21:43 Sam James
  2022-09-25  4:10 ` Sam James
  0 siblings, 1 reply; 3+ messages in thread
From: Sam James @ 2022-09-16 21:43 UTC (permalink / raw)
  To: Steve Dickson, linux-nfs; +Cc: Sam James

```
regex.c:545:43: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
struct trans_func *libnfsidmap_plugin_init()
                                          ^
                                           void
1 error generated.
```

See: 167f2336b06e1bcbf26f45f2ddc4a535fed4d393
Signed-off-by: Sam James <sam@gentoo.org>
---
 support/nfsidmap/regex.c | 2 +-
 utils/idmapd/idmapd.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/support/nfsidmap/regex.c b/support/nfsidmap/regex.c
index 958b4ac8..8424179f 100644
--- a/support/nfsidmap/regex.c
+++ b/support/nfsidmap/regex.c
@@ -542,7 +542,7 @@ struct trans_func regex_trans = {
 	.gss_princ_to_grouplist	= regex_gss_princ_to_grouplist,
 };
 
-struct trans_func *libnfsidmap_plugin_init()
+struct trans_func *libnfsidmap_plugin_init(void)
 {
 	return (&regex_trans);
 }
diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
index e79c124d..cd9a965f 100644
--- a/utils/idmapd/idmapd.c
+++ b/utils/idmapd/idmapd.c
@@ -867,7 +867,7 @@ nfsdreopen_one(struct idmap_client *ic)
 }
 
 static void
-nfsdreopen()
+nfsdreopen(void)
 {
 	nfsdreopen_one(&nfsd_ic[IC_NAMEID]);
 	nfsdreopen_one(&nfsd_ic[IC_IDNAME]);
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] Fix more function prototypes
  2022-09-16 21:43 [PATCH v2] Fix more function prototypes Sam James
@ 2022-09-25  4:10 ` Sam James
  2022-09-27 14:09   ` Steve Dickson
  0 siblings, 1 reply; 3+ messages in thread
From: Sam James @ 2022-09-25  4:10 UTC (permalink / raw)
  To: Steve Dickson, linux-nfs

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]



> On 16 Sep 2022, at 22:43, Sam James <sam@gentoo.org> wrote:
> 
> ```
> regex.c:545:43: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
> struct trans_func *libnfsidmap_plugin_init()
>                                          ^
>                                           void
> 1 error generated.
> ```
> 
> See: 167f2336b06e1bcbf26f45f2ddc4a535fed4d393
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
> support/nfsidmap/regex.c | 2 +-
> utils/idmapd/idmapd.c    | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

ping


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] Fix more function prototypes
  2022-09-25  4:10 ` Sam James
@ 2022-09-27 14:09   ` Steve Dickson
  0 siblings, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2022-09-27 14:09 UTC (permalink / raw)
  To: Sam James, linux-nfs



On 9/25/22 12:10 AM, Sam James wrote:
> 
> 
>> On 16 Sep 2022, at 22:43, Sam James <sam@gentoo.org> wrote:
>>
>> ```
>> regex.c:545:43: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>> struct trans_func *libnfsidmap_plugin_init()
>>                                           ^
>>                                            void
>> 1 error generated.
>> ```
>>
>> See: 167f2336b06e1bcbf26f45f2ddc4a535fed4d393
>> Signed-off-by: Sam James <sam@gentoo.org>
>> ---
>> support/nfsidmap/regex.c | 2 +-
>> utils/idmapd/idmapd.c    | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> ping
Thanks! Committed!

steved.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-27 14:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-16 21:43 [PATCH v2] Fix more function prototypes Sam James
2022-09-25  4:10 ` Sam James
2022-09-27 14:09   ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).