linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@RedHat.com>
To: Doug Nazar <nazard@nazar.ca>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsdcld: Fix printf format strings on 32bit
Date: Fri, 22 Nov 2019 10:50:06 -0500	[thread overview]
Message-ID: <e66b050b-4d09-891c-3630-29d6dbb21f8b@RedHat.com> (raw)
In-Reply-To: <20191119230920.10994-1-nazard@nazar.ca>



On 11/19/19 6:09 PM, Doug Nazar wrote:
> Signed-off-by: Doug Nazar <nazard@nazar.ca>
Committed... (tag: nfs-utils-2-4-3-rc2)

steved.
> ---
>  utils/nfsdcld/nfsdcld.c | 14 +++++++-------
>  utils/nfsdcld/sqlite.c  |  6 +++---
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/utils/nfsdcld/nfsdcld.c b/utils/nfsdcld/nfsdcld.c
> index b064336d..9297df51 100644
> --- a/utils/nfsdcld/nfsdcld.c
> +++ b/utils/nfsdcld/nfsdcld.c
> @@ -378,7 +378,7 @@ cld_not_implemented(struct cld_client *clnt)
>  	bsize = cld_message_size(cmsg);
>  	wsize = atomicio((void *)write, clnt->cl_fd, cmsg, bsize);
>  	if (wsize != bsize)
> -		xlog(L_ERROR, "%s: problem writing to cld pipe (%ld): %m",
> +		xlog(L_ERROR, "%s: problem writing to cld pipe (%zd): %m",
>  			 __func__, wsize);
>  
>  	/* reopen pipe, just to be sure */
> @@ -409,7 +409,7 @@ cld_get_version(struct cld_client *clnt)
>  	xlog(D_GENERAL, "Doing downcall with status %d", cmsg->cm_status);
>  	wsize = atomicio((void *)write, clnt->cl_fd, cmsg, bsize);
>  	if (wsize != bsize) {
> -		xlog(L_ERROR, "%s: problem writing to cld pipe (%ld): %m",
> +		xlog(L_ERROR, "%s: problem writing to cld pipe (%zd): %m",
>  			 __func__, wsize);
>  		ret = cld_pipe_open(clnt);
>  		if (ret) {
> @@ -459,7 +459,7 @@ reply:
>  	xlog(D_GENERAL, "Doing downcall with status %d", cmsg->cm_status);
>  	wsize = atomicio((void *)write, clnt->cl_fd, cmsg, bsize);
>  	if (wsize != bsize) {
> -		xlog(L_ERROR, "%s: problem writing to cld pipe (%ld): %m",
> +		xlog(L_ERROR, "%s: problem writing to cld pipe (%zd): %m",
>  			 __func__, wsize);
>  		ret = cld_pipe_open(clnt);
>  		if (ret) {
> @@ -498,7 +498,7 @@ reply:
>  			cmsg->cm_status);
>  	wsize = atomicio((void *)write, clnt->cl_fd, cmsg, bsize);
>  	if (wsize != bsize) {
> -		xlog(L_ERROR, "%s: problem writing to cld pipe (%ld): %m",
> +		xlog(L_ERROR, "%s: problem writing to cld pipe (%zd): %m",
>  			 __func__, wsize);
>  		ret = cld_pipe_open(clnt);
>  		if (ret) {
> @@ -548,7 +548,7 @@ reply:
>  			cmsg->cm_status);
>  	wsize = atomicio((void *)write, clnt->cl_fd, cmsg, bsize);
>  	if (wsize != bsize) {
> -		xlog(L_ERROR, "%s: problem writing to cld pipe (%ld): %m",
> +		xlog(L_ERROR, "%s: problem writing to cld pipe (%zd): %m",
>  			 __func__, wsize);
>  		ret = cld_pipe_open(clnt);
>  		if (ret) {
> @@ -607,7 +607,7 @@ reply:
>  	xlog(D_GENERAL, "Doing downcall with status %d", cmsg->cm_status);
>  	wsize = atomicio((void *)write, clnt->cl_fd, cmsg, bsize);
>  	if (wsize != bsize) {
> -		xlog(L_ERROR, "%s: problem writing to cld pipe (%ld): %m",
> +		xlog(L_ERROR, "%s: problem writing to cld pipe (%zd): %m",
>  			 __func__, wsize);
>  		ret = cld_pipe_open(clnt);
>  		if (ret) {
> @@ -667,7 +667,7 @@ reply:
>  	xlog(D_GENERAL, "Doing downcall with status %d", cmsg->cm_status);
>  	wsize = atomicio((void *)write, clnt->cl_fd, cmsg, bsize);
>  	if (wsize != bsize) {
> -		xlog(L_ERROR, "%s: problem writing to cld pipe (%ld): %m",
> +		xlog(L_ERROR, "%s: problem writing to cld pipe (%zd): %m",
>  			 __func__, wsize);
>  		ret = cld_pipe_open(clnt);
>  		if (ret) {
> diff --git a/utils/nfsdcld/sqlite.c b/utils/nfsdcld/sqlite.c
> index 23be7971..09518e22 100644
> --- a/utils/nfsdcld/sqlite.c
> +++ b/utils/nfsdcld/sqlite.c
> @@ -512,7 +512,7 @@ sqlite_startup_query_grace(void)
>  	current_epoch = tcur;
>  	recovery_epoch = trec;
>  	ret = 0;
> -	xlog(D_GENERAL, "%s: current_epoch=%lu recovery_epoch=%lu",
> +	xlog(D_GENERAL, "%s: current_epoch=%"PRIu64" recovery_epoch=%"PRIu64,
>  		__func__, current_epoch, recovery_epoch);
>  out:
>  	sqlite3_finalize(stmt);
> @@ -1223,7 +1223,7 @@ sqlite_grace_start(void)
>  
>  	current_epoch = tcur;
>  	recovery_epoch = trec;
> -	xlog(D_GENERAL, "%s: current_epoch=%lu recovery_epoch=%lu",
> +	xlog(D_GENERAL, "%s: current_epoch=%"PRIu64" recovery_epoch=%"PRIu64,
>  		__func__, current_epoch, recovery_epoch);
>  
>  out:
> @@ -1282,7 +1282,7 @@ sqlite_grace_done(void)
>  	}
>  
>  	recovery_epoch = 0;
> -	xlog(D_GENERAL, "%s: current_epoch=%lu recovery_epoch=%lu",
> +	xlog(D_GENERAL, "%s: current_epoch=%"PRIu64" recovery_epoch=%"PRIu64,
>  		__func__, current_epoch, recovery_epoch);
>  
>  out:
> 


      reply	other threads:[~2019-11-22 15:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 23:09 [PATCH] nfsdcld: Fix printf format strings on 32bit Doug Nazar
2019-11-22 15:50 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e66b050b-4d09-891c-3630-29d6dbb21f8b@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nazard@nazar.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).