Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
From: Thomas Deutschmann <whissi@gentoo.org>
To: linux-nfs@vger.kernel.org
Subject: nfs-utils: v3 mounts broken due to statx() returning EINVAL
Date: Tue, 8 Oct 2019 22:23:56 +0200
Message-ID: <ef1023fa-25e4-8ce7-945e-bc210e635e10@gentoo.org> (raw)

[-- Attachment #1.1: Type: text/plain, Size: 933 bytes --]

Hi,

we have some user reporting that NFS v3 mounts are broken
when using glibc-2.29 and linux-4.9.x (4.9.128) because
statx() with mask=STATX_BASIC_STATS returns EINVAL. 

Looks like this isn't happening with <nfs-utils-2.4.1 or
newer kernels.

The following workaround was confirmed to be working:

--- a/support/misc/xstat.c	2019-06-24 21:31:55.260371592 +0200
+++ b/support/misc/xstat.c	2019-06-24 21:32:29.098777436 +0200
@@ -47,6 +47,8 @@
 			statx_copy(statbuf, &stxbuf);
 			return 0;
 		}
+		if (errno == EINVAL)
+			errno = ENOSYS;
 		if (errno == ENOSYS)
 			statx_supported = 0;
 	} else


Bug: https://bugs.gentoo.org/688644

At the moment I have no clue whether this is kernel/glibc or
nfs-utils related; if the patch is safe to apply...

Any help is appreciated. Thanks!


-- 
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08 20:23 Thomas Deutschmann [this message]
2019-10-11 17:07 ` bfields

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef1023fa-25e4-8ce7-945e-bc210e635e10@gentoo.org \
    --to=whissi@gentoo.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org
	public-inbox-index linux-nfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git