Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
From: "Schumaker, Anna" <Anna.Schumaker@netapp.com>
To: "bfields@fieldses.org" <bfields@fieldses.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"zhangxiaoxu5@huawei.com" <zhangxiaoxu5@huawei.com>,
	"jlayton@kernel.org" <jlayton@kernel.org>,
	"trond.myklebust@hammerspace.com"
	<trond.myklebust@hammerspace.com>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH] SUNRPC: task should be exit if encode return EKEYEXPIRED more times
Date: Mon, 20 May 2019 17:59:01 +0000
Message-ID: <ef9ea7a98c8c4ac90c53d476df215ff6c866529a.camel@netapp.com> (raw)
In-Reply-To: <f3fcad81-1a0f-a59b-d67b-7d8a541be2c8@huawei.com>

Hi ZhangXiaoxu

Both of your patches have been merged into Linux 5.2-rc1.

Thanks for checking!
Anna

On Mon, 2019-05-13 at 09:48 +0800, zhangxiaoxu (A) wrote:
> ping.
> 
> On 5/4/2019 2:15 PM, zhangxiaoxu (A) wrote:
> > ping.
> > 
> > On 4/29/2019 5:32 PM, ZhangXiaoxu wrote:
> > > If the rpc.gssd always return cred success, but now the cred is
> > > expired, then the task will loop in call_refresh and call_transmit.
> > > 
> > > Exit the rpc task after retry.
> > > 
> > > Signed-off-by: ZhangXiaoxu <zhangxiaoxu5@huawei.com>
> > > ---
> > >   net/sunrpc/clnt.c | 9 ++++++++-
> > >   1 file changed, 8 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> > > index 8ff11dc..a32d3f1 100644
> > > --- a/net/sunrpc/clnt.c
> > > +++ b/net/sunrpc/clnt.c
> > > @@ -1793,7 +1793,14 @@ call_encode(struct rpc_task *task)
> > >               rpc_delay(task, HZ >> 4);
> > >               break;
> > >           case -EKEYEXPIRED:
> > > -            task->tk_action = call_refresh;
> > > +            if (!task->tk_cred_retry) {
> > > +                rpc_exit(task, task->tk_status);
> > > +            } else {
> > > +                task->tk_action = call_refresh;
> > > +                task->tk_cred_retry--;
> > > +                dprintk("RPC: %5u %s: retry refresh creds\n",
> > > +                    task->tk_pid, __func__);
> > > +            }
> > >               break;
> > >           default:
> > >               rpc_exit(task, task->tk_status);
> > > 
> > 
> > .
> > 

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29  9:32 ZhangXiaoxu
2019-05-04  6:15 ` zhangxiaoxu (A)
2019-05-13  1:48   ` zhangxiaoxu (A)
2019-05-20 17:59     ` Schumaker, Anna [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef9ea7a98c8c4ac90c53d476df215ff6c866529a.camel@netapp.com \
    --to=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=davem@davemloft.net \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    --cc=zhangxiaoxu5@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org linux-nfs@archiver.kernel.org
	public-inbox-index linux-nfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox