From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 419A3C04AB1 for ; Thu, 9 May 2019 17:25:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1803B20656 for ; Thu, 9 May 2019 17:25:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726659AbfEIRZV (ORCPT ); Thu, 9 May 2019 13:25:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56676 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726656AbfEIRZV (ORCPT ); Thu, 9 May 2019 13:25:21 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ECF863086203; Thu, 9 May 2019 17:25:20 +0000 (UTC) Received: from madhat.boston.devel.redhat.com (ovpn-117-18.phx2.redhat.com [10.3.117.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8E9345B680; Thu, 9 May 2019 17:25:20 +0000 (UTC) Subject: Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files To: Orion Poplawski , "linux-nfs@vger.kernel.org" References: <6a9ffa7d-f711-026f-d9f7-a680a86c553a@nwra.com> <29ea93aa-9f20-9d09-c135-99f5976704db@RedHat.com> From: Steve Dickson Message-ID: Date: Thu, 9 May 2019 13:25:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 09 May 2019 17:25:21 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 5/8/19 12:02 PM, Orion Poplawski wrote: > On 5/8/19 9:54 AM, Steve Dickson wrote: >> >> >> On 5/8/19 10:58 AM, Orion Poplawski wrote: >>> This fixes: >>> >>> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below >>> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid; >>> please update the unit file accordingly. >> Shouldn't the apps also be updated? I know there is a symbolic >> link... but just for completeness the pid files in both apps >> should be updated as well. >> >> steved. > > I thought about that - but was concerned about legacy systems that still use > /var/run. Any idea how long the symlink will be around? But I do see your point. steved. > >>> >>> Signed-off-by: Orion Poplawski >>> --- >>> systemd/nfs-blkmap.service | 2 +- >>> systemd/rpc-statd.service | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service >>> index 2bbcee6..6aa45ba 100644 >>> --- a/systemd/nfs-blkmap.service >>> +++ b/systemd/nfs-blkmap.service >>> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service >>> >>> [Service] >>> Type=forking >>> -PIDFile=/var/run/blkmapd.pid >>> +PIDFile=/run/blkmapd.pid >>> ExecStart=/usr/sbin/blkmapd >>> >>> [Install] >>> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service >>> index 3e92cf7..095629f 100644 >>> --- a/systemd/rpc-statd.service >>> +++ b/systemd/rpc-statd.service >>> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes >>> [Service] >>> Environment=RPC_STATD_NO_NOTIFY=1 >>> Type=forking >>> -PIDFile=/var/run/rpc.statd.pid >>> +PIDFile=/run/rpc.statd.pid >>> ExecStart=/usr/sbin/rpc.statd >>> -- >>> 1.8.3.1 >>> > >