Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
From: Trond Myklebust <trondmy@hammerspace.com>
To: "aglo@umich.edu" <aglo@umich.edu>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"neilb@suse.com" <neilb@suse.com>
Subject: Re: multipath patches
Date: Thu, 11 Jul 2019 21:13:34 +0000
Message-ID: <f614be728542c2cb9dd026a5e97b78d4e74a30af.camel@hammerspace.com> (raw)
In-Reply-To: <CAN-5tyG0jdyn8C11v6b8=v3d1p=WoMAhXrAw8mWGEUn-TVXJ=g@mail.gmail.com>

On Thu, 2019-07-11 at 16:33 -0400, Olga Kornievskaia wrote:
> On Thu, Jul 11, 2019 at 3:29 PM Trond Myklebust <
> trondmy@hammerspace.com> wrote:
> > On Thu, 2019-07-11 at 15:06 -0400, Olga Kornievskaia wrote:
> > > Hi Trond,
> > > 
> > > I see that you have nconnect patches in your testing branch (as
> > > well
> > > as your linux-next and I assume they are the same).  There is
> > > something wrong with that version. A mount hangs the machine.
> > > 
> > > [  132.143379] watchdog: BUG: soft lockup - CPU#0 stuck for 23s!
> > > [mount.nfs:2624]
> > > 
> > > I don't have such problems with the patch series that Neil has
> > > posted.
> > > 
> > > Thank you.
> > 
> > How are the patchsets different? As far as I know, all I did was
> > apply
> > the 3 patches that Neil added to my existing branch.
> 
> I'm not sure. I had a problem with your "multipath" branch before and
> I recall what I did is went back and redownloaded your posted
> patches.
> That was when I was testing performance. So if you haven't touched
> that branch and just used it I think it's the same problem.
> 
> In the current testing branch I don't see several patches that Neil
> has added (posted) to the mailing list. So I'm not sure what you mean
> you added 3 of his patches on top of yours. At most I can say maybe
> you added 2 of his (one that allows for v2 and v3 and another that
> does state operations on a single connection. There are no patches
> for
> sunrpc stats that were posted).
> 
> What I know is that if I revert your branch to
> bf11fbdb20b385157b046ea7781f04d0c62554a3 before patches and apply
> Neils patches. All is fine. I really don't want to debug a non-
> working
> version when there is one that works.

Sure, but that is not really an option given the rules for how trees in
linux-next are supposed to work. They are considered to be more or less
stable.

Anyhow, I think I've found the bug. Neil had silently fixed it in one
of my patches, so I've added an incremental patch that does more or
less what he did.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com



  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 19:06 Olga Kornievskaia
2019-07-11 19:29 ` Trond Myklebust
2019-07-11 20:33   ` Olga Kornievskaia
2019-07-11 21:13     ` Trond Myklebust [this message]
2019-07-12 16:39       ` Olga Kornievskaia
2019-07-12 17:18         ` Trond Myklebust
2019-07-12 18:02           ` Olga Kornievskaia
2019-07-12 19:09             ` Trond Myklebust

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f614be728542c2cb9dd026a5e97b78d4e74a30af.camel@hammerspace.com \
    --to=trondmy@hammerspace.com \
    --cc=aglo@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org linux-nfs@archiver.kernel.org
	public-inbox-index linux-nfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox