From: Frederic Barrat <fbarrat@linux.ibm.com>
To: "Alastair D'Silva" <alastair@au1.ibm.com>, alastair@d-silva.org
Cc: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Andrew Donnellan" <ajd@linux.ibm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Anton Blanchard" <anton@ozlabs.org>,
"Madhavan Srinivasan" <maddy@linux.vnet.ibm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Mahesh Salgaonkar" <mahesh@linux.vnet.ibm.com>,
"Vasant Hegde" <hegdevasant@linux.vnet.ibm.com>,
"Hari Bathini" <hbathini@linux.ibm.com>,
"Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Greg Kurz" <groug@kaod.org>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Hildenbrand" <david@redhat.com>,
"Oscar Salvador" <osalvador@suse.com>,
"Michal Hocko" <mhocko@suse.com>,
"Pavel Tatashin" <pasha.tatashin@soleen.com>,
"Wei Yang" <richard.weiyang@gmail.com>, "Qian Cai" <cai@lca.pw>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-mm@kvack.org
Subject: Re: [PATCH 07/10] ocxl: Save the device serial number in ocxl_fn
Date: Thu, 7 Nov 2019 19:18:59 +0100 [thread overview]
Message-ID: <11327e5f-bc88-620e-f119-495eb7d4b02f@linux.ibm.com> (raw)
In-Reply-To: <20191025044721.16617-8-alastair@au1.ibm.com>
Le 25/10/2019 à 06:47, Alastair D'Silva a écrit :
> From: Alastair D'Silva <alastair@d-silva.org>
>
> This patch retrieves the serial number of the card and makes it available
> to consumers of the ocxl driver via the ocxl_fn struct.
>
> Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
> ---
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> drivers/misc/ocxl/config.c | 46 ++++++++++++++++++++++++++++++++++++++
> include/misc/ocxl.h | 1 +
> 2 files changed, 47 insertions(+)
>
> diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c
> index fb0c3b6f8312..a9203c309365 100644
> --- a/drivers/misc/ocxl/config.c
> +++ b/drivers/misc/ocxl/config.c
> @@ -71,6 +71,51 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx)
> return 0;
> }
>
> +/**
> + * Find a related PCI device (function 0)
> + * @device: PCI device to match
> + *
> + * Returns a pointer to the related device, or null if not found
> + */
> +static struct pci_dev *get_function_0(struct pci_dev *dev)
> +{
> + unsigned int devfn = PCI_DEVFN(PCI_SLOT(dev->devfn), 0); // Look for function 0
> +
> + return pci_get_domain_bus_and_slot(pci_domain_nr(dev->bus),
> + dev->bus->number, devfn);
> +}
> +
> +static void read_serial(struct pci_dev *dev, struct ocxl_fn_config *fn)
> +{
> + u32 low, high;
> + int pos;
> +
> + pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DSN);
> + if (pos) {
> + pci_read_config_dword(dev, pos + 0x04, &low);
> + pci_read_config_dword(dev, pos + 0x08, &high);
> +
> + fn->serial = low | ((u64)high) << 32;
> +
> + return;
> + }
> +
> + if (PCI_FUNC(dev->devfn) != 0) {
> + struct pci_dev *related = get_function_0(dev);
> +
> + if (!related) {
> + fn->serial = 0;
> + return;
> + }
> +
> + read_serial(related, fn);
> + pci_dev_put(related);
> + return;
> + }
> +
> + fn->serial = 0;
> +}
> +
> static void read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
> {
> u16 val;
> @@ -208,6 +253,7 @@ int ocxl_config_read_function(struct pci_dev *dev, struct ocxl_fn_config *fn)
> int rc;
>
> read_pasid(dev, fn);
> + read_serial(dev, fn);
>
> rc = read_dvsec_tl(dev, fn);
> if (rc) {
> diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h
> index 6f7c02f0d5e3..9843051c3c5b 100644
> --- a/include/misc/ocxl.h
> +++ b/include/misc/ocxl.h
> @@ -46,6 +46,7 @@ struct ocxl_fn_config {
> int dvsec_afu_info_pos; /* offset of the AFU information DVSEC */
> s8 max_pasid_log;
> s8 max_afu_index;
> + u64 serial;
> };
>
> enum ocxl_endian {
>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2019-11-07 18:19 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 4:46 [PATCH 00/10] Add support for OpenCAPI SCM devices Alastair D'Silva
2019-10-25 4:46 ` [PATCH 01/10] memory_hotplug: Add a bounds check to __add_pages Alastair D'Silva
2019-10-25 4:46 ` [PATCH 02/10] nvdimm: remove prototypes for nonexistent functions Alastair D'Silva
2019-10-27 23:41 ` Andrew Donnellan
2019-11-07 17:56 ` Frederic Barrat
2019-11-15 4:30 ` Dan Williams
2019-10-25 4:46 ` [PATCH 03/10] powerpc: Add OPAL calls for LPC memory alloc/release Alastair D'Silva
2019-11-07 17:57 ` Frederic Barrat
2019-10-25 4:46 ` [PATCH 04/10] powerpc: Map & release OpenCAPI LPC memory Alastair D'Silva
2019-10-27 21:24 ` kbuild test robot
2019-10-27 21:59 ` kbuild test robot
2019-10-28 2:34 ` kbuild test robot
2019-10-29 1:49 ` Andrew Donnellan
2019-10-29 2:44 ` Alastair D'Silva
2019-10-29 2:47 ` Andrew Donnellan
2019-11-07 17:59 ` Frederic Barrat
2019-11-11 9:34 ` Aneesh Kumar K.V
2019-10-25 4:47 ` [PATCH 05/10] ocxl: Tally up the LPC memory on a link & allow it to be mapped Alastair D'Silva
2019-11-07 18:02 ` Frederic Barrat
2019-10-25 4:47 ` [PATCH 06/10] ocxl: Add functions to map/unmap LPC memory Alastair D'Silva
2019-11-07 18:05 ` Frederic Barrat
2019-10-25 4:47 ` [PATCH 07/10] ocxl: Save the device serial number in ocxl_fn Alastair D'Silva
2019-11-06 3:10 ` Andrew Donnellan
2019-11-07 18:18 ` Frederic Barrat [this message]
2019-10-25 4:47 ` [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory Alastair D'Silva
2019-10-27 22:19 ` kbuild test robot
2019-10-27 22:53 ` kbuild test robot
2019-10-28 1:12 ` [RFC PATCH] nvdimm: scm_get() can be static kbuild test robot
2019-11-11 11:14 ` [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory Aneesh Kumar K.V
2019-11-12 5:37 ` Dan Williams
2019-11-12 5:41 ` Dan Williams
2019-11-14 13:41 ` Frederic Barrat
2019-11-14 16:35 ` Dan Williams
2019-11-18 23:47 ` Andrew Donnellan
2019-11-19 0:04 ` Dan Williams
2019-11-19 2:48 ` Alastair D'Silva
2019-11-19 3:26 ` Andrew Donnellan
2019-11-19 4:41 ` Dan Williams
2019-11-18 23:01 ` Alastair D'Silva
2019-10-25 4:47 ` [PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal Alastair D'Silva
2019-10-28 2:43 ` Oliver O'Halloran
2019-11-08 7:10 ` Frederic Barrat
2020-01-31 4:56 ` Alastair D'Silva
2020-01-31 5:14 ` Dan Williams
2019-11-11 9:46 ` Aneesh Kumar K.V
2019-10-25 4:47 ` [PATCH 10/10] ocxl: Conditionally bind SCM devices to the generic OCXL driver Alastair D'Silva
2019-10-26 6:43 ` Christoph Hellwig
2019-11-06 3:46 ` Andrew Donnellan
2019-11-07 18:08 ` Frederic Barrat
2019-11-08 0:37 ` Alastair D'Silva
2019-10-25 7:57 ` [PATCH 00/10] Add support for OpenCAPI SCM devices Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11327e5f-bc88-620e-f119-495eb7d4b02f@linux.ibm.com \
--to=fbarrat@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alastair@au1.ibm.com \
--cc=alastair@d-silva.org \
--cc=anton@ozlabs.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=cai@lca.pw \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=groug@kaod.org \
--cc=hbathini@linux.ibm.com \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=paulus@samba.org \
--cc=richard.weiyang@gmail.com \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).