From mboxrd@z Thu Jan 1 00:00:00 1970 From: Barret Rhoden Subject: Re: [PATCH 2/2] kvm: Use huge pages for DAX-backed files Date: Tue, 13 Nov 2018 10:50:51 -0500 Message-ID: <20181113105051.2ffaf468@gnomeregan.cam.corp.google.com> References: <20181109203921.178363-1-brho@google.com> <20181109203921.178363-3-brho@google.com> <043a592d-6592-3053-15a0-68cc54a26deb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <043a592d-6592-3053-15a0-68cc54a26deb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: David Hildenbrand Cc: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, yu.c.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Radim =?UTF-8?B?S3LEjW3DocWZ?= , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar , Borislav Petkov , Ross Zwisler , Paolo Bonzini , "H. Peter Anvin" , Thomas Gleixner , yi.z.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-nvdimm@lists.01.org On 2018-11-13 at 10:36 David Hildenbrand wrote: > > Note that KVM already faulted in the page (or huge page) in the host's > > page table, and we hold the KVM mmu spinlock (grabbed before checking > > the mmu seq). > > I wonder if the KVM mmu spinlock is enough for walking (not KVM > exclusive) host page tables. Can you elaborate? I'll update the commit message with the info from Paolo's email (about kvm_mmu_notifier_invalidate_range_end()). Thanks, Barret