From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F3DA2119926B for ; Tue, 11 Dec 2018 06:41:46 -0800 (PST) Date: Tue, 11 Dec 2018 09:41:40 -0500 From: Steven Rostedt Subject: Re: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel Message-ID: <20181211094140.2a928fe7@gandalf.local.home> In-Reply-To: <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-12-brendanhiggins@google.com> <841cf4ae-501b-05ae-5863-a51010709b67@ideasonboard.com> <20181204204701.GT28501@garbanzo.do-not-panic.com> <20181206153718.GD24603@bombadil.infradead.org> <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Petr Mladek Cc: brakmo@fb.com, Knut Omang , jeffm@suse.com, Brendan Higgins , dri-devel@lists.freedesktop.org, Sasha Levin , Linux Trace Devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , Frank Rowand , linux-nvdimm@lists.01.org, mpe@ellerman.id.au, Eric Sandeen , Kieran Bingham , Matthew Wilcox , Felix Guo , Joel Stanley , Kent Overstreet , jdike@addtoit.com, Tim.Bird@sony.com, linux-um@lists.infradead.org, Julia Lawall , kunit-dev@googlegroups.com, richard@nod.at, Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Eryu Guan , Daniel Vetter , Kees Cook , joe@perches.com, linux-fsdevel@vger.kernel.org, khilman@baylibre.com List-ID: On Tue, 11 Dec 2018 15:09:26 +0100 Petr Mladek wrote: > > We have liburcu already, which is good. The main sticking points are: > > > > - printk has started adding a lot of %pX enhancements which printf > > obviously doesn't know about. > > I wonder how big problem it is and if it is worth using another > approach. No, please do not change the %pX approach. > > An alternative would be to replace them with helper functions > the would produce the same string. The meaning would be easier > to understand. But concatenating with the surrounding text > would be less elegant. People might start using pr_cont() > that is problematic (mixed lines). > > Also the %pX formats are mostly used to print context of some > structures. Even the helper functions would need some maintenance > to keep them compatible. > > BTW: The printk() feature has been introduced 10 years ago by > the commit 4d8a743cdd2690c0bc8 ("vsprintf: add infrastructure > support for extended '%p' specifiers"). trace-cmd and perf know about most of the %pX data and how to read it. Perhaps we can extend the libtraceevent library to export a generic way to read data from printk() output for other tools to use. -- Steve _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm