From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3715F202E531F for ; Thu, 14 Feb 2019 09:26:45 -0800 (PST) Received: by mail-pg1-f193.google.com with SMTP id w7so3370419pgp.13 for ; Thu, 14 Feb 2019 09:26:45 -0800 (PST) Date: Thu, 14 Feb 2019 09:26:39 -0800 From: Luis Chamberlain Subject: Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit Message-ID: <20190214172639.GD11489@garbanzo.do-not-panic.com> References: <20181128193636.254378-15-brendanhiggins@google.com> <20181130034525.GP18410@garbanzo.do-not-panic.com> <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> <57c3dc86-236f-e981-249a-8bbfe5c19f0e@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: brakmo@fb.com, dri-devel , Michael Ellerman , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , Frank Rowand , linux-nvdimm , Richard Weinberger , Knut Omang , Kieran Bingham , Felix Guo , Joel Stanley , Jeff Dike , "Bird, Timothy" , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , kunit-dev@googlegroups.com, Greg KH , Linux Kernel Mailing List , Daniel Vetter , Kees Cook , Joe Perches , Kevin Hilman List-ID: On Wed, Feb 13, 2019 at 04:17:13PM -0800, Brendan Higgins wrote: > On Wed, Feb 13, 2019 at 1:55 PM Kieran Bingham > wrote: > Oh, yep, you are right. Does that mean we should bother at all with a defconfig? If one wanted a qemu enabled type of kernel and also for kuniut one could imply run: make kvmconfig make kunitconfig That would get what you suggest above of default "bells and whistles" and keep the kuniut as a fragment. Hm, actually the kvmconfig doesn't really enable the required fragments for qemu, so perhaps one would be good. It would have the serial stuff for instance. > Luis, I know you said you wanted one. I am thinking just stick with > the UML one? The downside there is we then get stuck having to > maintain the fragment and the defconfig. I right now (in the new > revision I am working on) have the Python kunit_tool copy the > defconfig if no kunitconfig is provided and a flag is set. It would be > pretty straightforward to make it merge in the fragment instead. Up to you in the end. Luis _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm