From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E865212B5EE4 for ; Mon, 15 Jul 2019 13:53:30 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20190712081744.87097-1-brendanhiggins@google.com> <20190712081744.87097-3-brendanhiggins@google.com> <20190715202425.CE64C20665@mail.kernel.org> From: Stephen Boyd Subject: Re: [PATCH v9 02/18] kunit: test: add test resource management API Date: Mon, 15 Jul 2019 13:51:00 -0700 Message-Id: <20190715205101.AB55B2145D@mail.kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: Petr Mladek , "open list:DOCUMENTATION" , Peter Zijlstra , Amir Goldstein , dri-devel , Sasha Levin , Masahiro Yamada , Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , shuah , Rob Herring , linux-nvdimm , Frank Rowand , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild , "Bird, Timothy , linux-um@lists.infradead.org, Steven Rostedt" , Julia Lawall , Josh Poimboeuf , kunit-dev@googlegroups.com, Theodore Ts'o , Richard Weinberger , Greg KH , Randy Dunlap , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org, Kevin Hilman List-ID: Quoting Brendan Higgins (2019-07-15 13:30:22) > On Mon, Jul 15, 2019 at 1:24 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-07-12 01:17:28) > > > diff --git a/kunit/test.c b/kunit/test.c > > > index 571e4c65deb5c..f165c9d8e10b0 100644 > > > One solution would be to piggyback on all the existing devres allocation > > logic we already have and make each struct kunit a device that we pass > > into the devres functions. A far simpler solution would be to just > > copy/paste what devres does and use a spinlock and an allocation > > function that takes GFP flags. > > Yeah, that's what I did originally, but I thought from the discussion > on patch 01 that you thought a spinlock was overkill for struct kunit. > I take it you only meant in that initial patch? Correct. I was only talking about the success bit in there. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm