From: Stephen Boyd <sboyd@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: Petr Mladek <pmladek@suse.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Amir Goldstein <amir73il@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Sasha Levin <Alexander.Levin@microsoft.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michael Ellerman <mpe@ellerman.id.au>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>, shuah <shuah@kernel.org>,
Rob Herring <robh@kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Frank Rowand <frowand.list@gmail.com>,
Knut Omang <knut.omang@oracle.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
wfg@linux.intel.com, Joel Stanley <joel@jms.id.au>,
David Rientjes <rientjes@google.com>,
Jeff Dike <jdike@addtoit.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
devicetree <devicetree@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
"Bird, Timothy <Tim.Bird@sony.com>,
linux-um@lists.infradead.org,
Steven Rostedt" <rostedt@goodmis.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Josh Poimboeuf <jpoimboe@redhat.com>,
kunit-dev@googlegroups.com, Theodore Ts'o <tytso@mit.edu>,
Richard Weinberger <richard@nod.at>,
Greg KH <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, Kees Cook <keescook@google.com>,
linux-fsdevel@vger.kernel.org,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder
Date: Mon, 15 Jul 2019 15:04:06 -0700 [thread overview]
Message-ID: <20190715220407.0030420665@mail.kernel.org> (raw)
In-Reply-To: <CAFd5g47481sRaez=yEJN4_ghiXZbxayk1Y04tAZpuzPLsmnhKg@mail.gmail.com>
Quoting Brendan Higgins (2019-07-15 14:11:50)
> On Mon, Jul 15, 2019 at 1:43 PM Stephen Boyd <sboyd@kernel.org> wrote:
> >
> > I also wonder if it would be better to just have a big slop buffer of a
> > 4K page or something so that we almost never have to allocate anything
> > with a string_stream and we can just rely on a reader consuming data
> > while writers are writing. That might work out better, but I don't quite
> > understand the use case for the string stream.
>
> That makes sense, but might that also waste memory since we will
> almost never need that much memory?
Why do we care? These are unit tests. Having allocations in here makes
things more complicated, whereas it would be simpler to have a pointer
and a spinlock operating on a chunk of memory that gets flushed out
periodically.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-07-15 22:06 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 8:17 [PATCH v9 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 02/18] kunit: test: add test resource management API Brendan Higgins
2019-07-15 20:24 ` Stephen Boyd
2019-07-15 20:30 ` Brendan Higgins
2019-07-15 20:51 ` Stephen Boyd
2019-07-12 8:17 ` [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder Brendan Higgins
2019-07-15 20:43 ` Stephen Boyd
2019-07-15 21:11 ` Brendan Higgins
2019-07-15 22:04 ` Stephen Boyd [this message]
2019-07-15 22:11 ` Brendan Higgins
2019-07-15 22:43 ` Brendan Higgins
2019-07-16 15:33 ` Stephen Boyd
2019-07-16 18:55 ` Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger Brendan Higgins
2019-07-15 22:15 ` Stephen Boyd
2019-07-16 7:57 ` Brendan Higgins
2019-07-16 8:37 ` Brendan Higgins
2019-07-16 15:30 ` Stephen Boyd
2019-07-16 17:51 ` Brendan Higgins
2019-07-16 17:50 ` Stephen Boyd
2019-07-16 18:52 ` Brendan Higgins
2019-07-18 17:50 ` Stephen Boyd
[not found] ` <20190718175024.C3EC421019-+nuXSHJNwjE76Z2rM5mHXA@public.gmane.org>
2019-07-18 19:22 ` Brendan Higgins
2019-07-19 0:08 ` Brendan Higgins
2019-07-22 18:10 ` Brendan Higgins
2019-07-22 20:03 ` Stephen Boyd
[not found] ` <20190722200347.261D3218C9-+nuXSHJNwjE76Z2rM5mHXA@public.gmane.org>
2019-07-22 22:30 ` Brendan Higgins
2019-07-22 23:54 ` Stephen Boyd
[not found] ` <20190722235411.06C1320840-+nuXSHJNwjE76Z2rM5mHXA@public.gmane.org>
2019-07-23 0:32 ` Brendan Higgins
2019-07-24 7:31 ` Petr Mladek
2019-07-25 20:21 ` Brendan Higgins
2019-07-26 8:31 ` Petr Mladek
2019-08-01 18:55 ` Brendan Higgins
[not found] ` <CAFd5g46iAhDZ5C_chi7oYLVOkwcoj6+0nw+kPWuXhqWwWKd9jA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-08-01 18:59 ` Brendan Higgins
[not found] ` <CAFd5g473iFfvBnJs2pcwuJYgY+DpgD6RLzyDFL1otUuScgKUag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-08-01 21:14 ` Stephen Boyd
2019-08-01 21:43 ` Brendan Higgins
2019-08-12 20:41 ` Brendan Higgins
2019-08-02 7:37 ` John Ogness
2019-08-12 21:12 ` Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 08/18] objtool: add kunit_try_catch_throw to the noreturn list Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 10/18] kunit: test: add tests for kunit test abort Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 11/18] kunit: test: add the concept of assertions Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 12/18] kunit: test: add tests for KUnit managed resources Brendan Higgins
[not found] ` <20190712081744.87097-1-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-07-12 8:17 ` [PATCH v9 01/18] kunit: test: add KUnit test runner core Brendan Higgins
2019-07-15 20:10 ` Stephen Boyd
2019-07-15 21:25 ` Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 05/18] kunit: test: add the concept of expectations Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 06/18] kbuild: enable building KUnit Brendan Higgins
[not found] ` <20190712081744.87097-7-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-07-15 20:49 ` Stephen Boyd
2019-07-12 8:17 ` [PATCH v9 07/18] kunit: test: add initial tests Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 09/18] kunit: test: add support for test abort Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 13/18] kunit: tool: add Python wrappers for running KUnit tests Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 14/18] kunit: defconfig: add defconfigs for building " Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 15/18] Documentation: kunit: add documentation for KUnit Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 16/18] MAINTAINERS: add entry for KUnit the unit testing framework Brendan Higgins
2019-07-12 8:17 ` [PATCH v9 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715220407.0030420665@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=amir73il@gmail.com \
--cc=brendanhiggins@google.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=joel@jms.id.au \
--cc=jpoimboe@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@google.com \
--cc=khilman@baylibre.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=knut.omang@oracle.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mcgrof@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=rientjes@google.com \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tytso@mit.edu \
--cc=wfg@linux.intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).