From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
Cc: qi.fuli@fujitsu.com, gujx@cn.fujitsu.com,
darrick.wong@oracle.com, linux-nvdimm@lists.01.org,
david@fromorbit.com, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [RFC PATCH 0/7] xfs: add reflink & dedupe support for fsdax.
Date: Wed, 31 Jul 2019 15:33:24 -0500 [thread overview]
Message-ID: <20190731203324.7vjwlejmwpghpvqi@fiona> (raw)
In-Reply-To: <20190731114935.11030-1-ruansy.fnst@cn.fujitsu.com>
On 19:49 31/07, Shiyang Ruan wrote:
> This patchset aims to take care of this issue to make reflink and dedupe
> work correctly in XFS.
>
> It is based on Goldwyn's patchsets: "v4 Btrfs dax support" and "Btrfs
> iomap". I picked up some patches related and made a few fix to make it
> basically works fine.
>
> For dax framework:
> 1. adapt to the latest change in iomap.
>
> For XFS:
> 1. report the source address and set IOMAP_COW type for those write
> operations that need COW.
> 2. update extent list at the end.
> 3. add file contents comparison function based on dax framework.
> 4. use xfs_break_layouts() to support dax.
Shiyang,
I think you used the older patches which does not contain the iomap changes
which would call iomap_begin() with two iomaps. I have it in the btrfs-iomap
branch and plan to update it today. It is built on v5.3-rcX, so it should
contain the changes which moves the iomap code to the different directory.
I will build the dax patches on top of that.
However, we are making a big dependency chain here :(
--
Goldwyn
>
>
> Goldwyn Rodrigues (3):
> dax: replace mmap entry in case of CoW
> fs: dedup file range to use a compare function
> dax: memcpy before zeroing range
>
> Shiyang Ruan (4):
> dax: Introduce dax_copy_edges() for COW.
> dax: copy data before write.
> xfs: Add COW handle for fsdax.
> xfs: Add dedupe support for fsdax.
>
> fs/btrfs/ioctl.c | 11 ++-
> fs/dax.c | 203 ++++++++++++++++++++++++++++++++++++++----
> fs/iomap.c | 9 +-
> fs/ocfs2/file.c | 2 +-
> fs/read_write.c | 11 +--
> fs/xfs/xfs_iomap.c | 42 +++++----
> fs/xfs/xfs_reflink.c | 84 +++++++++--------
> include/linux/dax.h | 15 ++--
> include/linux/fs.h | 8 +-
> include/linux/iomap.h | 6 ++
> 10 files changed, 294 insertions(+), 97 deletions(-)
>
> --
> 2.17.0
>
>
>
--
Goldwyn
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-07-31 20:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 11:49 [RFC PATCH 0/7] xfs: add reflink & dedupe support for fsdax Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 1/7] dax: Introduce dax_copy_edges() for COW Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 2/7] dax: copy data before write Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 3/7] dax: replace mmap entry in case of CoW Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 4/7] fs: dedup file range to use a compare function Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 5/7] dax: memcpy before zeroing range Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 6/7] xfs: Add COW handle for fsdax Shiyang Ruan
2019-07-31 11:49 ` [RFC PATCH 7/7] xfs: Add dedupe support " Shiyang Ruan
2019-07-31 20:33 ` Goldwyn Rodrigues [this message]
2019-08-01 1:37 ` [RFC PATCH 0/7] xfs: add reflink & " Shiyang Ruan
2019-08-05 0:21 ` Dave Chinner
2019-10-09 6:31 ` Christoph Hellwig
2019-10-09 17:11 ` Darrick J. Wong
2019-10-10 7:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731203324.7vjwlejmwpghpvqi@fiona \
--to=rgoldwyn@suse.de \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=gujx@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=qi.fuli@fujitsu.com \
--cc=ruansy.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).