From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 41825203042F4 for ; Wed, 14 Aug 2019 10:25:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20190814055108.214253-1-brendanhiggins@google.com> Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework From: Stephen Boyd Date: Wed, 14 Aug 2019 10:23:00 -0700 Message-Id: <20190814172301.9246520665@mail.kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins , Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Luis Chamberlain , Masahiro Yamada , Peter Zijlstra , Rob Herring , Theodore Ts'o , shuah Cc: Petr Mladek , "open list:DOCUMENTATION" , Amir Goldstein , dri-devel , Sasha Levin , at@ml01.01.org, "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , Kevin Hilman , Knut Omang , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild , "Bird, Timothy" , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Bjorn Helgaas , kunit-dev@googlegroups.com, Richard Weinberger , Randy Dunlap , Linux Kernel Mailing List , Daniel Vetter , Michael Ellerman , linux-fsdevel@vger.kernel.org List-ID: Quoting Brendan Higgins (2019-08-14 03:03:47) > On Tue, Aug 13, 2019 at 10:52 PM Brendan Higgins > wrote: > > > > ## TL;DR > > > > This revision addresses comments from Stephen and Bjorn Helgaas. Most > > changes are pretty minor stuff that doesn't affect the API in anyway. > > One significant change, however, is that I added support for freeing > > kunit_resource managed resources before the test case is finished via > > kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke > > KUnit on certain configurations (like the default one for x86, whoops). > > > > Based on Stephen's feedback on the previous change, I think we are > > pretty close. I am not expecting any significant changes from here on > > out. > > Stephen, it looks like you have just replied with "Reviewed-bys" on > all the remaining emails that you looked at. Is there anything else > that we are missing? Or is this ready for Shuah to apply? > I think it's good to go! Thanks for the persistence. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm