From: Ira Weiny <ira.weiny@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [PATCH V3] libnvdimm/namsepace: Don't set claim_class on error
Date: Thu, 26 Sep 2019 10:15:08 -0700 [thread overview]
Message-ID: <20190926171507.GA26275@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20190926061257.GE29696@kadam>
On Thu, Sep 26, 2019 at 09:12:57AM +0300, Dan Carpenter wrote:
> On Wed, Sep 25, 2019 at 02:13:48PM -0700, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > Don't leave claim_class set to an invalid value if an error occurs in
> > btt_claim_class().
> >
> > While we are here change the return type of __holder_class_store() to be
> > clear about the values it is returning.
> >
> > This was found via code inspection.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> >
> > ---
> > V1->V2
> > Add space after variable declaration...
> >
> > V2->V3
> > Fix oneliner
> > Rebase without Dan Carpenter's patch and give him Reported-by
> > credit
>
> Thanks! Btw, if it's ever a question of "do you want to redo a patch or
> just transfer to reported by credit?" then always I always want the #2
> option. It would have taken me several iterations to generate the patch
> you wanted.
Thanks for letting me know!
And thanks for finding this as well. :-D
Ira
>
> regards,
> dan carpenter
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2019-09-26 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 21:13 [PATCH V3] libnvdimm/namsepace: Don't set claim_class on error ira.weiny
2019-09-26 6:12 ` Dan Carpenter
2019-09-26 17:15 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926171507.GA26275@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).