From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: dan.j.williams@intel.com, mpe@ellerman.id.au
Cc: linux-nvdimm@lists.01.org, linuxppc-dev@lists.ozlabs.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Subject: [RFC PATCH 3/4] libnvdimm/namespace: Use direct-mapping page size to validate namespace size
Date: Mon, 28 Oct 2019 15:18:24 +0530 [thread overview]
Message-ID: <20191028094825.21448-3-aneesh.kumar@linux.ibm.com> (raw)
In-Reply-To: <20191028094825.21448-1-aneesh.kumar@linux.ibm.com>
Architectures like ppc64 use different page size than PAGE_SIZE to map
direct-map address range. The kernel needs to make sure the namespace size is aligned
correctly for the direct-map page size.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
drivers/nvdimm/namespace_devs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
index fcde9f2bf2ea..83c70631a86f 100644
--- a/drivers/nvdimm/namespace_devs.c
+++ b/drivers/nvdimm/namespace_devs.c
@@ -975,7 +975,8 @@ static ssize_t __size_store(struct device *dev, unsigned long long val)
struct nd_mapping *nd_mapping;
struct nvdimm_drvdata *ndd;
struct nd_label_id label_id;
- u32 flags = 0, remainder;
+ unsigned long map_size;
+ u32 flags = 0;
int rc, i, id = -1;
u8 *uuid = NULL;
@@ -1006,10 +1007,9 @@ static ssize_t __size_store(struct device *dev, unsigned long long val)
return -ENXIO;
}
- div_u64_rem(val, PAGE_SIZE * nd_region->ndr_mappings, &remainder);
- if (remainder) {
- dev_dbg(dev, "%llu is not %ldK aligned\n", val,
- (PAGE_SIZE * nd_region->ndr_mappings) / SZ_1K);
+ map_size = arch_validate_namespace_size(nd_region->ndr_mappings, val);
+ if (map_size) {
+ dev_err(dev, "%llu is not %ldK aligned\n", val, map_size / SZ_1K);
return -EINVAL;
}
--
2.21.0
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2019-10-28 9:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 9:48 [RFC PATCH 1/4] libnvdimm/namespace: Make namespace size validation arch dependent Aneesh Kumar K.V
2019-10-28 9:48 ` [RFC PATCH 2/4] libnvdimm/namespace: Disable the region if the namespace size is not aligned correctly Aneesh Kumar K.V
2019-10-28 9:48 ` Aneesh Kumar K.V [this message]
2019-10-28 9:48 ` [RFC PATCH 4/4] libnvdimm/namespace: Add debug check while initializing namespace resource size Aneesh Kumar K.V
2019-10-28 21:21 ` [RFC PATCH 1/4] libnvdimm/namespace: Make namespace size validation arch dependent Ira Weiny
2019-10-29 4:34 ` Aneesh Kumar K.V
2019-10-28 23:08 ` Dan Williams
2019-10-29 4:34 ` Aneesh Kumar K.V
2019-10-29 5:30 ` Dan Williams
2019-10-31 5:35 ` Aneesh Kumar K.V
2019-10-31 6:30 ` Dan Williams
2019-10-31 8:37 ` Aneesh Kumar K.V
2019-10-31 15:53 ` Dan Williams
2019-11-06 10:44 ` Aneesh Kumar K.V
2019-11-16 12:15 ` Aneesh Kumar K.V
2019-11-16 18:50 ` Dan Williams
2019-11-18 9:51 ` Aneesh Kumar K.V
2019-11-19 17:58 ` Dan Williams
2019-11-20 3:19 ` Aneesh Kumar K.V
2019-11-20 3:46 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028094825.21448-3-aneesh.kumar@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).