From: Vishal Verma <vishal.l.verma@intel.com>
To: <linux-nvdimm@lists.01.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Subject: [ndctl PATCH v3 1/2] ndctl/namespace: remove open coded is_namespace_active()
Date: Mon, 4 Nov 2019 13:16:14 -0700 [thread overview]
Message-ID: <20191104201615.30828-1-vishal.l.verma@intel.com> (raw)
Replace the open coded namespace active check with the one provided by
libndctl - ndctl_namespace_is_active().
is_namespace_active() additionally checked for a non-NULL 'ndns', which
the libndctl API doesn't do. However, all the callers either performed
that check themselves, or made prior assumptions about ndns being valid
by dereferencing it earlier.
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
ndctl/namespace.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/ndctl/namespace.c b/ndctl/namespace.c
index 7fb0007..ccd46d0 100644
--- a/ndctl/namespace.c
+++ b/ndctl/namespace.c
@@ -453,14 +453,6 @@ static int setup_namespace(struct ndctl_region *region,
return rc;
}
-static int is_namespace_active(struct ndctl_namespace *ndns)
-{
- return ndns && (ndctl_namespace_is_enabled(ndns)
- || ndctl_namespace_get_pfn(ndns)
- || ndctl_namespace_get_dax(ndns)
- || ndctl_namespace_get_btt(ndns));
-}
-
/*
* validate_namespace_options - init parameters for setup_namespace
* @region: parent of the namespace to create / reconfigure
@@ -787,7 +779,7 @@ static struct ndctl_namespace *region_get_namespace(struct ndctl_region *region)
/* prefer the 0th namespace if it is idle */
ndctl_namespace_foreach(region, ndns)
if (ndctl_namespace_get_id(ndns) == 0
- && !is_namespace_active(ndns))
+ && !ndctl_namespace_is_active(ndns))
return ndns;
return ndctl_region_get_namespace_seed(region);
}
@@ -827,7 +819,7 @@ static int namespace_create(struct ndctl_region *region)
p.size = available;
ndns = region_get_namespace(region);
- if (!ndns || is_namespace_active(ndns)) {
+ if (!ndns || ndctl_namespace_is_active(ndns)) {
debug("%s: no %s namespace seed\n", devname,
ndns ? "idle" : "available");
return -EAGAIN;
@@ -1074,7 +1066,7 @@ static int namespace_reconfig(struct ndctl_region *region,
}
ndns = region_get_namespace(region);
- if (!ndns || is_namespace_active(ndns)) {
+ if (!ndns || !ndctl_namespace_is_active(ndns)) {
debug("%s: no %s namespace seed\n",
ndctl_region_get_devname(region),
ndns ? "idle" : "available");
--
2.20.1
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next reply other threads:[~2019-11-04 20:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 20:16 Vishal Verma [this message]
2019-11-04 20:16 ` [ndctl PATCH v3 2/2] ndctl/namespace: introduce ndctl_namespace_is_configuration_idle() Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104201615.30828-1-vishal.l.verma@intel.com \
--to=vishal.l.verma@intel.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).