linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] test/dax.sh: correct the pmd pagefault counts generated by dax-pmd
@ 2020-03-20  2:12 XiaoLi Feng
  2020-03-20  2:36 ` Dan Williams
  0 siblings, 1 reply; 5+ messages in thread
From: XiaoLi Feng @ 2020-03-20  2:12 UTC (permalink / raw)
  To: linux-nvdimm; +Cc: Xiaoli Feng

From: Xiaoli Feng <xifeng@redhat.com>

For directIO, cannot generate pmd pagefault by pread|pwrite|read|write
if do not map fd to memory. In dax-pmd.c, case 1 and case 4 each only
generate once pmd pagefault. So change the all counts from 10 to 8.

Signed-off-by: Xiaoli Feng <xifeng@redhat.com>
---
 test/dax.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/dax.sh b/test/dax.sh
index 3933107..bd08641 100755
--- a/test/dax.sh
+++ b/test/dax.sh
@@ -40,13 +40,13 @@ run_test() {
 	# Fragile hack to double check the kernel services this test
 	# with successful pmd faults. If dax-pmd.c ever changes the
 	# number of times the dax_pmd_fault_done trace point fires the
-	# hack needs to be updated from 10 expected firings and the
+	# hack needs to be updated from 8 expected firings and the
 	# result of success (NOPAGE).
 	count=0
 	rc=1
 	while read -r p; do
 		[[ $p ]] || continue
-		if [ "$count" -lt 10 ]; then
+		if [ "$count" -lt 8 ]; then
 			if [ "$p" != "0x100" ] && [ "$p" != "NOPAGE" ]; then
 				cleanup "$1"
 			fi
@@ -54,7 +54,7 @@ run_test() {
 		count=$((count + 1))
 	done < <(trace-cmd report | awk '{ print $21 }')
 
-	if [ $count -lt 10 ]; then
+	if [ $count -lt 8 ]; then
 		cleanup "$1"
 	fi
 }
-- 
2.18.1
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-20  5:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20  2:12 [PATCH v1] test/dax.sh: correct the pmd pagefault counts generated by dax-pmd XiaoLi Feng
2020-03-20  2:36 ` Dan Williams
2020-03-20  3:18   ` Xiaoli Feng
2020-03-20  3:37     ` Dan Williams
2020-03-20  5:16       ` Xiaoli Feng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).