From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52786C433E0 for ; Mon, 1 Jun 2020 11:07:55 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D8372077D for ; Mon, 1 Jun 2020 11:07:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uzHMZmy+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D8372077D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E2CF6100DD88D; Mon, 1 Jun 2020 04:03:10 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver= Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CBAA5100DEFFD for ; Mon, 1 Jun 2020 04:03:08 -0700 (PDT) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB61820657; Mon, 1 Jun 2020 11:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591009672; bh=oeg5LhQy9jYN0KsGCtEYzL2rtk3xXb3RO+RekWTh9gA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uzHMZmy+OOG0e7UVv731fhdgt4V/9SDDlnENqRerylJSTUI9fCfl0fT/Maxxtqnak lYPmkfXM4GYg9osUrXOcmsgaV1996F7zDgWJWqmRfdLNNNyqnZd/YX8tLXgQ/2UYZe IQrc1CS2WZp0l/j663+qV8faMzbjPoyHbK6IM4Tk= Date: Mon, 1 Jun 2020 13:07:50 +0200 From: Greg KH To: Dan Williams Subject: Re: [5.4-stable PATCH 0/7] libnvdimm: Cross-arch compatible namespace alignment Message-ID: <20200601110750.GB124421@kroah.com> References: <159010426294.1062454.8853083370975871627.stgit@dwillia2-desk3.amr.corp.intel.com> <20200522115800.GA1451824@kroah.com> <20200522120009.GA1456052@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Message-ID-Hash: 2RBCEZWF6L3YXHB5GIFZOSZJFNB5IMRZ X-Message-ID-Hash: 2RBCEZWF6L3YXHB5GIFZOSZJFNB5IMRZ X-MailFrom: gregkh@linuxfoundation.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: stable , Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Christoph Hellwig , "Aneesh Kumar K.V" , linux-nvdimm X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, May 26, 2020 at 01:52:21PM -0700, Dan Williams wrote: > On Tue, May 26, 2020 at 1:49 PM Jeff Moyer wrote: > > > > Dan Williams writes: > > > > >> What problems with 5.4.y and 5.6.y is this series fixing > > >> that used to work before? > > > > > > The "used to work" bug fixed by this set is the fact that the kernel > > > used to force a 128MB (memory hotplug section size) alignment padding > > > on all persistent memory namespaces to enable DAX operation. The > > > support for sub-sections (2MB) dropped forced alignment padding, but > > > unfortunately introduced a regression for the case of trying to create > > > multiple unaligned namespaces. When that bug triggers namespace > > > creation for the region is disabled, iirc, previously that lockout > > > scenario was prevented. > > > > > > Jeff, can you corroborate this? > > > > So, I don't pretend to remember the exact state of brokenness for each > > iteration. :) As far as I can recall, though, the issue you describe > > with a misaligned namespace preventing further namespace creation was > > present in all kernels up until it was finally fixed. > > Well, if it was always there, then there is nothing to fix, and I > misremembered that we went backwards. > > > > I otherwise agree, if the above never worked then this can all wait > > > for v5.7 upgrades. > > > > I can test specific kernel versions if that would help out. > > Thanks for that offer, but outside of a clear regression I don't think > this meets -stable criteria. I agree, I'll drop this series from my pending-queue. thanks, greg k-h _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org