From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4817AC433E0 for ; Thu, 9 Jul 2020 02:13:56 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C48C20739 for ; Thu, 9 Jul 2020 02:13:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XR04+03w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C48C20739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id EEBE91118BAE6; Wed, 8 Jul 2020 19:13:55 -0700 (PDT) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2001:8b0:10b:1236::1; helo=casper.infradead.org; envelope-from=willy@infradead.org; receiver= Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A3E5111661B8 for ; Wed, 8 Jul 2020 19:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qi5089B5TBHI+zy9mDefYNvDdHyy2eklBkVImsmfAA8=; b=XR04+03woT3Wc7Z/57jVKd4hjt 3/E+cPTx2AQKCpc/7RreVQxlA9fQYhnyQYvjGihVTwBeUhMvD1az1bE+aXIowHLHsO4PPVi+sxQwA w3nQAbkppGId8GQAhA5vINNi51acayCJgaGvH8tDYh9hhuTWECwDBu6AGIzdVjzzQC3Zgoo+4Dbnz AZjcV2gbkzzZX2ShVFGcqhY1KThJMO/jobs64MREKH5Ezengt4WKDQkr3yw0rrWp+e+/1nIZ1URDR u8M4sp6A3rWRF3TEykU38Xw06lEG6SCF2w3ZwXpgRBaTt6syvQbk7T5XdAmus0UblYhhdytIy8B1y yTszHv4A==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtM1h-0006v4-Cd; Thu, 09 Jul 2020 02:11:06 +0000 Date: Thu, 9 Jul 2020 03:11:04 +0100 From: Matthew Wilcox To: Jia He Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory Message-ID: <20200709021104.GZ25523@casper.infradead.org> References: <20200709020629.91671-1-justin.he@arm.com> <20200709020629.91671-5-justin.he@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200709020629.91671-5-justin.he@arm.com> Message-ID-Hash: 6O4UMR6WZC6A3NMKEOOJBM2CTYDSALMK X-Message-ID-Hash: 6O4UMR6WZC6A3NMKEOOJBM2CTYDSALMK X-MailFrom: willy@infradead.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Yoshinori Sato , Rich Felker , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , David Hildenbrand , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , Baoquan He , Chuhong Yuan , Mike Rapoport , Masahiro Yamada , Michal Hocko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org, Jonathan Cameron , Kaly Xin X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > After a general version of __weak memory_add_physaddr_to_nid implemented > and exported , it is no use exporting twice in arch directory even if > e,g, ia64/x86 have their specific version. > > This is to suppress the modpost warning: > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > Previous export was in vmlinux It's bad form to introduce a warning and then send a follow-up patch to fix the warning. Just fold this patch into patch 1/6. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org