From: Jan Kara <jack@suse.cz>
To: Jane Chu <jane.chu@oracle.com>
Cc: Coly Li <colyli@suse.de>,
linux-nvdimm@lists.01.org, msuchanek@suse.com,
ailiopoulos@suse.com, Jan Kara <jack@suse.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Subject: Re: [PATCH v3] dax: print error message by pr_info() in __generic_fsdax_supported()
Date: Mon, 27 Jul 2020 23:44:47 +0200 [thread overview]
Message-ID: <20200727214447.GN5284@quack2.suse.cz> (raw)
In-Reply-To: <7366fc46-48ee-8c9a-c8f2-8e4e03919880@oracle.com>
On Mon 27-07-20 10:02:11, Jane Chu wrote:
> Hi,
>
> On 7/25/2020 9:24 AM, Coly Li wrote:
> > It is not simple to make dax_supported() from struct dax_operations
> > or __generic_fsdax_supported() to return exact failure type right now.
> > So the simplest fix is to use pr_info() to print all the error messages
> > inside __generic_fsdax_supported(). Then users may find informative clue
> > from the kernel message at least.
>
> I happen to notice that some servers set their printk levels at 4 by default
> to minimize console messages:
> # cat /proc/sys/kernel/printk
> 4 4 1 7
> So I'm wondering if you would consider pr_error() instead of pr_info() ?
I don't think this is a good reason to raise priority of this message -
with this logic applied, all info messages should be raised to error level
because someone may find them useful :). And then people raise printk
loglevel because the kernel is too noisy... Personally I think that
pr_info() is fine because there will be error message about unsupported dax
setup from the filesystem and if sysadmin wishes, (s)he can always lookup
info messages in dmesg.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-07-27 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 16:24 [PATCH v3] dax: print error message by pr_info() in __generic_fsdax_supported() Coly Li
2020-07-27 17:02 ` Jane Chu
2020-07-27 21:44 ` Jan Kara [this message]
2020-07-27 23:28 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727214447.GN5284@quack2.suse.cz \
--to=jack@suse.cz \
--cc=ailiopoulos@suse.com \
--cc=colyli@suse.de \
--cc=jack@suse.com \
--cc=jane.chu@oracle.com \
--cc=linux-nvdimm@lists.01.org \
--cc=msuchanek@suse.com \
--cc=pankaj.gupta.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).