From: Zhen Lei <thunder.leizhen@huawei.com>
To: Oliver O'Halloran <oohall@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Markus Elfring <Markus.Elfring@web.de>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v2 1/4] libnvdimm: fix memmory leaks in of_pmem.c
Date: Wed, 19 Aug 2020 10:05:00 +0800 [thread overview]
Message-ID: <20200819020503.3079-2-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20200819020503.3079-1-thunder.leizhen@huawei.com>
The memory priv->bus_desc.provider_name allocated by kstrdup() is not
freed correctly.
Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/nvdimm/of_pmem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
index 10dbdcdfb9ce913..1292ffca7b2ecc0 100644
--- a/drivers/nvdimm/of_pmem.c
+++ b/drivers/nvdimm/of_pmem.c
@@ -36,6 +36,7 @@ static int of_pmem_region_probe(struct platform_device *pdev)
priv->bus = bus = nvdimm_bus_register(&pdev->dev, &priv->bus_desc);
if (!bus) {
+ kfree(priv->bus_desc.provider_name);
kfree(priv);
return -ENODEV;
}
@@ -83,6 +84,7 @@ static int of_pmem_region_remove(struct platform_device *pdev)
struct of_pmem_private *priv = platform_get_drvdata(pdev);
nvdimm_bus_unregister(priv->bus);
+ kfree(priv->bus_desc.provider_name);
kfree(priv);
return 0;
--
1.8.3
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-08-19 2:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 2:04 [PATCH v2 0/4] bugfix and optimize for drivers/nvdimm Zhen Lei
2020-08-19 2:05 ` Zhen Lei [this message]
2020-08-19 12:28 ` [PATCH v2 1/4] libnvdimm: Fix memory leaks in of_pmem.c Markus Elfring
2020-08-19 13:34 ` Leizhen (ThunderTown)
2020-08-19 13:35 ` Oliver O'Halloran
2020-08-19 14:18 ` Leizhen (ThunderTown)
2020-08-19 13:37 ` [PATCH v2 1/4] libnvdimm: fix memmory " Oliver O'Halloran
2020-08-19 14:19 ` Leizhen (ThunderTown)
2020-08-19 2:05 ` [PATCH v2 2/4] libnvdimm: add sanity check for provider_name in of_pmem_region_probe() Zhen Lei
2020-08-19 2:05 ` [PATCH v2 3/4] libnvdimm/bus: simplify walk_to_nvdimm_bus() Zhen Lei
2020-08-19 12:40 ` Markus Elfring
2020-08-19 13:35 ` Leizhen (ThunderTown)
2020-08-19 2:05 ` [PATCH v2 4/4] libnvdimm/region: reduce an unnecessary if branch in nd_region_create() Zhen Lei
2020-08-19 12:20 ` [PATCH v2 0/4] bug fix and optimize for drivers/nvdimm Markus Elfring
2020-08-19 13:30 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819020503.3079-2-thunder.leizhen@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=oohall@gmail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).