linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] device-dax: make dev_dax_kmem_probe() static
@ 2020-09-12  3:39 Jason Yan
  2020-09-17 17:20 ` Ira Weiny
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-09-12  3:39 UTC (permalink / raw)
  To: dan.j.williams, vishal.l.verma, dave.jiang, akpm, sfr, linux-nvdimm
  Cc: Jason Yan, Hulk Robot

This eliminates the following sparse warning:

drivers/dax/kmem.c:38:5: warning: symbol 'dev_dax_kmem_probe' was not
declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/dax/kmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c
index 7dcb2902e9b1..e79afbadd4e0 100644
--- a/drivers/dax/kmem.c
+++ b/drivers/dax/kmem.c
@@ -35,7 +35,7 @@ static int dax_kmem_range(struct dev_dax *dev_dax, int i, struct range *r)
 	return 0;
 }
 
-int dev_dax_kmem_probe(struct dev_dax *dev_dax)
+static int dev_dax_kmem_probe(struct dev_dax *dev_dax)
 {
 	int numa_node = dev_dax->target_node;
 	struct device *dev = &dev_dax->dev;
-- 
2.25.4
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] device-dax: make dev_dax_kmem_probe() static
  2020-09-12  3:39 [PATCH] device-dax: make dev_dax_kmem_probe() static Jason Yan
@ 2020-09-17 17:20 ` Ira Weiny
  0 siblings, 0 replies; 2+ messages in thread
From: Ira Weiny @ 2020-09-17 17:20 UTC (permalink / raw)
  To: Jason Yan; +Cc: akpm, sfr, linux-nvdimm, Hulk Robot

On Sat, Sep 12, 2020 at 11:39:01AM +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
> 
> drivers/dax/kmem.c:38:5: warning: symbol 'dev_dax_kmem_probe' was not
> declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  drivers/dax/kmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c
> index 7dcb2902e9b1..e79afbadd4e0 100644
> --- a/drivers/dax/kmem.c
> +++ b/drivers/dax/kmem.c
> @@ -35,7 +35,7 @@ static int dax_kmem_range(struct dev_dax *dev_dax, int i, struct range *r)
>  	return 0;
>  }
>  
> -int dev_dax_kmem_probe(struct dev_dax *dev_dax)
> +static int dev_dax_kmem_probe(struct dev_dax *dev_dax)
>  {
>  	int numa_node = dev_dax->target_node;
>  	struct device *dev = &dev_dax->dev;
> -- 
> 2.25.4
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-17 17:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-12  3:39 [PATCH] device-dax: make dev_dax_kmem_probe() static Jason Yan
2020-09-17 17:20 ` Ira Weiny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).