From: Jan Kara <jack@suse.cz>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org,
Adrian Huang <adrianhuang0701@gmail.com>,
Coly Li <colyli@suse.de>, Mikulas Patocka <mpatocka@redhat.com>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: dm: Call proper helper to determine dax support
Date: Thu, 17 Sep 2020 10:08:33 +0200 [thread overview]
Message-ID: <20200917080833.GB9555@quack2.suse.cz> (raw)
In-Reply-To: <20200916152204.GA29829@redhat.com>
On Wed 16-09-20 11:22:05, Mike Snitzer wrote:
> On Wed, Sep 16 2020 at 11:14am -0400,
> Jan Kara <jack@suse.cz> wrote:
>
> > DM was calling generic_fsdax_supported() to determine whether a device
> > referenced in the DM table supports DAX. However this is a helper for "leaf" device drivers so that
> > they don't have to duplicate common generic checks. High level code
> > should call dax_supported() helper which that calls into appropriate
> > helper for the particular device. This problem manifested itself as
> > kernel messages:
> >
> > dm-3: error: dax access failed (-95)
> >
> > when lvm2-testsuite run in cases where a DM device was stacked on top of
> > another DM device.
> >
> > Fixes: 7bf7eac8d648 ("dax: Arrange for dax_supported check to span multiple devices")
> > Tested-by: Adrian Huang <ahuang12@lenovo.com>
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> Looked good:
>
> Acked-by: Mike Snitzer <snitzer@redhat.com>
Thanks!
> This fix should Cc stable@ right?
Yes, it should go to stable.
> > drivers/dax/super.c | 4 ++++
> > drivers/md/dm-table.c | 3 +--
> > include/linux/dax.h | 11 +++++++++--
> > 3 files changed, 14 insertions(+), 4 deletions(-)
> >
> > This patch should go in together with Adrian's
> > https://lore.kernel.org/linux-nvdimm/20200916133923.31-1-adrianhuang0701@gmail.com
>
> Sure, but there really isn't a dependency right?
Yes, it isn't a context or strict functional dependency. But without this
patch Adrian's patch just trades one set of warnings for another set of
warnings...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-09-17 8:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 15:14 [PATCH] dm: Call proper helper to determine dax support Jan Kara
2020-09-16 15:22 ` Mike Snitzer
2020-09-17 8:08 ` Jan Kara [this message]
2020-09-17 9:28 ` [PATCH] " Dan Williams
2020-09-17 10:42 ` Jan Kara
2020-09-17 14:57 ` Huang Adrian
2020-09-17 15:03 ` Huang Adrian
2020-09-17 17:49 ` Dan Williams
2020-09-18 5:41 ` Dan Williams
2020-09-18 12:41 ` Huang Adrian
2020-09-18 12:48 ` Huang Adrian
2020-09-18 20:12 ` Dan Williams
2020-09-18 12:34 ` Huang Adrian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917080833.GB9555@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adrianhuang0701@gmail.com \
--cc=agk@redhat.com \
--cc=colyli@suse.de \
--cc=linux-nvdimm@lists.01.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).