* [PATCH] libnvdimm/pmem: remove unused header.
@ 2020-12-25 1:35 Jianpeng Ma
2020-12-28 17:17 ` Ira Weiny
0 siblings, 1 reply; 6+ messages in thread
From: Jianpeng Ma @ 2020-12-25 1:35 UTC (permalink / raw)
To: dan.j.williams; +Cc: linux-nvdimm, hch
'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot
remove the related header file.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
---
drivers/nvdimm/pmem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 875076b0ea6c..f33bdae626ba 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -23,7 +23,6 @@
#include <linux/uio.h>
#include <linux/dax.h>
#include <linux/nd.h>
-#include <linux/backing-dev.h>
#include <linux/mm.h>
#include <asm/cacheflush.h>
#include "pmem.h"
--
2.29.2
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] libnvdimm/pmem: remove unused header.
2020-12-25 1:35 [PATCH] libnvdimm/pmem: remove unused header Jianpeng Ma
@ 2020-12-28 17:17 ` Ira Weiny
2021-01-04 21:16 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Ira Weiny @ 2020-12-28 17:17 UTC (permalink / raw)
To: Jianpeng Ma; +Cc: linux-nvdimm, hch
On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote:
> 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot
This information should be part of a fixes tag.
Other than that looks ok.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> remove the related header file.
>
> Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
> ---
> drivers/nvdimm/pmem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 875076b0ea6c..f33bdae626ba 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -23,7 +23,6 @@
> #include <linux/uio.h>
> #include <linux/dax.h>
> #include <linux/nd.h>
> -#include <linux/backing-dev.h>
> #include <linux/mm.h>
> #include <asm/cacheflush.h>
> #include "pmem.h"
> --
> 2.29.2
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libnvdimm/pmem: remove unused header.
2020-12-28 17:17 ` Ira Weiny
@ 2021-01-04 21:16 ` Dan Williams
2021-01-04 22:18 ` Ira Weiny
0 siblings, 1 reply; 6+ messages in thread
From: Dan Williams @ 2021-01-04 21:16 UTC (permalink / raw)
To: Ira Weiny; +Cc: Jianpeng Ma, linux-nvdimm, Christoph Hellwig
On Mon, Dec 28, 2020 at 9:18 AM Ira Weiny <ira.weiny@intel.com> wrote:
>
> On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote:
> > 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot
>
> This information should be part of a fixes tag.
Oh, I was just about to comment "don't provide a Fixes tag for pure
cleanups". Fixes is for functional issues that a backporter should
consider.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libnvdimm/pmem: remove unused header.
2021-01-04 21:16 ` Dan Williams
@ 2021-01-04 22:18 ` Ira Weiny
2021-01-04 22:32 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Ira Weiny @ 2021-01-04 22:18 UTC (permalink / raw)
To: Dan Williams; +Cc: Jianpeng Ma, linux-nvdimm, Christoph Hellwig
On Mon, Jan 04, 2021 at 01:16:32PM -0800, Dan Williams wrote:
> On Mon, Dec 28, 2020 at 9:18 AM Ira Weiny <ira.weiny@intel.com> wrote:
> >
> > On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote:
> > > 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot
> >
> > This information should be part of a fixes tag.
>
> Oh, I was just about to comment "don't provide a Fixes tag for pure
> cleanups". Fixes is for functional issues that a backporter should
> consider.
I thought this was discussed recently and it was concluded that 'fixes' does
not indicate something should be backported?
...
https://lore.kernel.org/lkml/X8flmVAwl0158872@kroah.com/
At least that is what Greg KH said. But Dave C. was not happy with this...
:-/
Sorry...
Ira
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libnvdimm/pmem: remove unused header.
2021-01-04 22:18 ` Ira Weiny
@ 2021-01-04 22:32 ` Dan Williams
2021-01-05 2:13 ` Ira Weiny
0 siblings, 1 reply; 6+ messages in thread
From: Dan Williams @ 2021-01-04 22:32 UTC (permalink / raw)
To: Ira Weiny; +Cc: Jianpeng Ma, linux-nvdimm, Christoph Hellwig
On Mon, Jan 4, 2021 at 2:19 PM Ira Weiny <ira.weiny@intel.com> wrote:
>
> On Mon, Jan 04, 2021 at 01:16:32PM -0800, Dan Williams wrote:
> > On Mon, Dec 28, 2020 at 9:18 AM Ira Weiny <ira.weiny@intel.com> wrote:
> > >
> > > On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote:
> > > > 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot
> > >
> > > This information should be part of a fixes tag.
> >
> > Oh, I was just about to comment "don't provide a Fixes tag for pure
> > cleanups". Fixes is for functional issues that a backporter should
> > consider.
>
> I thought this was discussed recently and it was concluded that 'fixes' does
> not indicate something should be backported?
>
> ...
>
> https://lore.kernel.org/lkml/X8flmVAwl0158872@kroah.com/
>
> At least that is what Greg KH said. But Dave C. was not happy with this...
I was thinking of it more from the distro automation tooling that I
know fires up it sees a "Fixes" tag. At a minimum this would make
those systems / humans fire up just to notice, "oh, just a plain
cleanup with no logical side-effects".
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libnvdimm/pmem: remove unused header.
2021-01-04 22:32 ` Dan Williams
@ 2021-01-05 2:13 ` Ira Weiny
0 siblings, 0 replies; 6+ messages in thread
From: Ira Weiny @ 2021-01-05 2:13 UTC (permalink / raw)
To: Dan Williams; +Cc: Jianpeng Ma, linux-nvdimm, Christoph Hellwig
On Mon, Jan 04, 2021 at 02:32:06PM -0800, Dan Williams wrote:
> On Mon, Jan 4, 2021 at 2:19 PM Ira Weiny <ira.weiny@intel.com> wrote:
> >
> > On Mon, Jan 04, 2021 at 01:16:32PM -0800, Dan Williams wrote:
> > > On Mon, Dec 28, 2020 at 9:18 AM Ira Weiny <ira.weiny@intel.com> wrote:
> > > >
> > > > On Fri, Dec 25, 2020 at 09:35:46AM +0800, Jianpeng Ma wrote:
> > > > > 'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot
> > > >
> > > > This information should be part of a fixes tag.
> > >
> > > Oh, I was just about to comment "don't provide a Fixes tag for pure
> > > cleanups". Fixes is for functional issues that a backporter should
> > > consider.
> >
> > I thought this was discussed recently and it was concluded that 'fixes' does
> > not indicate something should be backported?
> >
> > ...
> >
> > https://lore.kernel.org/lkml/X8flmVAwl0158872@kroah.com/
> >
> > At least that is what Greg KH said. But Dave C. was not happy with this...
>
> I was thinking of it more from the distro automation tooling that I
> know fires up it sees a "Fixes" tag. At a minimum this would make
> those systems / humans fire up just to notice, "oh, just a plain
> cleanup with no logical side-effects".
I'm not really following but I don't think it is a big deal either way. It
just seemed like the text used looked like a 'fixes' line and seemed ok to put
in there.
In this case it is probably fine.
Sorry for the noise,
Ira
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-05 2:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-25 1:35 [PATCH] libnvdimm/pmem: remove unused header Jianpeng Ma
2020-12-28 17:17 ` Ira Weiny
2021-01-04 21:16 ` Dan Williams
2021-01-04 22:18 ` Ira Weiny
2021-01-04 22:32 ` Dan Williams
2021-01-05 2:13 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).