Linux-NVDIMM Archive on lore.kernel.org
 help / color / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Barret Rhoden <brho@google.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>
Cc: David Hildenbrand <david@redhat.com>,
	Alexander Duyck <alexander.h.duyck@linux.intel.com>,
	linux-nvdimm@lists.01.org, x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, jason.zeng@intel.com
Subject: Re: [PATCH v5 1/2] mm: make dev_pagemap_mapping_shift() externally visible
Date: Wed, 15 Jan 2020 19:33:49 +0100
Message-ID: <207bd03c-df82-f27b-bdb8-1aef33429dd7@redhat.com> (raw)
In-Reply-To: <e004e742-f755-c22c-57bb-acfe30971c7d@google.com>

On 16/12/19 18:59, Barret Rhoden wrote:
> Does KVM-x86 need its own names for the levels?  If not, I could convert
> the PT_PAGE_TABLE_* stuff to PG_LEVEL_* stuff.

Yes, please do.  For the 2M/4M case, it's only incorrect to use 2M here:

        if (PTTYPE == 32 && walker->level == PT_DIRECTORY_LEVEL && is_cpuid_PSE36())
                gfn += pse36_gfn_delta(pte);

And for that you can even use "> PG_LEVEL_4K" if you think it's nicer.

Paolo
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

  parent reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 18:22 [PATCH v5 0/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2019-12-12 18:22 ` [PATCH v5 1/2] mm: make dev_pagemap_mapping_shift() externally visible Barret Rhoden
2019-12-13 17:47   ` Sean Christopherson
2019-12-13 18:13     ` Dan Williams
2019-12-16 17:59     ` Barret Rhoden
2019-12-18  0:18       ` Sean Christopherson
2020-01-15 18:33       ` Paolo Bonzini [this message]
2019-12-12 18:22 ` [PATCH v5 2/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2019-12-12 18:47   ` Liran Alon
2019-12-12 18:49     ` Liran Alon
2019-12-12 19:55       ` Barret Rhoden
2019-12-13  1:07         ` Liran Alon
2019-12-13 14:13           ` Barret Rhoden
2019-12-13 17:19           ` Sean Christopherson
2019-12-13 17:31             ` Liran Alon
2019-12-13 17:50               ` Sean Christopherson
2019-12-13 18:08                 ` Liran Alon
2019-12-16 16:05             ` Barret Rhoden
2020-01-07 19:05               ` Sean Christopherson
2020-01-07 19:19                 ` Barret Rhoden
2020-01-08  1:20                   ` Sean Christopherson
2020-01-08  1:39                     ` Dan Williams

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=207bd03c-df82-f27b-bdb8-1aef33429dd7@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=brho@google.com \
    --cc=david@redhat.com \
    --cc=jason.zeng@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=sean.j.christopherson@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVDIMM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvdimm/0 linux-nvdimm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvdimm linux-nvdimm/ https://lore.kernel.org/linux-nvdimm \
		linux-nvdimm@lists.01.org
	public-inbox-index linux-nvdimm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.01.lists.linux-nvdimm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git