From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5ED8721959CB2 for ; Mon, 12 Nov 2018 12:26:59 -0800 (PST) Subject: Re: [PATCH 07/11] libnvdimm/security: add overwrite status notification References: <154180093865.70506.6858789591063128903.stgit@djiang5-desk3.ch.intel.com> <154180166375.70506.1085533195452285285.stgit@djiang5-desk3.ch.intel.com> From: Dave Jiang Message-ID: <503100fd-bbd4-2ea2-803b-b9df3913a9cb@intel.com> Date: Mon, 12 Nov 2018 13:26:58 -0700 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Elliott, Robert (Persistent Memory)" , "Williams, Dan J" , "zohar@linux.vnet.ibm.com" Cc: "linux-nvdimm@lists.01.org" List-ID: On 11/9/18 7:59 PM, Elliott, Robert (Persistent Memory) wrote: >> -----Original Message----- >> From: Linux-nvdimm On Behalf Of >> Dave Jiang >> Sent: Friday, November 09, 2018 4:14 PM >> Subject: [PATCH 07/11] libnvdimm/security: add overwrite status >> notification >> > ... >> @@ -2033,6 +2033,11 @@ static int acpi_nfit_register_dimms(struct >> acpi_nfit_desc *acpi_desc) >> if (!nvdimm) >> continue; >> >> +rc = nvdimm_setup_security_events(nvdimm); >> +if (rc < 0) >> +dev_warn(acpi_desc->dev, >> +"no security event setup >> failed\n"); > > That seems like a double negative. > > Printing the rc value (or better yet, the string for it) > is always helpful too. Thanks Robert. Will fix. > > --- > Robert Elliott, HPE Persistent Memory > > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm