From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brice Goglin Subject: Re: [ndctl PATCH 2/2] libdaxctl: fix device reconfiguration with builtin drivers Date: Wed, 4 Sep 2019 19:30:13 +0200 Message-ID: <544e35d2-8600-0f93-79f3-642a0b851710@inria.fr> References: <20190904010819.11012-1-vishal.l.verma@intel.com> <20190904010819.11012-2-vishal.l.verma@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190904010819.11012-2-vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Vishal Verma , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Cc: Dave Hansen List-Id: linux-nvdimm@lists.01.org VGhhbmtzLCB0aGlzIHdvcmtzIGhlcmUgKG9uIGEgRGViaWFuIHRlc3Rpbmcgd2l0aCB2YW5pbGxh IDUuMi4xMSBhbmQKNS4zLXJjNykuCgpCcmljZQoKCkxlIDA0LzA5LzIwMTkgw6AgMDM6MDgsIFZp c2hhbCBWZXJtYSBhIMOpY3JpdMKgOgo+IFdoZW4gdGhlIGRyaXZlciBvZiBhIGdpdmVuIHJlY29u ZmlndXJhdGlvbiBtb2RlIGlzIGJ1aWx0aW4sIGxpYmRheGN0bAo+IGlzbid0IGFibGUgdG8gYnVp bGQgYSBtb2R1bGUgbG9va3VwIGxpc3QgdXNpbmcga21vZC4gSG93ZXZlciwgaXQgZG9lc24ndAo+ IG5lZWQgdG8gZmFpbCBpbiB0aGlzIGNhc2UsIGFzIGl0IGlzIGFjY2VwdGFibGUgZm9yIGEgZHJp dmVyIHRvIGJlCj4gYnVpbHRpbi4KPgo+IFVzZSB0aGUga21vZCAnaW5pdHN0YXRlJyB0byBkZXRl cm1pbmUgd2hldGhlciB0aGUgdGFyZ2V0IGRyaXZlciBtYXkgYmUKPiBidWlsdGluLCBhbmQgZW5z dXJlIGl0IGlzIGF2YWlsYWJsZSBieSBwcm9iaW5nIGl0IHZpYSBhIG5hbWVkIGxvb2t1cC4KPiBJ ZiBpdCBpcyBhdmFpbGFibGUsIHNraXAgdGhlIG1vZGFsaWFzIGJhc2VkIGxpc3Qgd2FsaywgYW5k IGJpbmQgdG8gaXQKPiBkaXJlY3RseS4KPgo+IExpbms6IGh0dHBzOi8vZ2l0aHViLmNvbS9wbWVt L25kY3RsL2lzc3Vlcy8xMDgKPiBDYzogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0BpbnRl bC5jb20+Cj4gUmVwb3J0ZWQtYnk6IEJyaWNlIEdvZ2xpbiA8QnJpY2UuR29nbGluQGlucmlhLmZy Pgo+IFJlcG9ydGVkLWJ5OiBEYXZlIEhhbnNlbiA8ZGF2ZS5oYW5zZW5AbGludXguaW50ZWwuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IFZpc2hhbCBWZXJtYSA8dmlzaGFsLmwudmVybWFAaW50ZWwuY29t Pgo+IC0tLQo+ICBkYXhjdGwvbGliL2xpYmRheGN0bC5jIHwgMzMgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspCj4KPiBk aWZmIC0tZ2l0IGEvZGF4Y3RsL2xpYi9saWJkYXhjdGwuYyBiL2RheGN0bC9saWIvbGliZGF4Y3Rs LmMKPiBpbmRleCBkOWYyYzMzLi43YTY1YmVkIDEwMDY0NAo+IC0tLSBhL2RheGN0bC9saWIvbGli ZGF4Y3RsLmMKPiArKysgYi9kYXhjdGwvbGliL2xpYmRheGN0bC5jCj4gQEAgLTg2OCw2ICs4Njgs MzcgQEAgREFYQ1RMX0VYUE9SVCBpbnQgZGF4Y3RsX2Rldl9pc19lbmFibGVkKHN0cnVjdCBkYXhj dGxfZGV2ICpkZXYpCj4gIAlyZXR1cm4gaXNfZW5hYmxlZChwYXRoKTsKPiAgfQo+ICAKPiArc3Rh dGljIGludCB0cnlfa21vZF9idWlsdGluKHN0cnVjdCBkYXhjdGxfZGV2ICpkZXYsIGNvbnN0IGNo YXIgKm1vZF9uYW1lKQo+ICt7Cj4gKwljb25zdCBjaGFyICpkZXZuYW1lID0gZGF4Y3RsX2Rldl9n ZXRfZGV2bmFtZShkZXYpOwo+ICsJc3RydWN0IGRheGN0bF9jdHggKmN0eCA9IGRheGN0bF9kZXZf Z2V0X2N0eChkZXYpOwo+ICsJc3RydWN0IGttb2RfbW9kdWxlICprbW9kOwo+ICsJaW50IHJjID0g LUVOWElPOwo+ICsKPiArCXJjID0ga21vZF9tb2R1bGVfbmV3X2Zyb21fbmFtZShjdHgtPmttb2Rf Y3R4LCBtb2RfbmFtZSwgJmttb2QpOwo+ICsJaWYgKHJjIDwgMCkgewo+ICsJCWVycihjdHgsICIl czogZmFpbGVkIGdldHRpbmcgbW9kdWxlIGZvcjogJXM6ICVzXG4iLAo+ICsJCQlkZXZuYW1lLCBt b2RfbmFtZSwgc3RyZXJyb3IoLXJjKSk7Cj4gKwkJcmV0dXJuIHJjOwo+ICsJfQo+ICsKPiArCWlm IChrbW9kX21vZHVsZV9nZXRfaW5pdHN0YXRlKGttb2QpICE9IEtNT0RfTU9EVUxFX0JVSUxUSU4p Cj4gKwkJcmV0dXJuIC1FTlhJTzsKPiArCj4gKwlkYmcoY3R4LCAiJXMgaW5zZXJ0aW5nIG1vZHVs ZTogJXNcbiIsIGRldm5hbWUsCj4gKwkJa21vZF9tb2R1bGVfZ2V0X25hbWUoa21vZCkpOwo+ICsJ cmMgPSBrbW9kX21vZHVsZV9wcm9iZV9pbnNlcnRfbW9kdWxlKGttb2QsCj4gKwkJCUtNT0RfUFJP QkVfQVBQTFlfQkxBQ0tMSVNULAo+ICsJCQlOVUxMLCBOVUxMLCBOVUxMLCBOVUxMKTsKPiArCWlm IChyYyA8IDApIHsKPiArCQllcnIoY3R4LCAiJXM6IGluc2VydCBmYWlsdXJlOiAlZFxuIiwgZGV2 bmFtZSwgcmMpOwo+ICsJCXJldHVybiByYzsKPiArCX0KPiArCWRldi0+bW9kdWxlID0ga21vZDsK PiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAgc3RhdGljIGludCBkYXhjdGxfaW5zZXJ0X2tt b2RfZm9yX21vZGUoc3RydWN0IGRheGN0bF9kZXYgKmRldiwKPiAgCQljb25zdCBjaGFyICptb2Rf bmFtZSkKPiAgewo+IEBAIC04NzcsNiArOTA4LDggQEAgc3RhdGljIGludCBkYXhjdGxfaW5zZXJ0 X2ttb2RfZm9yX21vZGUoc3RydWN0IGRheGN0bF9kZXYgKmRldiwKPiAgCWludCByYyA9IC1FTlhJ TzsKPiAgCj4gIAlpZiAoZGV2LT5rbW9kX2xpc3QgPT0gTlVMTCkgewo+ICsJCWlmICh0cnlfa21v ZF9idWlsdGluKGRldiwgbW9kX25hbWUpID09IDApCj4gKwkJCXJldHVybiAwOwo+ICAJCWVycihj dHgsICIlczogYSBtb2RhbGlhcyBsb29rdXAgbGlzdCB3YXMgbm90IGNyZWF0ZWRcbiIsCj4gIAkJ CQlkZXZuYW1lKTsKPiAgCQlyZXR1cm4gcmM7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5nIGxpc3QKTGludXgtbnZkaW1t QGxpc3RzLjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LW52ZGltbQo=